In the last year or so I’ve been noticing that a lot of backport PR’s are opened before the original change has landed in one of the development branches (master/staging/staging-next). It’s good to see the initiative to backport, however, it is also problematic, because its
- not uncommon that the change on the development branch needs to be changed first
- the original change may be rebased instead of merged as is, causing the “cherry picked from …” hash to be incorrect.
It’s worth mentioning here that I often rebase PR’s instead of merge them as is, especially is they consist of just a single commit, just to get rid of the “Merge …” noise.
In my opinion we should not open any backport PR’s that include cherry-picked commits until the original change is in for the above mentioned reasons. What do you say?