Enabling Firefox appmenu patches with appmenu-gtk3-module

dr460nf1r3 · May 27, 2023, 11:08am

Hello everyone!

I’m currently trying to get the app menu patches provided by Ubuntu for Firefox to work on a fork. The required appmenu-gtk3-module has already been packaged and works for every application but Firefox. They have been built from efforts already done here.

github.com

chaotic-cx/nyx/blob/fdc0cc27dced8adda75e138ada84c1d6dfc5da63/pkgs/appmenu-gtk3-module/default.nix

{ stdenv
, lib
, fetchFromGitLab
, fetchpatch
, meson
, cmake
, pkg-config
, systemd
, gtk-doc
, docbook-xsl-nons
, ninja
, glib
, gtk3
, wrapGAppsHook
}:

stdenv.mkDerivation rec {
  pname = "appmenu-gtk3-module";
  version = "0.7.6";

This file has been truncated. show original

github.com

chaotic-cx/nyx/blob/fdc0cc27dced8adda75e138ada84c1d6dfc5da63/modules/appmenu-gtk3-module.nix

{ inputs }: { config, lib, pkgs, ... }:
let
  cfg = config.chaotic.appmenu-gtk3-module;
in
{
  options = {
    chaotic.appmenu-gtk3-module.enable =
      lib.mkOption {
        default = false;
        description = ''
          Sets the proper environment variable to use appmenu-gtk3-module.
        '';
      };
  };
  config = {
    environment.sessionVariables = lib.mkIf cfg.enable {
      XDG_DATA_DIRS = [ "${pkgs.appmenu-gtk3-module}/share/gsettings-schemas/appmenu-gtk3-module-0.7.6" ];
    };

    environment.systemPackages = with pkgs; [ appmenu-gtk3-module ];

This file has been truncated. show original

The derivation of firedragon (the name of my fork) can be found here, it basically takes Librewolf patches and adds some more patches to enable advanced KDE / app menu integration:

github.com

chaotic-cx/nyx/blob/fdc0cc27dced8adda75e138ada84c1d6dfc5da63/pkgs/firedragon/firedragon.nix#L39


      
            while read patch_name; do
              echo "applying LibreWolf patch: $patch_name"
              patch -p1 < ${source}/$patch_name
            done <temp/patches.txt
          
          
  cp -r "${source-firedragon}/common/source_files/browser" .
            patch -p1 < ${source-firedragon}/common/patches/custom/add_firedragon_svg.patch
            patch -p1 < ${source-firedragon}/common/patches/custom/librewolf-pref-pane.patch
            patch -p1 < ${source-firedragon}/common/patches/custom/privacy-preferences.patch
            patch -p1 < ${source-firedragon}/common/patches/kde-upstream/mozilla-kde.patch
            patch -p1 < ${source-firedragon}/common/patches/kde-upstream/unity-menubar.patch
          
          
  cp ${source}/assets/search-config.json services/settings/dumps/main/search-config.json
            sed -i '/MOZ_NORMANDY/ s/True/False/' browser/moz.configure
            sed -i '/MOZ_SERVICES_HEALTHREPORT/ s/True/False/' browser/moz.configure
          '';
          
          
extraPrefsFiles = [ "${source-firedragon}/firedragon.cfg" ];
          
          
extraPoliciesFiles = [ "${source-firedragon}/distribution/policies.json" ];

This works very well on Archlinux, here an app menu is provided to KDE. It does not, however, on NixOS.
Already tried some things, such as adding gsettings-desktop-schemas to buildInputs as seen here, but that didn’t help either.

github.com

NixOS/nixpkgs/blob/461a1848630dceebd563b42918db93304af50b44/pkgs/applications/networking/browsers/chromium/default.nix#L168


      
          in stdenv.mkDerivation {
            pname = lib.optionalString ungoogled "ungoogled-"
              + "chromium${suffix}";
            inherit version;
          
          
  nativeBuildInputs = [
              makeWrapper ed
            ];
          
          
  buildInputs = [
              # needed for GSETTINGS_SCHEMAS_PATH
              gsettings-desktop-schemas glib gtk3 gtk4
          
          
    # needed for XDG_ICON_DIRS
              gnome.adwaita-icon-theme
          
          
    # Needed for kerberos at runtime
              libkrb5
            ];
          
          
  outputs = ["out" "sandbox"];

Does anyone have an idea what I might be missing in order to make it work?

greydot · March 14, 2024, 11:46am

ohai! Any luck with this?

dr460nf1r3 · March 14, 2024, 12:00pm

Sadly, not at all! Ubuntu seems to have abandoned their app menu patches when moving to Snap Firefox anyways, so (at least for me) it’s not longer relevant.

Are you the Lana Black from Latte Dock btw?

greydot · March 14, 2024, 12:08pm

Yup, that’s me.

If you wanna ask me about the Plasma 6 port, I’m working on it!

dr460nf1r3 · March 14, 2024, 12:30pm

Oh, no worries I didn’t mean to ask about it. I saw some of the work in the plasma6 branch already
The name looked familiar however and I wanted to say thanks for your efforts!