Fixing a typo in nixpkgs, sil

rickhull · October 25, 2022, 3:45pm

NixOS/nixpkgs/blob/6107f97012a0c134c5848125b5aa1b149b76d2c9/pkgs/games/sil/default.nix#L51

    
      
            # Wrap the program to set a user-local ANGBAND_PATH, and run the setup script to copy files into place
            # We could just use the options for a user-local save and scores dir, but it tried to write to the
            # lib directory anyway, so we might as well give everyone a copy
            wrapProgram $out/bin/sil \
              --run "set -u" \
              --run "export ANGBAND_PATH=\$HOME/.sil" \
              --run "${setup} ${src}/Sil/lib"
          '';
          
          
meta = {
            description = "A rouge-like game set in the first age of Middle-earth";
            longDescription = ''
              A game of adventure set in the first age of Middle-earth, when the world still
              rang with elven song and gleamed with dwarven mail.
          
          
    Walk the dark halls of Angband.  Slay creatures black and fell.  Wrest a shining
              Silmaril from Morgoth’s iron crown.
            '';
            homepage = "http://www.amirrorclear.net/flowers/game/sil/index.html";
            license = lib.licenses.gpl2;
            maintainers = [ lib.maintainers.michaelpj ];

Note: “A rouge-like game …”

Should be: “A rogue-like game …”

I’ve tried to make a PR to nixpkgs before, but wow is it a process. Just cloning nixpkgs is something I’d rather avoid if possible.

I’m curious if there is an easy way to make a fix like this, without necessarily shepherding it through the entire PR process. Then again, maybe this is a good exercise.

Also, separately, development on sil has stopped a while back, but it would be nice to package GitHub - sil-quirk/sil-q which is the fork in active development. I believe the packaging should be easier with their more modern Makefile, but I’m honestly just speculating. I’ve never made a nixpkg, but I wouldn’t mind trying, with some guidance or assistance.

abathur · October 25, 2022, 3:53pm

You can fork, edit, and PR entirely through GitHub’s site. Not the best experience for heavy lifting, but it’s fine for a typo fix.

rickhull · October 25, 2022, 4:04pm

Oh, I see sil-q is packaged in unstable!