Team info
All meeting notes
Attendees: @infinisil @tomberek Sergey @das_j @0x4A6F
Notes
- Discuss fix for Reaching a stable list formatting requires formatting twice · Issue #188 · NixOS/nixfmt · GitHub
-
Fix #188 by piegamesde · Pull Request #193 · NixOS/nixfmt · GitHub
- Closed in favor of the following
-
Add an AST pretty-printing mode by infinisil · Pull Request #202 · NixOS/nixfmt · GitHub
- Discussed, reviewed and merged
-
Fix #188 by piegamesde · Pull Request #193 · NixOS/nixfmt · GitHub
-
Add an AST pretty-printing mode by infinisil · Pull Request #202 · NixOS/nixfmt · GitHub
- Merged
-
Ignore symlinks when formatting by Lucus16 · Pull Request #57 · NixOS/nixfmt · GitHub
- Commented that we plan to deprecate directory mode
- Regarding python3Packages: format with nixfmt by mweinelt · Pull Request #313628 · NixOS/nixpkgs · GitHub
- @infinisil: See Matrix discussion
- We don’t need to wait until nixfmt is “stable” to do the initial larger refactoring
- What’s the target then?
- @0x4A6F: Can already start enforcing new files
-
@infinisil: We can do reformats on both master and the release branch(es) together, this then won’t cause merge conflicts for backports
- Any time after the current release would be fine
- Then to optimise is having the lowest amount of conflicts
- @das_j: I think like that there’s also no problem for the security team
-
@0x4A6F: new files → tools like nix-init should conform to nixfmt-rfc-style?
- @infinisil: Will happen automatically, no need to worry ourselves
- Opened Reformat Nixpkgs · Issue #204 · NixOS/nixfmt · GitHub for the new plan of reformatting all of Nixpkgs