Formatting Team Meeting 2024-06-25

Infinisil · June 26, 2024, 1:43am

Team info
All meeting notes
Attendees: @infinisil Sergey @das_j @0x4A6F

Notes

@infinisil explored and worked on the next steps for reformatting Nixpkgs, which after the meeting got turned into Development shell with a pinned nixfmt by infinisil · Pull Request #322512 · NixOS/nixpkgs · GitHub and

github.com/NixOS/nixpkgs

Enforce nixfmt for new/changed files, treewide reformat pass 1 [skip treewide]

NixOS:master ← tweag:enforce-nixfmt-changed-files

opened 01:22AM - 26 Jun 24 UTC

infinisil

+1251961 -604568

> [!Note] > This PR depends on https://github.com/NixOS/nixpkgs/pull/322512 …## Description of changes This is the next step towards accepted NixOS/rfcs#166 after #322512, see also https://github.com/NixOS/nixpkgs/issues/322520 and https://github.com/NixOS/nixfmt/issues/153 :tada:. The @NixOS/nix-formatting will approve/merge this PR. This PR does two things: - It starts enforcing all new and changed files to be formatted with nixfmt-rfc-style. - It formats all "inactive" files using nixfmt-rfc-style "inactive" means that there are no open PRs with activity in the last month that touch those files. Doing it this way makes ensures that we don't cause any conflicts for recently active PRs that would be ready to merge. Only once those PRs get updated, CI will kick in and require the files to be formatted. A bunch later, we can do another pass to get the rest. ## Things done - [ ] Confirmation that there are no rebuilds (See https://github.com/NixOS/nixpkgs/issues/301014) - [ ] Fix https://github.com/NixOS/nixfmt/issues/197 (cc @dasJ) - [ ] Post on Discourse - [ ] Backport to release and staging branches - This ensures that there aren't any problems when backporting PRs or merging staging --- Add a :+1: [reaction] to [pull requests you find important]. [reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/ [pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc

@das_j explored the codebase to try and fix Formatting unquotes interpolation · Issue #197 · NixOS/nixfmt · GitHub
- We discovered the relevant bits from the Nix lexer here
- These should be relatively directly portable to Haskell (current code around here)
- Sergey recommended this tutorial on Megaparsec by Mark Karpov

If anybody is interested in working on this Haskell codebase, please reach out! We’d appreciate help with any of the issues