Team info
All meeting notes
Attendees: @infinisil @tomberek Sergey @0x4A6F
Notes
-
Maintain expanded attrs/lists/attr params/inherits by infinisil · Pull Request #224 · NixOS/nixfmt · GitHub
- Sergey: Like the change
- @tomberek: Missing symmetrical way of preserving contraction
- @tomberek: Can also be done with a comment
- @tomberek: Opening up a bit of a pandora’s box by taking the input into account
- @tomberek: Overall sounds good to me
- @infinisil: @piegames testing concerns aren’t a blocker, but an experiment is promising
- Let’s wait for @piegames to reply there
-
Enforce nixfmt on new files and changed files that were already formatted by infinisil · Pull Request #326407 · NixOS/nixpkgs · GitHub
- Enforce nixfmt on new files and changed files that were already formatted by infinisil · Pull Request #326407 · NixOS/nixpkgs · GitHub
- Announce it?
- @tomberek: Yeah, large change
-
@tomberek: Could we do it now?
- @infinisil: Why not
- (briefly discussed the impact and how this could fail)
- First draft post, then post, then merge, then monitor
- Auto-merge bot might be affected, shouldn’t be a big problem
- Announced: Enforcing Nix formatting in Nixpkgs
- pre-commit/push hook?
- @0x4A6F: pre-push hooks seems better
- @infinisil: Why? See discussion in Git pre-commit/push hook · Issue #221 · NixOS/nixfmt · GitHub
- @0x4A6F: And this can be added to .git-blame-ignore-revs. Also separating changes from formatting is slightly better.
- @infinisil: Every PR with 2 commits will end up with a third formatting commit that’s hard to integrate into the others and would have to be added to git-blame-ignore-revs, a bit too much imo
- @0x4A6F: If we already have all of Nixpkgs formatted, then pre-commit is also okay, but on the initial rump up it (pre-push) is better
- @infinisil: How about we have both
- @0x4A6F: Yes, and then $user decides
- @infinisil: Automatically install both when entering the nix-shell
- @infinisil: Maybe pre-push could only complain without committing?
- @tomberek: Add automation later, only complain at first
- @0x4A6F: Run the formatting, and ask the user for commit (& ,git-blame-ignore-revs addition)
- @infinisil: (No blocker for Nixpkgs reformat though)