Team info
All meeting notes
Attendees: @infinisil @piegames Sergey @0x4A6F
Notes
- Review Deprecate recursive mode by infinisil · Pull Request #240 · NixOS/nixfmt · GitHub
- Approved and merged
- Review Don't rewrite floats and don't break e+ syntax by infinisil · Pull Request #246 · NixOS/nixfmt · GitHub
- Approved and merged
- Review Always strip trailing space by infinisil · Pull Request #247 · NixOS/nixfmt · GitHub
- Approved and merged
- Review Maintain same ownership when formatting by infinisil · Pull Request #248 · NixOS/nixfmt · GitHub
- Jo: Changing file owner is definitely no good
- pie: Could we truncate instead?
- inf: Yes, but would not be atomic
- pie: Only when user doesn’t match?
- inf: Would require separate code paths, not worth it imo
- Jo: SGTM, can improve it afterwards if there’s problems
- Approved and merged
- reformat Nixpkgs blockers
- Treewide Nix reformat pass 1 [skip treewide]
- Reviewed Don't expand lists within functions by piegamesde · Pull Request #233 · NixOS/nixfmt · GitHub
- infinisil: This still seems like a blocker to me, because these lists won’t get contracted anymore in future reformats
- Let’s focus on that for who has time