Team info
All meeting notes
Attendees: @infinisil @tomberek @brianmcgee @0x4A6F @das_j Sergey @piegames
Notes
- @tomberek: Stepping down from the formatting team, got many other things to do
- others: Thanks for the help! o7
- Prepared a team update for Community Team Updates
- Unblock treewide reformat: Better list argument handling by piegamesde · Pull Request #257 · NixOS/nixfmt · GitHub
- @infinisil added a commit to remove the line length limit
- @pie: Line length limit has a reason, just increasing it to like 6 would be better
- @infinisil: Almost no bad cases in the diff
- @piegames: There’s bad cases, the code path here doesn’t trigger line length limits: 6: Remove single-line list length restriction · infinixbot/nixpkgs@28a037c · GitHub
- @infinisil: 6 seems fine then
- @das_j: Should be fine, if there’s more nested option that’s just how it is
- @infinisil: Also sounds like abusal of the module system namespace
- Merged after CI passed
- Any blockers for the treewide reformat?
- @infinisil: With the above merged, I think this is unblocked
- @piegames: Still think there’s some things that would be nice
- @piegames: Should do a correctness bug triage before treewide reformatting
- @infinisil: Already fixed a bunch of correctness bugs when initially trying the treewide
- @piegames: Time to do the format is before the branch-off → target next branch-off, commit to it, have a lot of time now to prepare
- @infinisil: Timing is not important if we do it on all branches
- @infinisil: Lot of churn right now of people manually formatting, should do it rather soon
- @piegames: Should we do a release?
- @infinisil: Don’t need to
- @das_j: Downgrade of
++ optionalsthing, not a big blocker though - @piegames: People are complaining about things, want to fix some things first
- @infinisil: There’s always going to be people complaining, but many more are complaining about not being able to use a formatter
- @piegames: Some complaints are fair though
- @piegames: Would like to get in Consider not splitting last line of block comment (or make configurable via flag?) · Issue #225 · NixOS/nixfmt · GitHub, relevant behavior creates a bug in the code
- @infinisil/@das_j: Don’t think that’s blocking, but can work orthogonally on it who wants
- @piegames: What about Escape sequences not handled properly · Issue #189 · NixOS/nixfmt · GitHub, correctness bug
- @infinisil: Not a problem for Nixpkgs, and doesn’t change semantics
- Triaged all the issues with priorities, no blockers other than Better list argument handling by piegamesde · Pull Request #257 · NixOS/nixfmt · GitHub
- Treewide reformat: Treewide Nix reformat pass 1 [skip treewide] by infinisil · Pull Request #322537 · NixOS/nixpkgs · GitHub
- @das_j: Some people use nixfmt-classic in update scripts, should address during the reformat
- @infinisil: Can let people update the scripts themselves, will see CI failures
- @0x4A6F: Also should give nix-init a heads-up
- Next steps (@infinisil to lead):
- Announce on Discourse with timeline
- Update
pkgs.nixfmt-rfc-style(and backports) - Once Hydra has built it for nixpkgs-unstable, update
ci/pinned-nixpkgs.json(and backports) - Update Treewide Nix reformat pass 1 [skip treewide] by infinisil · Pull Request #322537 · NixOS/nixpkgs · GitHub
- Remove treewide-nixpkgs-reformat-script/default.nix at df3821ae0ab1203adbd43a533493a7e1c50b9dc7 · infinisil/treewide-nixpkgs-reformat-script · GitHub, use nixfmt from pinned-nixpkgs.json
- Create/update the same for all release branches
- Need to talk to staging folks before to make sure there’s no problems, or fix them when they happen
- Have other formatting team members verify and approve the PRs
- Merge the treewide reformat PRs
- Look into creating something for rebasing Soon™, see git - how to rebase when prettier formatting was applied to whole project - Stack Overflow and Script to rebase with formatting · Issue #159 · NixOS/nixfmt · GitHub
- @das_j: Some people use nixfmt-classic in update scripts, should address during the reformat