`.git-blame-ignore-revs` and build helper format changes

Some changes to build helpers, such as transitioning to lib.extendMkDerivation, changes the indentation of a large block of code, and splitting the reformatting into its own commits helps emphasize the effective changes and make reviewing easier.

Should these reformatting commits be added to .git-blame-ignore-revs to make git blame more informative? If so, should we sort it alphabetically to prevent merge conflicts?

Here are two examples of such transition:

1 Like

“Hide whitespace” should suffice for reviewing IMO?

How amazing! Thank you for sharing with me!

Splitting the reformatting still benefits Git workflows like rebasing and merging during PR reviewing process or during the staging flow.

1 Like

Yes, they should be added. I’m not sure it is worth it to keep the file alphabetically sorted. Very few PRs touch it.

Just glanced through the Nixpkgs Reference Manual. As build helpers are adapting lib.extendMkDerivation, we could expect ~30 new entries from language- and framework-specific build helper transition PRs.

1 Like