GithubPulls plugin for Hydra doesn't pick up github_authorization config section

filalex77 · April 20, 2020, 1:02pm

In services.hydra.extraConfig:

<github_authorization>
  Holo-Host = token MY_HOLO_HOST_TOKEN
</github_authorization>

JSON spec for the project is on GitHub.

The issue is with evaluation of .jobsets, can be observed on our Hydra.

read_file '/var/lib/hydra/github-authorization/' - open: No such file or directory

It’s either not a directory or is a directory error (if I mkdir /var/lib/hydra/github-authorization beforehand).

Should I put anything at this path? I thought having github_authorization section in config is sufficient.

Thanks a lot!

Mic92 · April 21, 2020, 10:27am

This is the source code for context:

github.com

NixOS/hydra/blob/87837f1d82904bf48e11b5641258b6be2f663c3b/src/lib/Hydra/Plugin/GithubPulls.pm#L49

    
      
                  }
              }
              _iterate($next, $auth, $pulls, $ua) unless $next eq "";
          }
          
          
sub fetchInput {
              my ($self, $type, $name, $value, $project, $jobset) = @_;
              return undef if $type ne "githubpulls";
              # TODO Allow filtering of some kind here?
              (my $owner, my $repo) = split ' ', $value;
              my $auth = $self->{config}->{github_authorization}->{$owner};
              my %pulls;
              my $ua = LWP::UserAgent->new();
              _iterate("https://api.github.com/repos/$owner/$repo/pulls?per_page=100", $auth, \%pulls, $ua);
              my $tempdir = File::Temp->newdir("github-pulls" . "XXXXX", TMPDIR => 1);
              my $filename = "$tempdir/github-pulls.json";
              open(my $fh, ">", $filename) or die "Cannot open $filename for writing: $!";
              print $fh encode_json \%pulls;
              close $fh;
              system("jq -S . < $filename > $tempdir/github-pulls-sorted.json");
              my $storePath = trim(`nix-store --add "$tempdir/github-pulls-sorted.json"`

github.com

NixOS/hydra/blob/87837f1d82904bf48e11b5641258b6be2f663c3b/src/lib/Hydra/Plugin/GithubStatus.pm#L77

    
      
          next if exists $seen{$input}->{$key};
          $seen{$input}->{$key} = 1;
          $uri =~ m![:/]([^/]+)/([^/]+?)(?:.git)?$!;
          my $owner = $1;
          my $repo = $2;
          my $url = "https://api.github.com/repos/$owner/$repo/statuses/$rev";
          print STDERR "GithubStatus_Debug POSTing to '", $url, "'\n";
          my $req = HTTP::Request->new('POST', $url);
          $req->header('Content-Type' => 'application/json');
          $req->header('Accept' => 'application/vnd.github.v3+json');
          $req->header('Authorization' => ($self->{config}->{github_authorization}->{$owner} // $conf->{authorization}));
          $req->content($body);
          my $res = $ua->request($req);
          print STDERR $res->status_line, ": ", $res->decoded_content, "\n" unless $res->is_success;
          my $limit = $res->header("X-RateLimit-Limit");
          my $limitRemaining = $res->header("X-RateLimit-Remaining");
          my $limitReset = $res->header("X-RateLimit-Reset");
          my $now = time();
          my $diff = $limitReset - $now;
          my $delay = (($limit - $limitRemaining) / $diff) * 5;
          if ($limitRemaining < 1000) {

filalex77 · May 7, 2020, 11:25am

The issue was a custom patch applied by former developers of holo-nixpkgs. Thanks for the help!