Github's new code owners feature

doronbehar · November 2, 2019, 7:58pm

Could Nixpkgs maybe use this feature in order to help package maintainers maintain their packages more easily?

c0bw3b · November 2, 2019, 8:34pm

We are already using this feature for portions of nixpkgs. It lives here:

NixOS/nixpkgs/blob/a61bd1e42d5512f0e5180edf7ea6090afcd9544b/.github/CODEOWNERS

# CODEOWNERS file
#
# This file is used to describe who owns what in this repository. This file does not
# replace `meta.maintainers` but is instead used for other things than derivations
# and modules, like documentation, package sets, and other assets.
#
# For documentation on this file, see https://help.github.com/articles/about-codeowners/
# Mentioned users will get code review requests.

# This file
/.github/CODEOWNERS @edolstra

# Libraries
/lib                        @edolstra @nbp
/lib/systems                @nbp @ericson2314 @matthewbauer
/lib/generators.nix         @edolstra @nbp @Profpatsch
/lib/debug.nix              @edolstra @nbp @Profpatsch

# Nixpkgs Internals
/default.nix                          @nbp

This file has been truncated. show original

But it wouldn’t be practical to have a CODEOWNERS rule for each default.nix in the tree.

doronbehar · November 2, 2019, 8:47pm

Unless a a bot would have updated this file according to the maintainers list in every package…