GO / NO-GO Meeting: NixOS 20.03 Markhor

Announcements
7

I’ll be there for NixOS modules in general and Haskell infra

5 Likes
8

Thank you guys for doing so much hard work. Stay safe.

9

From my side it’s a GO as soon as we fix evaluation errors.

1 Like
10

I’ll hopefully be there for NixOS Containers, some services with a non-trivial upgrade paths (such as Nextcloud, matrix-synapse etc.) and (if needed) for issues with bigger rebuilds (after helping out during the gcc9 and glibc-2.31 upgrade).

Please attach these proposals to this thread so they can be collected ahead of time for the call

The only thing I came up with is this:

11

I think #82295 should be merged. It is just an addition to release notes, informing people that they won’t get IPv4 addresses on bridges via DHCP on nixos-20.03 anymore.

This almost locked me out of my machine and might break other peoples setup when the release happens.

3 Likes
12

glibc-2.30 libraries link to glibc-2.27 · Issue #84043 · NixOS/nixpkgs · GitHub just popped up (thankfully since I was getting these errors frequently) and I think we should fix it before the release as it breaks in ugly ways and it’s hard to workaround.

2 Likes
13

We’re missing artwork for the news item on the website :frowning:

2 Likes
14

The only serious Plasma issue I know of is:

I would not consider this blocking because there are workarounds.

15

Hello everyone, the meeting will be tomorrow:

2020-04-03T19:00:00Z → 2020-04-03T20:00:00Z

(3PM America/New_York; Every Time Zone: time zone converter, compare time zone difference and find best time for a meeting with one click)

at this meeting URL: Jitsi Meet and in #nixos-dev on IRC.

Make sure you have tickets written down :slight_smile:

7 Likes
16

worldofpeace and disasm decided NO-GO at this time, and to have second review meeting at the same time on Wednesday: 2020-04-08T19:00:00Z → 2020-04-08T20:00:00Z

We’ll use the same video call: Jitsi Meet

Here are the notes from today’s meeting:

present:

  • samueldr
  • “dan” Dandellion
  • aanderse
  • andi
  • worldofpeace
  • chris l-f
  • infinisil
  • doron behar
  • eelco
  • ma27
  • fridh
  • ttuegel
  • lnl
  • drakonis
  • graham
  • flokli
  • disasm
  • unknown

reviewed:

we are blocking on:

needs help with:

6 Likes
17

Forgot about

it’s very important that we merge this at the same time we release updates to the website.

2 Likes
18

I’d also like to mention, since we lack a “NixOS Release Criteria”, if your subsystem wasn’t represented in this meeting and there’s something you’d consider a blocker, now is the time to mention this.

19

Samuel Leathers (@disassembler) and I decided NO-GO today in the meeting.
We’re going to have another review meeting on Friday: 2020-04-10T19:00:00Z → 2020-04-08T20:00:00Z.

Video call link: https://meet.jit.si/GoMarkhorGo

Present representing a subsystem:

  • worldofpeace
  • disasm
  • aanderse
  • ttuegel
  • flokli
  • sphalerite
  • … (sorry)

I wasn’t prepared to take notes, the video will help with who was representing what at the beginning.
It seems also that some people assumed it would be next week Friday, so we had some missing people.

Reviewed
Anything not reviewed this time has been fixed :sparkles:

https://github.com/NixOS/nixpkgs/issues/84409

@mic92 and @flokli have been assigned to fix this.

https://github.com/NixOS/nixpkgs/pull/84221

https://github.com/NixOS/nixpkgs/pull/82295

Me @worldofpeace can review and merge.
If I don’t :wave: I probably need/ed help.

https://github.com/NixOS/nixpkgs/issues/83805

@disassembler and I @worldofpeace would handle for releasing 20.03

https://github.com/NixOS/nixpkgs/issues/79180

I need to finish this. I decided I can draft it in markdown and it will be translated to docbook :heart:

https://github.com/NixOS/nixpkgs/issues/84391

Brought up by @flokli (I believe), we decided it wasn’t a blocker.

https://github.com/NixOS/nixpkgs/issues/61718

I don’t think this was a blocker either, but an errata in the release notes would be great.

Issues with Intel GPU’s in the default kernel 5.4.
(link portal)

I brought it up tangentially, I don’t recall the status of this because I haven’t been able to track kernel development very well. It would be helpful if someone in the know with kernel can followup on it (@vcunat maybe since you did the bump). Last time I checked this was even a problem on one of my laptop’s.

https://github.com/NixOS/nixpkgs/issues/82455

@samueldr wasn’t in the meeting, so I couldn’t followup on it.
We talked in IRC and decided it wasn’t a 20.03 blocker:

Decided Blockers

Link to issues and PRs labeled
https://github.com/NixOS/nixpkgs/issues?q=is%3Aopen+label%3A"1.severity%3A+blocker"+milestone%3A20.03

If there’s anything missed, LMK.
worldofpeace :v:

4 Likes
20

The acme regression will be hopefully addressed here: acme: create certificates in subdirectory by Mic92 · Pull Request #84781 · NixOS/nixpkgs · GitHub

21

I’m no good with kernel internals, especially graphics. I re-checked the tickets open upstream, but I saw no clear indication on which versions they were fixed. Comments from a few weeks ago seemed like 5.4 would still be affected by at least some of these. In theory we could piggyback on some distro’s patches.

22

I thought of similar (I believe ubuntu has patches since they’re going to use the same kernel for their release).

23

:sparkles: :sparkles: :sparkles: :sparkles: :sparkles: :sparkles: :sparkles: :sparkles: :sparkles: :sparkles: :sparkles: :sparkles: :sparkles: :sparkles: :sparkles: :sparkles: :sparkles:

I’ve determined that NixOS 20.03 Markhor is a GO today 2020-04-10.
No further review meetings will be scheduled.
We didn’t have @disassembler in the call, so I will get back to everyone on what sort of timeline we can all expect.

(these notes are thanks to Valodim, thank you so much)

Present in jitsi:

  • worldofpeace

  • aanderse

  • Graham

  • Eelco

  • ma27

  • flokli

  • Emantor

  • two “fellow jitsters”

Quick transcription:

welcome, [quick intro]
ref to previous notes (in this thread)
everything seems to have been completed
milestone: highlights only thing that’s not done
draft went to flokli, he’s working on it

one bug that caught eye: haskell related
not too familiar, anyone in call?
(seems not)

haskell derivation behavior wrt buildDepends changed, will break
Behaviour of .env in regards to buildDepends changed in 20.03 · Issue #84070 · NixOS/nixpkgs · GitHub

so far undocumented

not sure what to do about this bug

graham: opinion: no attention in 9 days, hence not a blocker
maybe contact john ericsson

wop: he self-assigned, documentation seems to be happening?

wop:
no blockers left

20.03 is a go!
highlights and failing packages left to do

samuel (@disassembler) here? see if he agrees

objections from anyone else? (seems not)

looks ok to you eelco?

eelco: sounds great

flokli is going to open pr with highlights translation to docbook
please submit what you need in there, should be done shortly

fabulous :sparkles:

Reviewed

PR has been opened right after as promised

Thank you @flokli.

Followup on the Intel GPU Issue linux 5.4
I talked with Emantor and @samueldr in #nixos-dev about this issue at:
#nixos-dev on 2020-04-10 — irc logs;

We have reason to believe it is actually fixed, and we’ll followup to see if the errata in the release notes can be removed (to use 4.19 to avoid the issue).

20 Likes
24
25

I wrote several issues with ACME certificates (which changed in 20.03 from simp_le to lego), some of which were blocking the release, and I just uncovered a new one which might be blocking too, so I signal it here just in case:

https://github.com/NixOS/nixpkgs/issues/84633#issuecomment-612501828

1 Like
26

I took another look #84070 was as-intended, but I’ll go add some docs as to the change.

edit nixos/doc: Document breaking change to Haskell dev shells by Ericson2314 · Pull Request #85085 · NixOS/nixpkgs · GitHub

2 Likes