Hare build framework decision: Looking for feedback

onemoresuza · March 11, 2024, 1:07am

I’ve created PRs for both buildHarePackage and hare.hook and I’m looking for feedback to know which build framework to be adopted by Hare on nixpkgs.

github.com/NixOS/nixpkgs

buildHarePackage: init

NixOS:master ← onemoresuza:build-hare-program

opened 01:04AM - 11 Mar 24 UTC

onemoresuza

+85 -25

## Description of changes - **buildHarePackage: init function** - **haredo: …make use of buildHarePackage** - **hareThirdParty.hare-toml: make use of buildHarePackage** The `buildHarePackage` gets rid of boilerplate code for Hare packages: 1. No need to set `HARECACHE`; 2. No need to set `PREFIX`; 3. No need to set `-qRa<arch>` hare flags. 4. By setting `-a${stdenv.hostPlatform.uname.processor}`, the derivation needs to do nothing else for the package to cross-compile. It, however, relies on the existence of the `HAREFLAGS` make or environment variable. Thus, if not yet present on the project, the derivation must patch it. This is behavior goes hand in hand with [`Hare`'s project structure](https://harelang.org/documentation/usage/project-structure.html#example-makefile-with-executables) described in its documentation. Do note that `HARECACHE`, `PREFIX` and `HAREFLAGS` are set both as make flags and as environment variables, so that it may be accessed by other build systems, *e. g.*, `haredo`. I've only changed `haredo` and `hareThirdParty.hare-toml` to make use of `buildHarePackage` because I am their maintainer and we have with them both examples of a Hare package: a program, the former, and a library, the latter.  ## Things done - Built on platform(s) - [X] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - For non-Linux: Is sandboxing enabled in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html)) - [ ] `sandbox = relaxed` - [ ] `sandbox = true` - [ ] Tested, as applicable: - [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests) - or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) - made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage) - [ ] Tested basic functionality of all binary files (usually in `./result/bin/`) - [24.05 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2405.section.md) (or backporting [23.05](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2305.section.md) and [23.11](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md) Release notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).  --- Add a :+1: [reaction] to [pull requests you find important]. [reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/ [pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc

github.com/NixOS/nixpkgs

hare.hook: init

NixOS:master ← onemoresuza:hare-hook

opened 11:21PM - 11 Mar 24 UTC

onemoresuza

+53 -17

## Description of changes - **hare.hook: init** - **haredo: make use of hare.ho…ok** - **hareThirdParty.hare-toml: make use of hare.hook** 1. No need to set HARECACHE; 1. `-aRa<arch>` is appended to `HAREFLAGS`; 1. `HARECACHE` and `HAREFLAGS` are appended to `makeFlagsArray`. ### TODO - [ ] Fix cross-compilation The hook does not seem to pass the `buildPlatform` `hare` binary when cross-compiling, but the one from `hostPlatform`.  ## Things done - Built on platform(s) - [X] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - For non-Linux: Is sandboxing enabled in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html)) - [ ] `sandbox = relaxed` - [ ] `sandbox = true` - [ ] Tested, as applicable: - [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests) - or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) - made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage) - [ ] Tested basic functionality of all binary files (usually in `./result/bin/`) - [24.05 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2405.section.md) (or backporting [23.05](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2305.section.md) and [23.11](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md) Release notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).  --- Add a :+1: [reaction] to [pull requests you find important]. [reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/ [pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc