xte
February 12, 2024, 7:43pm
1
Hello Nixers,
I do not know where to post this, I’ve tried Hugo (static website generator) and it install correctly BUT generating a site does not work due to a missing deps: dart-sass-embedded, which is packaged but broken, a quick try
nix-env -iA nixos.dart-sass-embedded
fail the build phase with a build error, paste here Paste2.org - Viewing Paste kfJdZ4XM
Beside this specific case, there is any way to report such stuff (broken packages, missing deps etc) without a GutHub account?
abathur
February 12, 2024, 9:48pm
2
I’d see if dart-sass
itself satisfies this. dart-sass-embedded
was removed after the 23.11 nixos release, and the PR doing so notes:
All existing Dart and Flutter packages build and run, with the exception of dart-sass-embedded
, which was already broken with Dart 3. I’ve removed it in this PR, as it has been discontinued upstream and merged into the regular dart-sass
package.
NixOS:master
← hacker1024:feature/pub2nix
opened 01:49PM - 25 Oct 23 UTC
## Description of changes
This PR removes `fetchDartDeps` in favour of a new … `pub2nix` library. Instead of using Pub to generate a large fixed-output derivation, the `pubspec.lock` file is parsed, and a derivation is made for each individual package.
This improves the user experience significantly:
- Dependency derivations can be shared between applications
- The `vendorHash` is no longer needed (though Git dependencies still do need manual hashes)
- There's no need to work around Pub's difficult Git and package caching behaviour
This PR builds on #262789, so for review, [this comparison between the branches](https://github.com/hacker1024/nixpkgs/compare/feature/flutter-from-source..feature/pub2nix) is appropriate. This can be changed if we decide against #262789, though - nothing relies on it directly.
All existing Dart and Flutter packages build and run, with the exception of `dart-sass-embedded`, which was already broken with Dart 3. I've removed it in this PR, as it has been discontinued upstream and merged into the regular `dart-sass` package.
## Things done
- Built on platform(s)
- [x] x86_64-linux
- [x] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- For non-Linux: Is sandboxing enabled in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html))
- [ ] `sandbox = relaxed`
- [ ] `sandbox = true`
- [ ] Tested, as applicable:
- [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests)
- or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test)
- made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages
- [x] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage)
- [x] Tested basic functionality of all binary files (usually in `./result/bin/`)
- [23.11 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md) (or backporting [23.05 Release notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2305.section.md))
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [ ] (Module updates) Added a release notes entry if the change is significant
- [ ] (Module addition) Added a release notes entry if adding a new NixOS module
- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).
<!--
To help with the large amounts of pull requests, we would appreciate your
reviews of other pull requests, especially simple package updates. Just leave a
comment describing what you have tested in the relevant package/service.
Reviewing helps to reduce the average time-to-merge for everyone.
Thanks a lot if you do!
List of open PRs: https://github.com/NixOS/nixpkgs/pulls
Reviewing guidelines: https://nixos.org/manual/nixpkgs/unstable/#chap-reviewing-contributions
-->
@NixOS/flutter
1 Like
xte
February 13, 2024, 10:54am
4
Effectively it seems to work, thank!
There is still another missed deps in Hugo derivation: nodejs, again adding on the fly just to test nix-env -iA nixos.nodejs_21
(providing npm/npx) fix.