Hydra API Improvements: Ints to Bools?

Development Hydra
1

Hey y’all and specifically @lewo who made hydra-cli,

I’m looking at improving the API to return actual bools where currently it returns a 0/1. This would be a breaking change for users of very strict languages, but I think would be a net improvement. Notably, it makes the API conform to the OpenAPI spec included in the Hydra repo.

Anyone have the opinion that we shouldn’t do this?

Graham

5 Likes
2

The following PR partially implements this: it converts boolean fields that were previously exposed as integers to JSON booleans (but only when hinted by the boolean_columns list in the schema).

https://github.com/NixOS/hydra/pull/933

1 Like
3

@grahamc I’m definitely in favor of such changes. Once merged, I could update hydra-cli to support both APIs.

1 Like
4

@lewo that PR has merged and deployed to hydra.nixos.org :slight_smile: Thanks!