Increase OfBorg timeout

jlesquembre · August 19, 2019, 2:10pm

Is it possible to increase the OfBorg timeout in some cases? Or use a cache? I submitted a PR with a new package: clj-kondo: init at 2019.07.31-alpha by jlesquembre · Pull Request #66344 · NixOS/nixpkgs · GitHub
It depends on graalvm, and looks like OfBorg is building graalvm before building my package. For that reason, I’m getting a time out.

volth · August 19, 2019, 3:36pm

There is meta.timeout for Hydra:

github.com

NixOS/nixpkgs/blob/526a0b227736ce93c5c6ef6cd39836430bdb2992/pkgs/applications/networking/browsers/chromium/browser.nix#L73


      
          
          
  requiredSystemFeatures = [ "big-parallel" ];
          
          
  meta = {
              description = "An open source web browser from Google";
              homepage = http://www.chromium.org/;
              maintainers = with maintainers; [ bendlas ivan ];
              license = licenses.bsd3;
              platforms = platforms.linux;
              hydraPlatforms = if channel == "stable" then ["aarch64-linux" "x86_64-linux"] else [];
              timeout = 172800; # 48 hours
            };
          })

Not sure if ofborg supports it

zimbatm · August 19, 2019, 3:41pm

@jlesquembre if your PR times out the current approach is to target the staging branch and let hydra handle the rebuild.

If you need hardware to test your changes then it’s a separate issue and I am sure we can also help you out.

worldofpeace · August 19, 2019, 3:47pm

@jlesquembre I was planning on building that yesterday, but I was short on time because I wasn’t expecting it would require a lot of time to build

jlesquembre · August 19, 2019, 4:24pm

Thanks for all the answers, learning a lot here
@zimbatm In that case, I’ll update the PR to target the staging branch. Is it necessary to do anything else?
I can test it locally with my laptop, it just takes longer that the default OfBorg timeout. I don’t need extra hardware for it, but thanks for the offer

volth · August 19, 2019, 4:28pm

You can use GraalVM Enterprise (https://github.com/NixOS/nixpkgs/pull/65545), it is just unpack.
Not a solution for ofborg so far it rejects building unfree packages

zimbatm · August 19, 2019, 4:29pm

@jlesquembre if you don’t want to spam a lot of people it’s best to create a new branch, rebase it on staging and open a new PR from that one.

If you have merge rights, feel free to merge once you are confident about the changes (basically that they built and executed locally). Staging gets merged back into master once in a while so it will take time before your changes hit master.

jlesquembre · August 19, 2019, 4:40pm

I don’t have commit rights, but I’m confident about the changes (thanks @volth for your feedback on the PR). The package builds and I was running the binary for a week.
I guess it depends on @worldofpeace, if you can give it a try and merge it, it would be great, but if you prefer I can create a new PR against staging.

worldofpeace · August 20, 2019, 4:37am

It’s not a mass rebuild change, it’s just a package that takes a while to build.
So I don’t think staging is needed, I can give this a try now

Edit: merged

jlesquembre · August 20, 2019, 8:18am

@worldofpeace thanks a lot for trying and merging it. And also thank you for all your work related to nixpkgs. I totally understand that it can take time to get something merged, the number of new PRs is overwhelming, but I regularly see you helping with them

I’m specially happy about this PR because, as far as I know, is the first binary build with graalvm on nixpkgs

worldofpeace · August 20, 2019, 11:36pm

Thanks for mentioning this. I do try my best to assist as much as I can, and it’s great to hear that I was able to help you