Looking for a reviewer that uses hyprland

perchun · April 30, 2025, 11:43am

Hey, I have done a lot of work on downstreaming hyprpanel to nixpkgs, but there wasn’t any activity for half a year on the PR.

I am looking for a nixpkgs reviewer that also uses hyprland and would help me finally merge all the work I have done into nixpkgs. It is not necessary to use hyprpanel, just hyprland

github.com/NixOS/nixpkgs

hyprpanel: init at unstable-2025-02-06

NixOS:master ← PerchunPak:hyprpanel

opened 05:32AM - 07 Feb 25 UTC

PerchunPak

+352 -0

> [!NOTE] > I daily drive everything from this PR and #374302 since 2025 new year, so everything is pretty well tested https://github.com/Jas-SinghFSU/HyprPanel: Bar/Panel for Hyprland with extensive customizability Fixes #350324 Closes https://github.com/Jas-SinghFSU/HyprPanel/issues/371 > [!WARNING] > Tray functionality depends on https://github.com/NixOS/nixpkgs/pull/374302, so don't expect it to work ## Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - For non-Linux: Is sandboxing enabled in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html)) - [ ] `sandbox = relaxed` - [ ] `sandbox = true` - [ ] Tested, as applicable: - [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - and/or [package tests](https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests) - or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) - made sure NixOS tests are [linked](https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#linking-nixos-module-tests-to-a-package) to the relevant packages - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage) - [ ] Tested basic functionality of all binary files (usually in `./result/bin/`) - [25.05 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2505.section.md) (or backporting [24.11](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2411.section.md) and [25.05](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2505.section.md) Release notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).  --- Add a :+1: [reaction] to [pull requests you find important]. [reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/ [pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc

Right now there is that PR, but I also have home-manager module and everything else ready for a review

perchun · April 30, 2025, 11:44am

To note, I daily drive all that code since 2025 new year, so it should be trivial to review, as it is very-well tested

dtomvan · April 30, 2025, 11:27pm

Kind-of crazy how this hasn’t been merged 3 months already. Thank you for pointing this out. I haven’t used hyprland in a while, but I expect nixos to make it a breeze to temporarily switch back over for testing I’ll review it tomorrow.