Mpv-with-scripts has been renamed

Solene · September 26, 2022, 10:04am

Hello,

I got this message after switching to a newer nixpkgs version (79d3ca08920364759c63fd3eb562e99c0c17044a 2022-09-25)

error: 'mpv-with-scripts' has been renamed to/replaced by 'self.wrapMpv'

I’m quite puzzled by this message, should I use wrapMpv instead of mpv-with-scripts? That’s super weird, and I think this kind of message should be improved… Or the new package name changed.

kirillrdy · September 26, 2022, 11:30am

@Solene can you provide steps to reproduce ?

jtojnar · September 26, 2022, 12:12pm

It comes from Prune old aliases by mweinelt · Pull Request #192681 · NixOS/nixpkgs · GitHub. And yeah, it is not a simple replacement so the instructions should include that instead of override, you need to pass the arguments directly.

Solene · September 26, 2022, 12:26pm

here it is with nixpkgs 79d3ca08920364759c63fd3eb562e99c0c17044a

environment.systemPackages = with pkgs; [
  mpv-with-scripts
];

Solene · September 26, 2022, 12:28pm

I don’t really understand how to figure the new value I should use

jtojnar · September 26, 2022, 12:47pm

The old alias was mpv-with-scripts = self.wrapMpv self.mpv-unwrapped { }; So you can just use (wrapMpv mpv-unwrapped { }).

I guess previously it was meant to be used as (mpv-with-scripts.override { scripts = [ … ]; }) but now you are supposed to do (wrapMpv mpv-unwrapped { scripts = [ … ]; }).

But since you do not pass any scripts, you should be able to just use mpv directly:

github.com

NixOS/nixpkgs/blob/df67b7738617ed1ddcfbae879b77d222ee531d89/pkgs/top-level/all-packages.nix#L29898-L29905

    
      
          mpv-unwrapped = callPackage ../applications/video/mpv {
            inherit lua;
            inherit (darwin.apple_sdk.frameworks) CoreFoundation Cocoa CoreAudio MediaPlayer;
          };
          
          
# Wraps without trigerring a rebuild
          wrapMpv = callPackage ../applications/video/mpv/wrapper.nix { };
          mpv = wrapMpv mpv-unwrapped {};

Would be nice if you could correct the error message, if you feel like it:

github.com

NixOS/nixpkgs/blob/2b5856b4e35275abc1e83deed5aa7de4852239ac/pkgs/top-level/aliases.nix#L748

    
      
          multimc = throw "multimc was removed from nixpkgs; use polymc instead (see https://github.com/NixOS/nixpkgs/pull/154051 for more information)"; # Added 2022-01-08
          mumble_git = throw "'mumble_git' has been renamed to/replaced by 'pkgs.mumble'"; # Converted to throw 2022-09-24
          murmur_git = throw "'murmur_git' has been renamed to/replaced by 'pkgs.murmur'"; # Converted to throw 2022-09-24
          mutt-with-sidebar = mutt; # Added 2022-09-17
          mysql-client = throw "'mysql-client' has been renamed to/replaced by 'hiPrio'"; # Converted to throw 2022-09-24
          mysql = throw "'mysql' has been renamed to/replaced by 'mariadb'"; # Converted to throw 2022-09-24
          
          
mesa_drivers = throw "'mesa_drivers' has been renamed to/replaced by 'mesa.drivers'"; # Converted to throw 2022-09-24
          mesa_noglu = throw "'mesa_noglu' has been renamed to/replaced by 'mesa'"; # Converted to throw 2022-02-22
          
          
mpv-with-scripts = throw "'mpv-with-scripts' has been renamed to/replaced by 'self.wrapMpv'"; # Converted to throw 2022-09-24
          mssys = throw "'mssys' has been renamed to/replaced by 'ms-sys'"; # Converted to throw 2022-02-22
          multipath_tools = throw "'multipath_tools' has been renamed to/replaced by 'multipath-tools'"; # Converted to throw 2022-02-22
          mumsi = throw "mumsi has been removed from nixpkgs, as it's unmaintained and does not build anymore"; # Added 2021-11-18
          mupen64plus1_5 = throw "'mupen64plus1_5' has been renamed to/replaced by 'mupen64plus'"; # Converted to throw 2022-02-22
          mx = throw "graalvm8 and its tools were deprecated in favor of graalvm8-ce"; # Added 2021-10-15
          mysqlWorkbench = throw "'mysqlWorkbench' has been renamed to/replaced by 'mysql-workbench'"; # Converted to throw 2022-02-22
          myxer = throw "Myxer has been removed from nixpkgs, as it has been unmaintained since Jul 31, 2021"; # Added 2022-06-08
          
          
### N ###

Solene · September 26, 2022, 1:00pm

I don’t really remember why I needed mpv-with-scripts, I thought it was to have hosting video services support, but it works fine with mpv package.

Thanks for clarification! I’m not sure how to improve the error message though.

jtojnar · September 26, 2022, 1:16pm

Might have been in the past.

Since the old mpv-with-scripts alias was the same as the mpv attribute in all-packages.nix is now, recommending to replace it with mpv will probably be safe.

SuperSamus · September 26, 2022, 3:16pm

I guess that MPV - NixOS Wiki should be edited.