nativeCheckInputs doesn't work when working outside of Nixpkgs?

doronbehar · March 16, 2023, 5:07pm

I’m experiencing a most peculiar issue when trying to add a flake.nix to a Python package:

I mostly copied Nixpkgs’ default.nix to a file I called ./pkg.nix in the package’s repository. Now I use in flake.nix:

packages = {
  scipy = pkgs.python3.pkgs.callPackage ./pkg.nix args;
};

In pkg.nix I have:

nativeCheckInputs = [ nose pytest pytest-xdist ];

As in Nixpkgs, and from some reason, e.g pytest is not available for the builder’s python. Nixpkgs’ build succeeds, so I conclude that no such issue is present there. The full Nix code is here:

github.com

doronbehar/scipy/blob/9e35a634f2ea45c2adf4ea14cc149b602471e96c/flake.nix#L64

    
      
              pkgs.python3.pkgs.pytest
              pkgs.python3.pkgs.pytest-xdist
              pkgs.python3.pkgs.pooch
            ];
          in {
            devShells = {
              default = pkgs.mkShell {
                inherit nativeBuildInputs buildInputs propagatedBuildInputs checkInputs;
              };
            };
            packages = {
              # Build with:
              #
              #     nix build -L .?submodules=1\#scipy
              scipy = pkgs.python3.pkgs.callPackage ./pkg.nix (sharedBuildArgs // {
              });
              # Build with:
              #
              #     nix build -L .?submodules=1\#scipy-armv7l-hf-multiplatform
              scipy-armv7l-hf-multiplatform = pkgs.pkgsCross.armv7l-hf-multiplatform.python3.pkgs.callPackage ./pkg.nix (sharedBuildArgs // {
              });

And here:

github.com

doronbehar/scipy/blob/9e35a634f2ea45c2adf4ea14cc149b602471e96c/pkg.nix#L110

    
      
          buildInputs = [
            numpy.blas
            pybind11
            pooch
          ] ++ lib.optionals (pythonOlder "3.9") [
            libxcrypt
          ];
          
          
propagatedBuildInputs = [ numpy ];
          
          
# TODO: From some reason nativeCheckInputs doesn't work, see the sanity check
          # at preConfigure. See also
          # https://github.com/NixOS/nixpkgs/pull/206742/commits/f39abbc3500451fc00c80fed71b0f6f7bba8b6a4
          checkInputs = [ nose pytest pytest-xdist ];
          
          
doCheck = !(stdenv.isx86_64 && stdenv.isDarwin);
          
          
preConfigure = ''
            sed -i '0,/from numpy.distutils.core/s//import setuptools;from numpy.distutils.core/' setup.py
            export NPY_NUM_BUILD_JOBS=$NIX_BUILD_CORES
          ''

Help will be appreciated!

Sandro · March 16, 2023, 8:25pm

You are checking for pytest in configurePhase but since it is in checkInputs it will only be available in the checkPhase because strictDeps for all python building functions is enabled.

vcunat · March 17, 2023, 6:57am

Your flake is locked to a commit before nativeCheckInputs existed. (named just checkInputs at that point) Such renames are hard to deal with, unfortunately.

doronbehar · March 17, 2023, 9:26am

Thanks! This was it.