Attendees: @Lassulus @wolfgangwalther @philiptaron @MattSturgeon @Scriptkiddi @DominicWrege
Agenda and notes
This first meeting of the CI team was a little ad-hoc: planned as a nixpkgs-merge-bot meeting, almost didn’t happen, then became a nixpkgs-ci meeting. For posterity, we’ve attempted to record what was discussed below:
Official nixpkgs-ci matrix channel
The existing nixpkgs-merge-bot matrix channel has been repurposed and renamed to be the official nixpkgs-ci matrix channel (#nixpkgs-ci:nixos.org, invite). This channel can be used for ad-hoc technical discussions within the team and for others to have discussions with the team.
This matrix channel should be documented somewhere publicly, e.g. ci/README, nixos.org/community “Teams” section, @NixOS/nixpkgs-ci page, etc.
Restoring commit access for previous nixpkgs-merge-bot members
The repo owner was recently changed from nixpkgs-merge-bot to nixpkgs-ci in https://github.com/NixOS/nixpkgs-merge-bot/issues/207, to reflect the merge bot being critical to nixpkgs’ CI.
This meant two historic committers @Scriptkiddi and @DominicWrege lost their write access to the nixpkgs-merge-bot repo. Both @DominicWrege and @Scriptkiddi have expressed interest in regaining write access.
Ordinarily we could simply add them as repo collaborators or to the nixpkgs-ci team, however because this repo has an automatic deployment on push, this could effectively give an indirect write access to nixpkgs. There is concern that this would be overstepping our authority and bypassing the nixpkgs commit-bit-delegation team.
@philiptaron will reach out to the commit-bit-delegation team and discuss whether they are comfortable with these contributors regaining write access to the merge bot without a nixpkgs commit bit; if not, we will consider nominating them for commit bit.
Opened https://github.com/NixOS/org/issues/166
CI team to take ownership of nixpkgs-vet
@piliptaron highlighted that nixpkgs-vet is a core part of Nixpkgs’ CI and should be owned by the CI team. While the CI team is hesitant to take on any extra responsibility, we all acknowledge that we already rely on the project and ought to have ownership over it.
Opened https://github.com/NixOS/org/issues/164
Document the process for
@MattSturgeon will submit a PR to document which changes would require approval or acknowledgement from a “higher authority”, in the merge-bot repo’s README:
Increases in scope for (e.g.) merge strategies
Increasing the scope of what can be merged or by whom must be approved by a “higher entity” such as:
- The commit-bit-delegation team
- The Steering Committee
Note: being pinged and not responding within a week is considered a silent acknowledgmentOther changes that do not increase who can merge things into nixpkgs can be approved internally between the nixpkgs-ci team and repo collaborators.
Opened https://github.com/NixOS/nixpkgs-merge-bot/pull/227
Regular CI meetings
We will discuss after the meeting how to schedule future meetings.
The initial proposal is:
- Monthly (adjust as needed)
- Public (should be listed on the official NixOS calendar,
ci/README, etc) - Open (anyone can join)
- Minuted:
- Someone should be nominated at the start of each meeting to take notes
- Notes should be semi-collaborative during meetings, e.g. using hedgedoc
- Notes should be published after the meeting, e.g. on discourse or github
