Nrfconnect package wrongly removed?

alexxedo · September 20, 2023, 9:56pm

Hello

It seems that nrfconnect (and nrf-command-line-tools) package that was present in stable has been removed by this commit Revert "nrfconnect: init at 3.11.1" · NixOS/nixpkgs@5f9b7b3 · GitHub
which is a revert of the init of the package.

Does anyone know why exactly? I can’t found the PR or reference why it was done.

Lyndeno · September 20, 2023, 10:02pm

github.com/NixOS/nixpkgs

segger-jlink: init at 794a, nrfconnect: init at 4.3.0, nrf-command-line-tools: init at 10.23.2

NixOS:master ← StarGate01:nrfconnect

opened 09:43PM - 14 Sep 23 UTC

StarGate01

+348 -0

## Description of changes This PR re-adds some packages which were purged due… to their usage of QT4 in #174634 : `segger-jlink`, and two packages which depend on it: `nrfconnect` and `nrf-command-line-tools`. Unfortunately the SEGGER J-Link tools are only distributed in binary form and have a hard requirement on (the bundled) QT4. I have packaged the bundled QT4 libs as a secondary package to not pollute the global namespace. Supersedes #252137, #244637, #263487 ## Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html)) - [ ] Tested, as applicable: - [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests) - or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) - made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages - [x] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage) - [x] Tested basic functionality of all binary files (usually in `./result/bin/`) - [23.11 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md) (or backporting [23.05 Release notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2305.section.md)) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

Seems it was removed because it used qt4. This PR re-adds it

alexxedo · September 20, 2023, 10:07pm

Thanks for the answer!