PR waiting to be merged for >3 months

Development
1

My PR #310631 has been approved and waiting to be merged for >3 months. I don’t mind waiting, but this is my first time contributing to NixOS, so I’m worried I’ve missed something I needed to take care of, which is causing a delay. Thanks!

2 Likes
2

This sometimes happens, because the number of active maintainers with merge permissions is actually not that large, and people are sometimes unavailable or lose track of things due to the sheer amount of activity.

Your PR looks good, please rebase it so the intermediate merge commit disappears and I can hit the button (I’m not sure if making a rebase-merge in the GitHub UI will do the right thing and don’t want to pollute history).

Thanks for your perseverance!

5 Likes
3

Thanks for merging the PR! :smiley: