palo
March 11, 2020, 6:09am
113
This pull request is reviewd for quite some time.https://github.com/NixOS/nixpkgs/pull/72160
FelschR
March 14, 2020, 11:39am
115
This has been open a while but I feel it is trivial:
NixOS:master ← alexarice:variant-ant-themes
opened 08:31AM - 28 Aug 19 UTC
###### Things done
- [x] Tested using sandboxing ([nix.useSandbox](http://ni… xos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
- Built on platform(s)
- [x] NixOS
- [ ] macOS
- [ ] other Linux distributions
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
- [x] Tested execution of all binary files (usually in `./result/bin/`)
- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
- [ ] Ensured that relevant documentation is up to date
- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).
###### Notify maintainers
cc
Enteee
March 19, 2020, 6:31pm
119
I added some comments, which the author addressed. Looks good to go!
I cross checked debian and arch, should be good to merge:
NixOS:staging ← primeos:tcp-cong-switch-to-cubic
opened 10:00AM - 02 Mar 20 UTC
This will switch the default TCP congestion control algorithm from
new Reno to … CUBIC. CUBIC is the default since Linux kernel 2.6.19
(see 597811ec167fa) and most (all?) distributions keep this default
(e.g. Debian and Ubuntu). On NixOS the default was still new Reno
because generate-config.pl changes TCP_CONG_CUBIC from y to m (since we
try to build everything as a module by default).
To check the active and available algorithms:
$ sysctl net.ipv4.tcp_congestion_control
net.ipv4.tcp_congestion_control = cubic
$ sysctl net.ipv4.tcp_available_congestion_control
net.ipv4.tcp_available_congestion_control = cubic reno
Note: E.g. x86_64_defconfig sets TCP_CONG_CUBIC=y indirectly via
CONFIG_TCP_CONG_ADVANCED=y (but CUBIC is also the default if set to no,
see net/ipv4/Kconfig).
```
Edit: Some existing diffs (old NixOS kernel configuration vs. other distributions):
- Ubuntu: https://github.com/NixOS/nixpkgs/issues/58275#issuecomment-477203331
- Arch: https://github.com/NixOS/nixpkgs/issues/39225#issuecomment-385281048
```
###### Motivation for this change
###### Things done
- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS linux)
- Built on platform(s)
- [ ] NixOS
- [ ] macOS
- [ ] other Linux distributions
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"`
- [ ] Tested execution of all binary files (usually in `./result/bin/`)
- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
- [ ] Ensured that relevant documentation is up to date
- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).
Close:
NixOS:master ← oxij:nixos/doc-generate-config
opened 01:44AM - 04 Mar 18 UTC
###### Motivation for this change
Combination of https://github.com/NixOS/nix… pkgs/issues/17126#issuecomment-315190218 and https://github.com/NixOS/nixpkgs/pull/35292#issuecomment-367714173 got me over the edge.
###### Things done
- [X] It evaluates.
Feel free to point to typos I probably missed.
Reason: it’s a good attempt at making better documentation. But some of the documentation is controversial, and the author does not seem interested in pursuing this PR any longer. And it’s been about 18 months since he last commented on it.
First time committer and inexperienced reviewer, 2nd glance would be appreciated
NixOS:master ← shnarazk:cadical-pr
opened 04:14PM - 23 Mar 20 UTC
###### Motivation for this change
[CaDiCaL](https://github.com/arminbiere/cadic… al) is one of the best and art-of-the-state SAT solvers. It got a very good result in the [SAT Race 2019](http://sat-race-2019.ciirc.cvut.cz/index.php?cat=results), comparing with /pkgs/applications/science/logic/{minisat, cryptominisat, glucose}. So I think it's worth adding to nix packages.
###### Things done
- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS linux)
- Built on platform(s)
- [ ] NixOS
- [x] macOS
- [x] other Linux distributions
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"`
- [x] Tested execution of all binary files (usually in `./result/bin/`)
- [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
- [x] Ensured that relevant documentation is up to date
- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).
