Hi, I’ve got a merge request that fixes clangd when ran with --query-driver - it’s been waiting since Nov 2024 and it’s confirmed to work, could someone take a look? Thanks
staging ← Patryk27:improve-clang-tools
opened 12:30PM - 09 Nov 24 UTC
clang-tools invokes clangd through a wrapper script whose sole purpose is to ext… end `CPATH` and `CPLUS_INCLUDE_PATH` envs, so that clangd is later able to find built-in and stdlib headers.
This script does two things wrong:
1. We extend `CPATH` et al with entries from both `@clang@/nix-support/libc-cflags` and `@clang@/resource-root/include`, which is kind of a self-made problem, since clangd already has some header auto-detection logic which we (used to) circumvent (for more details, see the diff).
2. We extend `CPATH` et al unconditionally, breaking the `--query-driver` option. I'm not sure what's the perfect solution here, but skipping this logic when we detect `--query-driver` should be good enough. I mean, ideally we wouldn't be playing with `CPATH` etc. whatsoever, but well.
Closes https://github.com/NixOS/nixpkgs/issues/351962
Closes https://github.com/NixOS/nixpkgs/issues/348791
Closes https://github.com/NixOS/nixpkgs/issues/345704
## Things done
- Built on platform(s)
- [x] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- For non-Linux: Is sandboxing enabled in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html))
- [ ] `sandbox = relaxed`
- [ ] `sandbox = true`
- [x] Tested, as applicable:
- [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- and/or [package tests](https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests)
- or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test)
- made sure NixOS tests are [linked](https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#linking-nixos-module-tests-to-a-package) to the relevant packages
- [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage)
- [x] Tested basic functionality of all binary files (usually in `./result/bin/`)
- [24.11 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2411.section.md) (or backporting [23.11](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md) and [24.05](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2405.section.md) Release notes)
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [ ] (Module updates) Added a release notes entry if the change is significant
- [ ] (Module addition) Added a release notes entry if adding a new NixOS module
- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).
---
Add a :+1: [reaction] to [pull requests you find important].
[reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/
[pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc
Hello this PR adding nohang (prevents system freezes on low memory) that’s like 95% done but stalled since June 2025. Seems to have merge conflicts and the original author is inactive. Can someone with experience adopt this and push it across the finish line? I really do not know how to package stuff
master ← Dev380:nohang
opened 01:44AM - 21 May 25 UTC
Nohang is an out of memory process killer for Linux as an alternative to the def… ault kernel OOM killer. The github page is here: https://github.com/hakavlad/nohang. This package has been requested before in #144819
Closes #144819
## Things done
It should build everywhere because there's no build phase (just copying some python files to $out/bin) but I've only tested it on my machine.
- Built on platform(s)
- [x] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- [x] Tested, as applicable:
- [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- and/or [package tests](https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests)
- or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test)
- made sure NixOS tests are [linked](https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#linking-nixos-module-tests-to-a-package) to the relevant packages
- [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage)
- [ ] Tested basic functionality of all binary files (usually in `./result/bin/`)
- [Nixpkgs 25.11 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/doc/release-notes/rl-2511.section.md) (or backporting [24.11](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/release-notes/rl-2411.section.md) and [25.05](https://github.com/NixOS/nixpkgs/blob/master/doc/manual/release-notes/rl-2505.section.md) Nixpkgs Release notes)
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [NixOS 25.11 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2511.section.md) (or backporting [24.11](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2411.section.md) and [25.05](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2505.section.md) NixOS Release notes)
- [ ] (Module updates) Added a release notes entry if the change is significant
- [x] (Module addition) Added a release notes entry if adding a new NixOS module
- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).
---
Add a :+1: [reaction] to [pull requests you find important].
[reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/
[pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc
This PR is close to be in a “mergeable” state, but requires some help on python wrapping and other issue mentioned in the comment linked :
> I'm not sure what's at fault but I suspect it's the python wrapper. If anyone … has more experience with python/wrapping/polkit auth, I could use some help.
~~The short answer is `lib/howdy-gtk/init.py` doesn't have executable bit 😅~~
~~Wait, it's not~~
Okay, it is but we still have more problems.
https://github.com/boltgolt/howdy/blob/master/howdy-gtk/src/window.py#L121
https://github.com/barneygale/elevate/blob/master/elevate/posix.py#L51
It is just using pkexec to re-execute current argv0. And it's only passing down arguments, not environment variables 🥶
dwt
January 11, 2026, 2:02pm
127
I would like to simplify allowing unfree packages via a config that is merged like most configuration values. I do have an implementation and unit tests for it, but it is quite stuck for lack of review.
master ← dwt:nixpkgs-config-allowUnfreePackages
opened 04:39PM - 06 Apr 25 UTC
Inspired by https://github.com/NixOS/nixpkgs/issues/197325 this adds a new optio… n nixpkgs.allowUnfreePackages, which merges additively and can thus be defined in multiple modules close to where the unfree package is installed.
I would have liked ot name this option
`nixpkgs.config.allowUnfreePackages`, to define it closer to where the `allowUnfree` and `allowUnfreePredicate` options are defined, but I didn't see how this could be achived, given that `nixpkgs.config` is an attribute set or function instead of a module. I would welcome some guidance on how to do this.
I would also have liked to have an assertion that this setting should not be defined when `nixpkgs.config.allowUnfreePredicate or `nixpkgs.config.allowUnfree` is set, but I don't yet know how to do that. (And I would like to learn).
Closes #197325
## Things done
- Built on platform(s)
- [ ] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [x] aarch64-darwin
- For non-Linux: Is sandboxing enabled in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html))
- [ ] `sandbox = relaxed`
- [ ] `sandbox = true`
- [x] Tested, as applicable:
- [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- and/or [package tests](https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests)
- or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test)
- made sure NixOS tests are [linked](https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#linking-nixos-module-tests-to-a-package) to the relevant packages
- [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage)
- [ ] Tested basic functionality of all binary files (usually in `./result/bin/`)
- [25.05 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2505.section.md) (or backporting [24.11](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2411.section.md) and [25.05](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2505.section.md) Release notes)
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [ ] (Module updates) Added a release notes entry if the change is significant
- [ ] (Module addition) Added a release notes entry if adding a new NixOS module
- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).
---
Add a :+1: [reaction] to [pull requests you find important].
[reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/
[pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc
2 Likes
(Hope nixos-hardware PRs are allowed!) There’s a bit of a backlog on PRs for nixos-hardware. Some of them (like the one linked) are necessary for folks to rebuild their systems on 25.11. I don’t want to put extra pressure on the maintainers, and would love to help out with reviews if possible. I just want to make sure these are at least being seen.
master ← 8bitbuddhist:surface-rust-target-spec-fix
opened 06:12PM - 29 Nov 25 UTC
###### Description of changes
Adds a patch for older kernel versions so they … can build using Rust 1.91, which is used in NixOS 25.11. This fixes a build error and #1685.
Update: Due to a cryptic build error, Rust is disabled for the 6.12 (`longterm`) kernel. It can be re-enabled for the next LTS kernel (6.18).
###### Things done
- [X] Tested the changes in your own NixOS Configuration
- [X] Tested the changes end-to-end by using your fork of `nixos-hardware` and
importing it via `<nixos-hardware>` or Flake input
2 Likes
twoolie
February 13, 2026, 2:20am
129
This PR fixes a regression in building nv-fabricmanager in nvidia datacenter drivers, and needs review/backport tags added.
master ← ItsAzM8:fix-nv-fabricmanager-build-phases
opened 06:25AM - 07 Feb 26 UTC
Ran into this issue when trying to move over to NixOS 25.11 from 25.05 while usi… ng [hardware.nvidia.datacenter.enable](https://search.nixos.org/options?channel=unstable&query=datacenter).
Seems that something going on in one of the build phases is causing the following to happen when the `nv-fabricmanager` binary is called: [nv-fabricmanager.log](https://github.com/user-attachments/files/25142867/nv-fabricmanager.log).
The exact same output is logged when running checking the nv-fabricmanager binary with ldd. There is a part of the installPhase that checks the binaries with ldd, but it just checks `grep -vqz "not found"`, which doesn't appear in the above. This means the derivation still gets evaluated successfully, but the built binary is in a broken state.
## Things done
* Revert build phases back to how they were in NixOS 25.05.
* Enabled the `installCheckPhase`. This solves the issue without change as it runs the binary and checks to see if the version gets logged.
* Enabled the checkPhase and pulled the ldd check from the installPhase into the checkPhase. Makes more sense to be in the checkPhase imo.
- Built on platform:
- [x] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- Tested, as applicable:
- [ ] [NixOS tests] in [nixos/tests].
- [ ] [Package tests] at `passthru.tests`.
- [ ] Tests in [lib/tests] or [pkgs/test] for functions and "core" functionality.
- [ ] Ran `nixpkgs-review` on this PR. See [nixpkgs-review usage].
- [x] Tested basic functionality of all binary files, usually in `./result/bin/`.
- Nixpkgs Release Notes
- [ ] Package update: when the change is major or breaking.
- NixOS Release Notes
- [ ] Module addition: when adding a new NixOS module.
- [ ] Module update: when the change is significant.
- [x] Fits [CONTRIBUTING.md], [pkgs/README.md], [maintainers/README.md] and other READMEs.
[NixOS tests]: https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests
[Package tests]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests
[nixpkgs-review usage]: https://github.com/Mic92/nixpkgs-review#usage
[CONTRIBUTING.md]: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md
[lib/tests]: https://github.com/NixOS/nixpkgs/blob/master/lib/tests
[maintainers/README.md]: https://github.com/NixOS/nixpkgs/blob/master/maintainers/README.md
[nixos/tests]: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests
[pkgs/README.md]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md
[pkgs/test]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/test
Can someone please take a look? It’s been stuck for a long time and the module is currently unusable without the fix.
https://github.com/NixOS/nixpkgs/pull/478425
1 Like
master ← kilyanni:package/intel-llvm
opened 01:45AM - 12 Dec 25 UTC
Adds the Intel LLVM fork for SYCL compilation. This PR includes the compiler as … well as an `stdenv` for making nix-derivations that use it.
Some notes:
- Upstreaming the `gnu-install-dirs.patch` patch wont make much sense until the [equivalent vanilla-LLVM patches](https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/compilers/llvm/22/llvm/gnu-install-dirs.patch) are upstreamed (and reach the Intel Fork). The `sycl-jit-exclude-cmake-files.patch` only makes sense with the GNU one already applied, so that neither.
- This is packaged at an unstable commit instead of the last release, because several packaging-related changes are not yet in the release version. Most notably the dependency lookup changes from intel/llvm/issues/19635
- I've successfully used the stdenv to build large SYCL codebases, such as `oneDNN`. As far as I can tell, everything seems to work as intended.
Closes #245031
Related to #367722
## Things done
- Built on platform:
- [x] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- Tested, as applicable:
- [ ] [NixOS tests] in [nixos/tests].
- [ ] [Package tests] at `passthru.tests`.
- [ ] Tests in [lib/tests] or [pkgs/test] for functions and "core" functionality.
- [ ] Ran `nixpkgs-review` on this PR. See [nixpkgs-review usage].
- [x] Tested basic functionality of all binary files, usually in `./result/bin/`.
- Nixpkgs Release Notes
- [ ] Package update: when the change is major or breaking.
- NixOS Release Notes
- [ ] Module addition: when adding a new NixOS module.
- [ ] Module update: when the change is significant.
- [x] Fits [CONTRIBUTING.md], [pkgs/README.md], [maintainers/README.md] and other READMEs.
[NixOS tests]: https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests
[Package tests]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests
[nixpkgs-review usage]: https://github.com/Mic92/nixpkgs-review#usage
[CONTRIBUTING.md]: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md
[lib/tests]: https://github.com/NixOS/nixpkgs/blob/master/lib/tests
[maintainers/README.md]: https://github.com/NixOS/nixpkgs/blob/master/maintainers/README.md
[nixos/tests]: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests
[pkgs/README.md]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md
[pkgs/test]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/test
---
Add a :+1: [reaction] to [pull requests you find important].
[reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/
[pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc
Adds the Intel LLVM fork for SYCL compilation. Has 2 approvals but blocked on a changes-requested review that’s been unresponsive for over a month. I attempted the requested changes (split build), wrote up why it’s not viable right now, and followed up twice with no reply. Would appreciate another committer weighing in.
1 Like
smorin
June 11, 2026, 4:59pm
132
Have a PR for a package it’s been waiting for a few weeks. I was reading through the contributors’ documentation, and it seemed to point here, just trying to follow the community conventions.
Would someone be able to help look at this PR, it merges, and I try to follow all conventions, reading through, contributing.
master ← smorin:togl-init
opened 10:18PM - 30 May 26 UTC
## Description of changes
Adds two new packages:
- **`togl`** — a CLI for togg… ling code comments (commenting/uncommenting line ranges and named marker sections) across many languages. Installs the `toggle` and `togl` binaries (same behaviour under either name).
- **`libtogl`** — the project's ABI-stable C library exposing the same engine over a C FFI, with a multi-output layout (`out` = shared library; `dev` = static library + `togl.h` header + `pkg-config` file).
Upstream: https://github.com/smorin/toggle (v0.5.0). License: MIT. Both packages are maintained by `smorin` (already in the maintainer list).
The two packages share the same source and `cargoHash` (single virtual Cargo workspace); `togl` builds `-p togl-cli` and `libtogl` builds `-p togl-ffi`.
## Things done
- Built on platform(s)
- [x] aarch64-darwin
- [ ] x86_64-darwin
- [ ] aarch64-linux
- [ ] x86_64-linux
- [x] For non-Linux: Is `sandbox = true` set in `nix.conf`? (yes)
- [x] Ran `nixpkgs-review` — merges cleanly on current `master`; impacted packages are exactly `togl` and `libtogl`; all outputs (`togl`, `libtogl`, `libtogl.dev`) build
- [x] Tested execution of all binary files: `togl --version` → `togl 0.5.0`; subcommands present in `--help`
- [x] `libtogl` verified: shared lib in `$out/lib`, static lib + `togl.h` + `togl.pc` (`Version: 0.5.0`) in `$dev`
- [x] Formatted with `nixfmt-rfc-style`
- [x] Meta set (`description`, `homepage`, `changelog`, `license`, `maintainers`, `mainProgram` / `pkgConfigModules`, `platforms`)
- [x] Fits the guidelines in [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md) and the [Nixpkgs manual](https://nixos.org/manual/nixpkgs/unstable/).
---
Add a :+1: [reaction] to [pull requests you find important].
[reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/
[pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc
master ← Eveeifyeve:nim-refractor-1
opened 06:24PM - 05 Mar 26 UTC
**Why do a huge refractor?** With the upcoming nim changes (eg. new versions) it… 's time that nixpkgs had a huge refractor of packages/attention to keep up so this pr deprecates nim1 and nim2 (with respective unwrap) packages with [the upgrade nim to 2.2.10](https://nim-lang.org/blog/2026/04/24/nim-2210.html) and making nim use a boostrapped compiler. This [fixes the nim-unwrapped pname issue](https://github.com/NixOS/nixpkgs/issues/485742) with using name instead of pname.
There was a [old previous pr here](https://github.com/NixOS/nixpkgs/pull/461756), however I accidentally was on the wrong branch working on the nim builder refractor as this pr is already big enough, I wanted the version change/stdenv move in this pr and did a push that deleted the changes accidentally, so I remade this pr. 😆
## Things done
- Built on platform:
- [x] x86_64-linux
- [x] aarch64-linux
- [x] x86_64-darwin
- [x] aarch64-darwin
- Tested, as applicable:
- [ ] [NixOS tests] in [nixos/tests].
- [ ] [Package tests] at `passthru.tests`.
- [ ] Tests in [lib/tests] or [pkgs/test] for functions and "core" functionality.
- [x] Ran `nixpkgs-review` on this PR. See [nixpkgs-review usage].
- [x] Tested basic functionality of all binary files, usually in `./result/bin/`.
- Nixpkgs Release Notes
- [x] Package update: when the change is major or breaking.
- NixOS Release Notes
- [ ] Module addition: when adding a new NixOS module.
- [ ] Module update: when the change is significant.
- [x] Fits [CONTRIBUTING.md], [pkgs/README.md], [maintainers/README.md] and other READMEs.
[NixOS tests]: https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests
[Package tests]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests
[nixpkgs-review usage]: https://github.com/Mic92/nixpkgs-review#usage
[CONTRIBUTING.md]: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md
[lib/tests]: https://github.com/NixOS/nixpkgs/blob/master/lib/tests
[maintainers/README.md]: https://github.com/NixOS/nixpkgs/blob/master/maintainers/README.md
[nixos/tests]: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests
[pkgs/README.md]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md
[pkgs/test]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/test
It’s has been waiting for a few weeks to months pinging/bumping the review channels. I will admit there has been delays such as breaking changes restriction from 26.05, but this has been ready for about a month and Ideally it would be great to merge this sometime before November for 26.11 release, so that way we can deprecate nim 1 fully and use newer version of nim that is bootstrapped.
I would appreciative if any committers time and energy if they could take a look and merge this in, as this has already two approvals (including another Nim team member).
Merged! Thanks Doron, I appreciate you merging this pr.
(solved, thank you doronbehar)
1 Like
brudel
July 13, 2026, 8:36pm
135
Hey, I made a small PR that simply fixes a missing icon by linking the icon images to the proper place:
master ← brudel:patch-1
opened 09:12PM - 17 Mar 26 UTC
- Symlinked the `hubstaff-color.png` files directly into `$out/share/icons/hicol… or/` for all provided resolutions, so desktop environments can properly locate the application icon.
- Updated the `icon` attribute in `makeDesktopItem` from `hubstaff` to `hubstaff-color` to accurately match the filenames provided in the package.
Tested successfully for NixOS stable Cinnamon
## Things done
- Built on platform:
- [x] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- Tested, as applicable:
- [ ] [NixOS tests] in [nixos/tests].
- [ ] [Package tests] at `passthru.tests`.
- [ ] Tests in [lib/tests] or [pkgs/test] for functions and "core" functionality.
- [ ] Ran `nixpkgs-review` on this PR. See [nixpkgs-review usage].
- [ ] Tested basic functionality of all binary files, usually in `./result/bin/`.
- Nixpkgs Release Notes
- [ ] Package update: when the change is major or breaking.
- NixOS Release Notes
- [ ] Module addition: when adding a new NixOS module.
- [ ] Module update: when the change is significant.
- [x] Fits [CONTRIBUTING.md], [pkgs/README.md], [maintainers/README.md] and other READMEs.
[NixOS tests]: https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests
[Package tests]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests
[nixpkgs-review usage]: https://github.com/Mic92/nixpkgs-review#usage
[CONTRIBUTING.md]: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md
[lib/tests]: https://github.com/NixOS/nixpkgs/blob/master/lib/tests
[maintainers/README.md]: https://github.com/NixOS/nixpkgs/blob/master/maintainers/README.md
[nixos/tests]: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests
[pkgs/README.md]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md
[pkgs/test]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/test
cc @michalrus
Needs input / testing from a Darwin user:
staging ← SFrijters:shiboken6-generator-strictdeps
opened 10:39AM - 31 May 26 UTC
I think additional changes for darwin (moving `python.pkgs.qt6.darwinVersionInpu… ts`) may be necessary, but I can't test it.
## Things done
- Built on platform:
- [x] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- Tested, as applicable:
- [ ] [NixOS tests] in [nixos/tests].
- [ ] [Package tests] at `passthru.tests`.
- [ ] Tests in [lib/tests] or [pkgs/test] for functions and "core" functionality.
- [ ] Ran `nixpkgs-review` on this PR. See [nixpkgs-review usage].
- [ ] Tested basic functionality of all binary files, usually in `./result/bin/`.
- Nixpkgs Release Notes
- [ ] Package update: when the change is major or breaking.
- NixOS Release Notes
- [ ] Module addition: when adding a new NixOS module.
- [ ] Module update: when the change is significant.
- [ ] Fits [CONTRIBUTING.md], [pkgs/README.md], [maintainers/README.md] and other READMEs.
- [x] Follows the [automation/AI policy].
[NixOS tests]: https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests
[Package tests]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests
[nixpkgs-review usage]: https://github.com/Mic92/nixpkgs-review#usage
[CONTRIBUTING.md]: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md
[automation/AI policy]: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#automationai-policy
[lib/tests]: https://github.com/NixOS/nixpkgs/blob/master/lib/tests
[maintainers/README.md]: https://github.com/NixOS/nixpkgs/blob/master/maintainers/README.md
[nixos/tests]: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests
[pkgs/README.md]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md
[pkgs/test]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/test
zwol
August 3, 2026, 9:20pm
138
I posted these at the end of May and nobody’s looked at them:
Subham
August 4, 2026, 12:56am
139
Hi added a PR for introducing IPTVnator which is an open source iptv player.
There hasn’t been much activity after a reviewer joined.
master ← SUBHAM-ROY:iptvnator-init
opened 02:08AM - 12 Jul 26 UTC
Add [IPTVnator](https://github.com/4gray/iptvnator), a cross-platform IPTV playe… r application with support for m3u/m3u8 playlists, favorites, TV guide, and TV archive/catchup.
## Things done
- Built on platform:
- [x] x86_64-linux
- [ ] aarch64-linux
- [ ] aarch64-darwin
- Tested, as applicable:
- [ ] [NixOS tests] in [nixos/tests].
- [ ] [Package tests] at `passthru.tests`.
- [ ] Tests in [lib/tests] or [pkgs/test] for functions and "core" functionality.
- [x] Ran `nixpkgs-review` on this PR. See [nixpkgs-review usage].
- [x] Tested basic functionality of all binary files, usually in `./result/bin/`.
- Nixpkgs Release Notes
- [ ] Package update: when the change is major or breaking.
- NixOS Release Notes
- [ ] Module addition: when adding a new NixOS module.
- [ ] Module update: when the change is significant.
- [x] Fits [CONTRIBUTING.md], [pkgs/README.md], [maintainers/README.md] and other READMEs.
- [x] Follows the [automation/AI policy].
[NixOS tests]: https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests
[Package tests]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests
[nixpkgs-review usage]: https://github.com/Mic92/nixpkgs-review#usage
[CONTRIBUTING.md]: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md
[automation/AI policy]: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#automationai-policy
[lib/tests]: https://github.com/NixOS/nixpkgs/blob/master/lib/tests
[maintainers/README.md]: https://github.com/NixOS/nixpkgs/blob/master/maintainers/README.md
[nixos/tests]: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests
[pkgs/README.md]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md
[pkgs/test]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/test
Subham
August 7, 2026, 7:58am
140
Merged now. Thanks a lot @doronbehar
master ← dustins:technitium-dns-server-working-directory
opened 12:57AM - 17 Jul 26 UTC
I recently ran into an issue where Technitium was showing unusually high CPU usa… ge despite essentially no query load (~0.24 qps). htop showed one thread in Technitium's thread pool rotating through high utilization with a lot of time spent in syscalls. Running `strace -c` for a few seconds on the process showed >600k `getdents64` and 2.8M `newfstatat` calls, which felt way out of proportion to what the server should be doing.
I checked which paths the offending file descriptors pointed at (`/proc/<tid>/fd/*`) and found they resolved to `/` and `/nix` — so whatever was doing the enumerating seems like it was walking from the filesystem root rather than Technitium's state/config directory.
The service definition doesn't set `WorkingDirectory`, so systemd defaults it to `/`. I added `WorkingDirectory = "%S/technitium-dns-server"` (matching the existing `StateDirectory`) to the service config, and CPU usage dropped to near-idle on every machine I tested this on.
Regardless of the exact mechanism, explicitly setting `WorkingDirectory` to the state directory seems like a correctness win — services probably shouldn't implicitly run with `/` as their working directory.
(Sonnet 5 used to proofread/cleanup my PR summary)
## Things done
- Built on platform:
- [x] x86_64-linux
- [x] aarch64-linux
- [ ] aarch64-darwin
- Tested, as applicable:
- [ ] [NixOS tests] in [nixos/tests].
- [ ] [Package tests] at `passthru.tests`.
- [ ] Tests in [lib/tests] or [pkgs/test] for functions and "core" functionality.
- [ ] Ran `nixpkgs-review` on this PR. See [nixpkgs-review usage].
- [ ] Tested basic functionality of all binary files, usually in `./result/bin/`.
- Nixpkgs Release Notes
- [ ] Package update: when the change is major or breaking.
- NixOS Release Notes
- [ ] Module addition: when adding a new NixOS module.
- [ ] Module update: when the change is significant.
- [ ] Fits [CONTRIBUTING.md], [pkgs/README.md], [maintainers/README.md] and other READMEs.
- [x] Follows the [automation/AI policy].
[NixOS tests]: https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests
[Package tests]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests
[nixpkgs-review usage]: https://github.com/Mic92/nixpkgs-review#usage
[CONTRIBUTING.md]: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md
[automation/AI policy]: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#automationai-policy
[lib/tests]: https://github.com/NixOS/nixpkgs/blob/master/lib/tests
[maintainers/README.md]: https://github.com/NixOS/nixpkgs/blob/master/maintainers/README.md
[nixos/tests]: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests
[pkgs/README.md]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md
[pkgs/test]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/test
Fixes a real issue users have (in some cases leads to a Crash), its one line and just needs a merge.
Thanks!