Hi, I’ve got a merge request that fixes clangd when ran with --query-driver - it’s been waiting since Nov 2024 and it’s confirmed to work, could someone take a look? Thanks
staging ← Patryk27:improve-clang-tools
opened 12:30PM - 09 Nov 24 UTC
clang-tools invokes clangd through a wrapper script whose sole purpose is to ext… end `CPATH` and `CPLUS_INCLUDE_PATH` envs, so that clangd is later able to find built-in and stdlib headers.
This script does two things wrong:
1. We extend `CPATH` et al with entries from both `@clang@/nix-support/libc-cflags` and `@clang@/resource-root/include`, which is kind of a self-made problem, since clangd already has some header auto-detection logic which we (used to) circumvent (for more details, see the diff).
2. We extend `CPATH` et al unconditionally, breaking the `--query-driver` option. I'm not sure what's the perfect solution here, but skipping this logic when we detect `--query-driver` should be good enough. I mean, ideally we wouldn't be playing with `CPATH` etc. whatsoever, but well.
Closes https://github.com/NixOS/nixpkgs/issues/351962
Closes https://github.com/NixOS/nixpkgs/issues/348791
Closes https://github.com/NixOS/nixpkgs/issues/345704
## Things done
- Built on platform(s)
- [x] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- For non-Linux: Is sandboxing enabled in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html))
- [ ] `sandbox = relaxed`
- [ ] `sandbox = true`
- [x] Tested, as applicable:
- [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- and/or [package tests](https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests)
- or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test)
- made sure NixOS tests are [linked](https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#linking-nixos-module-tests-to-a-package) to the relevant packages
- [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage)
- [x] Tested basic functionality of all binary files (usually in `./result/bin/`)
- [24.11 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2411.section.md) (or backporting [23.11](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md) and [24.05](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2405.section.md) Release notes)
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [ ] (Module updates) Added a release notes entry if the change is significant
- [ ] (Module addition) Added a release notes entry if adding a new NixOS module
- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).
---
Add a :+1: [reaction] to [pull requests you find important].
[reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/
[pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc
Hello this PR adding nohang (prevents system freezes on low memory) that’s like 95% done but stalled since June 2025. Seems to have merge conflicts and the original author is inactive. Can someone with experience adopt this and push it across the finish line? I really do not know how to package stuff
master ← Dev380:nohang
opened 01:44AM - 21 May 25 UTC
Nohang is an out of memory process killer for Linux as an alternative to the def… ault kernel OOM killer. The github page is here: https://github.com/hakavlad/nohang. This package has been requested before in #144819
Closes #144819
## Things done
It should build everywhere because there's no build phase (just copying some python files to $out/bin) but I've only tested it on my machine.
- Built on platform(s)
- [x] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- [x] Tested, as applicable:
- [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- and/or [package tests](https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests)
- or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test)
- made sure NixOS tests are [linked](https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#linking-nixos-module-tests-to-a-package) to the relevant packages
- [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage)
- [ ] Tested basic functionality of all binary files (usually in `./result/bin/`)
- [Nixpkgs 25.11 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/doc/release-notes/rl-2511.section.md) (or backporting [24.11](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/release-notes/rl-2411.section.md) and [25.05](https://github.com/NixOS/nixpkgs/blob/master/doc/manual/release-notes/rl-2505.section.md) Nixpkgs Release notes)
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [NixOS 25.11 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2511.section.md) (or backporting [24.11](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2411.section.md) and [25.05](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2505.section.md) NixOS Release notes)
- [ ] (Module updates) Added a release notes entry if the change is significant
- [x] (Module addition) Added a release notes entry if adding a new NixOS module
- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).
---
Add a :+1: [reaction] to [pull requests you find important].
[reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/
[pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc
This PR is close to be in a “mergeable” state, but requires some help on python wrapping and other issue mentioned in the comment linked :
> I'm not sure what's at fault but I suspect it's the python wrapper. If anyone … has more experience with python/wrapping/polkit auth, I could use some help.
~~The short answer is `lib/howdy-gtk/init.py` doesn't have executable bit 😅~~
~~Wait, it's not~~
Okay, it is but we still have more problems.
https://github.com/boltgolt/howdy/blob/master/howdy-gtk/src/window.py#L121
https://github.com/barneygale/elevate/blob/master/elevate/posix.py#L51
It is just using pkexec to re-execute current argv0. And it's only passing down arguments, not environment variables 🥶
dwt
January 11, 2026, 2:02pm
127
I would like to simplify allowing unfree packages via a config that is merged like most configuration values. I do have an implementation and unit tests for it, but it is quite stuck for lack of review.
master ← dwt:nixpkgs-config-allowUnfreePackages
opened 04:39PM - 06 Apr 25 UTC
Inspired by https://github.com/NixOS/nixpkgs/issues/197325 this adds a new optio… n nixpkgs.allowUnfreePackages, which merges additively and can thus be defined in multiple modules close to where the unfree package is installed.
I would have liked ot name this option
`nixpkgs.config.allowUnfreePackages`, to define it closer to where the `allowUnfree` and `allowUnfreePredicate` options are defined, but I didn't see how this could be achived, given that `nixpkgs.config` is an attribute set or function instead of a module. I would welcome some guidance on how to do this.
I would also have liked to have an assertion that this setting should not be defined when `nixpkgs.config.allowUnfreePredicate or `nixpkgs.config.allowUnfree` is set, but I don't yet know how to do that. (And I would like to learn).
Closes #197325
## Things done
- Built on platform(s)
- [ ] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [x] aarch64-darwin
- For non-Linux: Is sandboxing enabled in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html))
- [ ] `sandbox = relaxed`
- [ ] `sandbox = true`
- [x] Tested, as applicable:
- [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- and/or [package tests](https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests)
- or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test)
- made sure NixOS tests are [linked](https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#linking-nixos-module-tests-to-a-package) to the relevant packages
- [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage)
- [ ] Tested basic functionality of all binary files (usually in `./result/bin/`)
- [25.05 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2505.section.md) (or backporting [24.11](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2411.section.md) and [25.05](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2505.section.md) Release notes)
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [ ] (Module updates) Added a release notes entry if the change is significant
- [ ] (Module addition) Added a release notes entry if adding a new NixOS module
- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).
---
Add a :+1: [reaction] to [pull requests you find important].
[reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/
[pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc
1 Like
(Hope nixos-hardware PRs are allowed!) There’s a bit of a backlog on PRs for nixos-hardware. Some of them (like the one linked) are necessary for folks to rebuild their systems on 25.11. I don’t want to put extra pressure on the maintainers, and would love to help out with reviews if possible. I just want to make sure these are at least being seen.
master ← 8bitbuddhist:surface-rust-target-spec-fix
opened 06:12PM - 29 Nov 25 UTC
###### Description of changes
Adds a patch for older kernel versions so they … can build using Rust 1.91, which is used in NixOS 25.11. This fixes a build error and #1685.
Update: Due to a cryptic build error, Rust is disabled for the 6.12 (`longterm`) kernel. It can be re-enabled for the next LTS kernel (6.18).
###### Things done
- [X] Tested the changes in your own NixOS Configuration
- [X] Tested the changes end-to-end by using your fork of `nixos-hardware` and
importing it via `<nixos-hardware>` or Flake input
1 Like
