PRs ready for review [May 2019]

There are two pending reviews for nixpkgs from my side:


And an older one from NixOS/nix:

Not mine, but one I’m looking forward to, should bring a lot of azure support to NixOS. https://github.com/NixOS/nixpkgs/pull/60435

This is a (simple) backport of memtest86-efi to 19.03:

Something I’ve been waiting a long time for:

Has already been reviewed by two people, needs someone able to review for merging. :slight_smile:

Merged! Thanks!

Looking for other opinions on whether these added options are valuable. I believe they are:

Another httpd subservice converted into a module:

It would be great to get these two commits merged if possible, neither are really old but both have approving reviews and I believe are ready to merge.


This one fixes a bug hasn’t seen any response in a few months:

1 Like

Here’s a security fix for znc that’s waiting since yesterday: https://github.com/NixOS/nixpkgs/pull/63141
It’s just a cherry-pick from master into release-19.03.

I’ve got 2 PRs that haven’t gotten any response yet.

This one fixes bundlerApp to actually do what the documentation says and provide the env and wrappedRuby attributes in passthru:

This one updates the broken macvim package to work again. It’s not pure (it relies on a few system-provided tools, including Xcode, and MacVim’s build process picks up the current OS as the deployment target) but the old package wasn’t pure either.

Edit: Merged, thanks!

1 Like

I’d like some feedback as to whether my current approach is fine or whether there’s something better.
I.e. something that doesn’t duplicate the nix code from the original package but doesn’t have to build wine just for the fonts.

Thanks :slight_smile:

I’ve got a couple of trivial PRs that have already had eyeballs on them but nobody’s merged them.

https://github.com/NixOS/nixpkgs/pull/63988

https://github.com/NixOS/nixpkgs/pull/63678

A simple fix to get zoneminder building and running again: https://github.com/NixOS/nixpkgs/pull/63824

Three of my PRs that seem to be burried:

Update of pyo3-pack. This would be nice to have, because the new pyo3 crate does not work well with the old pyo3-pack (the old pyo3-pack will attempt to build a Python 2 wheel if Python 2 is visible, whereas Python 2 is not supported anymore by pyo3). Also has two reviews:

https://github.com/NixOS/nixpkgs/pull/63321 (merged)

The directoryRoot option of the Resilio Sync module does not work anymore, this PR fixes that:

Slightly newer, but I think useful to many people, a PR that adds the draw.io desktop application. Has one review:

https://github.com/NixOS/nixpkgs/pull/64109 (merged)

Two simple package additions:
https://github.com/NixOS/nixpkgs/pull/63496
https://github.com/NixOS/nixpkgs/pull/63497
Updates:
https://github.com/NixOS/nixpkgs/pull/63714
https://github.com/NixOS/nixpkgs/pull/64290
This one is relatively recent but I’d appreciate if anyone on Darwin can help get libplacebo building on it:
https://github.com/NixOS/nixpkgs/pull/64442

I would appreciate an extra pair of eyes on https://github.com/NixOS/nixpkgs/pull/63932 if anyone has the time.

I mentioned this a week ago but https://github.com/NixOS/nixpkgs/pull/63678 is a trivial PR that still hasn’t been merged.

PR 63371 has been languishing for a while now. A reviewer raised a question, and I answered it, but then… no response.

Edit: Merged now. Thank you @Infinisil :pray:

PR 64204, which is adding one Node package and updating all Node packages. Had an issue where by version of node2nix was old, which I fixed the same day. Has been sitting for just over two weeks now.