This PR might need some more reviewing, since it hasn’t really been established what approach is most desired. Please see the PR for more context.
https://github.com/NixOS/nixpkgs/pull/106888
Some small refactors in OpenTabletDriver package+add hardware.opentabletdriver.package
option:
https://github.com/NixOS/nixpkgs/pull/108131
Can someone please review this init? I can build and run it fine, but I’m not knowledgeable in identifying if it’s a proper addition.
Can someone please review this init?
It doesn’t require too much testing, only check if the application runs (for the rest, you need to inscribe as taxpayer and connect your application with whatever standard being used for digital signing )
Small change, was reviewed and now somebody needs to merge it: subtitleeditor: add more gst-plugins by ilmari-lauhakangas · Pull Request #106076 · NixOS/nixpkgs · GitHub
Hello people who come here with PRs ready for review!
I’d like to suggest that you try the marvin bot (usage here) before posting to this thread, and only if the marvin bot fails to get you a reviewer to come post here.
The marvin bot sure is still under beta and has some quirks, but in my experience it works pretty well and it’s much more efficient from a reviewer point of view: it’ll send the notification to a single reviewer, instead of to all reviewers as currently happens with this thread. The only issue I’ve noticed it having is, when a reviewer is unresponsive it won’t automatically ping another one yet, but instead will tell you to run /status needs_reviewer
to manually request another reviewer.
And this message is also for reviewers (including people who would like to help reviewing without merge rights yet): feel free to sign up to marvin as per the procedure described here! Currently there’s no shortage of reviewers yet (all PRs still open that have marvin enabled are waiting on changes by the PR author), but hopefully with this message more people will opt-in into marvin, and so we’ll need more registered reviewers
Fix for vimPlugins update.py script
And two more plugins
https://github.com/NixOS/nixpkgs/pull/106281
Posting some PRs that seem very interesting but are lacking attention (and I can’t review them since I have zero context):
Very simple:
https://github.com/NixOS/nixpkgs/pull/41144
One-line change:
https://github.com/NixOS/nixpkgs/pull/78430
Seems simple:
https://github.com/NixOS/nixpkgs/pull/54891
Clean-up:
https://github.com/NixOS/nixpkgs/pull/60256
Seems polemic:
https://github.com/NixOS/nixpkgs/pull/33661
Backport fixes from picom to release-20.09:
https://github.com/NixOS/nixpkgs/pull/108744
Add tests to opentabletdriver module:
https://github.com/NixOS/nixpkgs/pull/108789
Rewrite of redshift module:
https://github.com/NixOS/nixpkgs/pull/108739