Some small refactors in OpenTabletDriver package+add hardware.opentabletdriver.package option:
https://github.com/NixOS/nixpkgs/pull/108131
Can someone please review this init? I can build and run it fine, but I’m not knowledgeable in identifying if it’s a proper addition.
Can someone please review this init?
It doesn’t require too much testing, only check if the application runs (for the rest, you need to inscribe as taxpayer and connect your application with whatever standard being used for digital signing 
)
Small change, was reviewed and now somebody needs to merge it: subtitleeditor: add more gst-plugins by ilmari-lauhakangas · Pull Request #106076 · NixOS/nixpkgs · GitHub
Hello people who come here with PRs ready for review!
I’d like to suggest that you try the marvin bot (usage here) before posting to this thread, and only if the marvin bot fails to get you a reviewer to come post here.
The marvin bot sure is still under beta and has some quirks, but in my experience it works pretty well and it’s much more efficient from a reviewer point of view: it’ll send the notification to a single reviewer, instead of to all reviewers as currently happens with this thread. The only issue I’ve noticed it having is, when a reviewer is unresponsive it won’t automatically ping another one yet, but instead will tell you to run /status needs_reviewer to manually request another reviewer.
And this message is also for reviewers (including people who would like to help reviewing without merge rights yet): feel free to sign up to marvin as per the procedure described here! Currently there’s no shortage of reviewers yet (all PRs still open that have marvin enabled are waiting on changes by the PR author), but hopefully with this message more people will opt-in into marvin, and so we’ll need more registered reviewers 
5 Likes
Fix for vimPlugins update.py script
And two more plugins
https://github.com/NixOS/nixpkgs/pull/106281
Posting some PRs that seem very interesting but are lacking attention (and I can’t review them since I have zero context):
Very simple:
https://github.com/NixOS/nixpkgs/pull/41144
One-line change:
https://github.com/NixOS/nixpkgs/pull/78430
Seems simple:
https://github.com/NixOS/nixpkgs/pull/54891
Clean-up:
https://github.com/NixOS/nixpkgs/pull/60256
Seems polemic:
https://github.com/NixOS/nixpkgs/pull/33661
1 Like
Backport fixes from picom to release-20.09:
https://github.com/NixOS/nixpkgs/pull/108744
Add tests to opentabletdriver module:
https://github.com/NixOS/nixpkgs/pull/108789
Rewrite of redshift module:
https://github.com/NixOS/nixpkgs/pull/108739
Extra config file support for Vault allowing us to load storage backend credentials without leaking them to the store.
1 Like
Even though it’s not nixpkgs, feedback for the following two would be greatly appreciated:
-
Miscellaneous improvements for positioning in eval-errors by Ma27 · Pull Request #4440 · NixOS/nix · GitHub tries to provide better error-locations in eval errors in Nix. Apart from technical feedback, I’d like to know if the changes I’m working on make actually sense
- Add a filter for maintainers in the jobset-eval view by Ma27 · Pull Request #743 · NixOS/hydra · GitHub adds a feature to Hydra so you can filter jobset-lists for packages you’re maintaining (as it was IIRC requested on NixCon 2019).
This is improvement of libinput module fixing a long term issue (since 20.03 I think?). It also allows configuration of mouse and touchpads separately:
https://github.com/NixOS/nixpkgs/pull/108909
Simple module fix that should cause nixosTests.moinmoin to pass again. Would like to backport this to 20.09 eventually since it’s broken there too. It’s a python web app.
My simple Nix PR is almost 2 months old and still hasn’t been looked at.