PRs ready for review _

ckie · July 8, 2023, 4:51pm

https://github.com/NixOS/nixpkgs/pull/234881

OPNA2608 · July 8, 2023, 5:16pm

https://github.com/NixOS/nixpkgs/pull/241160

wililamvds · July 8, 2023, 6:27pm

Hi there, I’ve got a new package for pihole in this PR:
I’ve been running it on a Raspberry Pi and it’s been solid so far. Unfortunately it needs a fair bit of patching to get rid of the nasty self-install/upgrade stuff.

github.com/NixOS/nixpkgs

pihole: init at various

NixOS:master ← williamvds:add_pihole

opened 09:41PM - 05 Apr 23 UTC

williamvds

+1353 -1

###### Description of changes [Pihole](https://pi-hole.net) describes itself …as "A black hole for Internet advertisements". It's a suite for running and administrating a DNS sinkhole, which filters queries and caches their results, primarily to block advertisements and other undesirable traffic originating from the LAN. Built on dnsmasq, the DNS server (called pihole-FTL) can also be used as a DHCP server to automatically configure LAN clients to use pihole's DNS. The pihole-ftl package is based on #108055 by @JamieMagee (itself based on the work of @nuxeh). The remaining work was done mostly from scratch. This PR resolves the package request issue #61617. This PR includes packages for: * [pihole-ftl](https://github.com/pi-hole/FTL): The DNS server, forked from dnsmasq * [pihole-adminlte:](https://github.com/pi-hole/AdminLTE) A web server which shows statistics, logs, and allows more advanced configuration of pihole-FTL * [pihole](https://github.com/pi-hole/pi-hole): A collection of scripts for managing pihole-FTL The last one needs the heaviest modifications, particularly to excise the reinstallation/upgrade functionality, which is not needed on NixOS. NixOS modules are provided for pihole-ftl and pihole-adminlte. pihole-ftl's module is largely a wrapper around the existing dnsmasq one, since they are mostly compatible applications. Some additional options are provided for automatically setting the adlists for pihole to download and apply. pihole-adminlte's module is rather minimal, with some cosmetic options for temperature units and the web theme. To do: - [x] Documentation - [ ] NixOS tests for AdminLTE and pihole-FTL? - [ ] Diagnose/resolve a bug where AdminLTE gets "attempt to write to a readonly database" errors until it is restarted. - This only happens on the first run, when AdminLTE starts before `/etc/pihole/gravity.db` is created - Could be systemd hardening? ###### Things done - Built on platform(s) - [x] x86_64-linux - [x] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html)) - [ ] Tested, as applicable: - [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests) - or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) - made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages - [x] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage) - [x] Tested basic functionality of all binary files (usually in `./result/bin/`) - [23.05 Release Notes (or backporting 22.11 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2305-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [x] (Module addition) Added a release notes entry if adding a new NixOS module - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

If anyone could take a look that would be fab, thanks!

Astavie · July 11, 2023, 9:09am

simple version update of Odin

github.com/NixOS/nixpkgs

odin: dev-2023-05 -> dev-2023-07

NixOS:master ← Astavie:master

opened 11:03AM - 10 Jul 23 UTC

Astavie

+11 -7

ols: nightly-05-18 -> nightly-07-09 ols should be updated simultaneously as it …is updated in tandem with the odin compiler ###### Description of changes https://github.com/odin-lang/Odin/releases/tag/dev-2023-07 ###### Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html)) - [ ] Tested, as applicable: - [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests) - or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) - made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage) - [ ] Tested basic functionality of all binary files (usually in `./result/bin/`) - [23.11 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md) (or backporting [23.05 Release notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2305.section.md)) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

wineee · July 11, 2023, 9:37am

https://github.com/NixOS/nixpkgs/pull/241259

StepBroBD · July 11, 2023, 2:44pm

github.com/NixOS/nixpkgs

airbuddy: 2.6.3 -> 2.7

NixOS:master ← stepbrobd:airbuddy

opened 04:23PM - 08 Jul 23 UTC

stepbrobd

+14 -2

###### Description of changes  update airbuddy: 2.6.3 -> 2.7 ###### Things done - Built on platform(s) - [ ] x86_64-linux - [ ] aarch64-linux - [x] x86_64-darwin - [x] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html)) - [ ] Tested, as applicable: - [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests) - or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) - made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages - [x] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage) - [x] Tested basic functionality of all binary files (usually in `./result/bin/`) - [23.11 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md) (or backporting [23.05 Release notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2305.section.md)) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

github.com/NixOS/nixpkgs

python3Packages.metawear: init at 1.0.8

NixOS:master ← stepbrobd:metawear

opened 06:23PM - 19 Jun 23 UTC

stepbrobd

+62 -0

###### Description of changes  python3Packages.metawear: init at 1.0.8 metawear - https://pypi.org/project/metawear/ - https://github.com/mbientlab/metawear-sdk-python dependency [warble](https://github.com/NixOS/nixpkgs/pull/238628) - https://github.com/NixOS/nixpkgs/pull/238628 ```shell $ nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD" 2 packages built: python310Packages.metawear python311Packages.metawear ``` ###### Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html)) - [ ] Tested, as applicable: - [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests) - or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) - made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages - [x] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage) - [x] Tested basic functionality of all binary files (usually in `./result/bin/`) - [23.11 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md) (or backporting [23.05 Release notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2305.section.md)) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

Janik · July 11, 2023, 8:38pm

github.com/NixOS/nixpkgs

opensycl: init at 0.9.4

NixOS:master ← yboettcher:add-opensycl

opened 12:42PM - 06 Jun 23 UTC

yboettcher

+76 -0

###### Description of changes SYCL is a standard for writing C++ code that ca…n be executed on both CPUs and GPUs from a single source file (somewhat like CUDA/HIP). From their Readme: "Open SYCL is a modern SYCL implementation targeting CPUs and GPUs from all major vendors that supports many use cases and approaches for implementing SYCL". https://github.com/OpenSYCL/OpenSYCL As far as I could tell there is not yet any support for SYCL in nixpkgs. I tested the resulting compiler on OpenSYCLs own `tests` folder and found no issues, so it appears to be working fine. In a simple "manual" test, I got it to compile for both my CPU and my RX 480 and both binaries ran fine (with the exception of crashing my wayland session in case of the GPU, but I guess this is less an issue with the OpenSYCL compiler and more with the GPU drivers, but I'm no expert on this). As for the derivation itself, I did not include a checkPhase, because it looks like the included tests are a separate cmake project and can't just simply be run by calling ctest. Also, I set the maintainers field with an empty list. While I did create this derivation, this was quite a simple endeavour and I don't know if I could be of any help if any actual problems arise. Additionally, I am not sure how long I would be interested in SYCL for my personal use. (and I thought it might be strange to just add myself to the maintainers list.) On a final note, OpenSYCL also claims to support both Intel and NVidia GPUs through oneAPI and CUDA, but since I lack such hardware, I only added CPU and AMD support. ###### Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html)) - [ ] Tested, as applicable: - [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests) - or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) - made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage) - [x] Tested basic functionality of all binary files (usually in `./result/bin/`) - [23.11 Release Notes (or backporting 23.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2305-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

WolfangAukang · July 12, 2023, 1:19am

https://github.com/NixOS/nixpkgs/pull/241291

tni · July 13, 2023, 5:05am

This PR was opened yesterday, but I took it over to shepherd from a PR that’s been open for about a week. Warning: it’s a bit larger than normal because it involves updating various update scripts to keep them working.

https://github.com/NixOS/nixpkgs/pull/243018