PRs ready for review _

I’ve got a couple of trivial PRs that have already had eyeballs on them but nobody’s merged them.

~~https://github.com/NixOS/nixpkgs/pull/63988~~

~~https://github.com/NixOS/nixpkgs/pull/63678~~

A simple fix to get zoneminder building and running again: ~~https://github.com/NixOS/nixpkgs/pull/63824~~

Three of my PRs that seem to be burried:

Update of pyo3-pack. This would be nice to have, because the new pyo3 crate does not work well with the old pyo3-pack (the old pyo3-pack will attempt to build a Python 2 wheel if Python 2 is visible, whereas Python 2 is not supported anymore by pyo3). Also has two reviews:

[s]https://github.com/NixOS/nixpkgs/pull/63321[/s] (merged)

The directoryRoot option of the Resilio Sync module does not work anymore, this PR fixes that:

https://github.com/NixOS/nixpkgs/pull/62948

Slightly newer, but I think useful to many people, a PR that adds the draw.io desktop application. Has one review:

[s]https://github.com/NixOS/nixpkgs/pull/64109[/s] (merged)

Two simple package additions:
https://github.com/NixOS/nixpkgs/pull/63496
https://github.com/NixOS/nixpkgs/pull/63497
Updates:
https://github.com/NixOS/nixpkgs/pull/63714
https://github.com/NixOS/nixpkgs/pull/64290
This one is relatively recent but I’d appreciate if anyone on Darwin can help get libplacebo building on it:
https://github.com/NixOS/nixpkgs/pull/64442

I would appreciate an extra pair of eyes on ~~https://github.com/NixOS/nixpkgs/pull/63932~~ if anyone has the time.

I mentioned this a week ago but ~~https://github.com/NixOS/nixpkgs/pull/63678~~ is a trivial PR that still hasn’t been merged.

PR 63371 has been languishing for a while now. A reviewer raised a question, and I answered it, but then… no response.

Edit: Merged now. Thank you @Infinisil :pray:

PR 64204, which is adding one Node package and updating all Node packages. Had an issue where by version of node2nix was old, which I fixed the same day. Has been sitting for just over two weeks now.

https://github.com/NixOS/nixpkgs/pull/63668

Seeking secondary review of anyone has a moment to spare please.

This thread is tagged as May. At what point do we create a new thread? And maybe we should pin the current “PRs ready for review” to the top so people can find it more easily.

Any keepassx users?

https://github.com/NixOS/nixpkgs/pull/57786

I’ve got a PR open for a setup script that allows you to declare manpages and shell completions in a declarative fashion, so you don’t have to remember where the darn things are supposed to be installed. This came out of this prior discussion.

https://github.com/NixOS/nixpkgs/pull/65211

Still have one open as part of an update. Noticed it was broken when reviewing an automated update.

https://github.com/NixOS/nixpkgs/pull/64848

While playing the triage game I found this PR which hasn’t been reviewed:

https://github.com/NixOS/nixpkgs/pull/58088

Any volunteers?

This PR for updating vcv-rack has been informally reviewed and might need a last look before merge. :slight_smile:

https://github.com/NixOS/nixpkgs/pull/63984

This PR has been informally reviewed and tested, might need a quick look and merge:

https://github.com/NixOS/nixpkgs/pull/64584

This PR could use some additional attention, it’s already been through some technical revisions:
https://github.com/NixOS/nixpkgs/pull/65283

It’s not really clear to me how long I should let my PRs sit before listing them here, but my trivial macvim update has been sitting for a week.

~~https://github.com/NixOS/nixpkgs/pull/65713~~

I’ve also already got an approval from @rycee on this next one but I don’t know if that’s waiting for @Ericson2314 (who’s listed as a code owner of the pkgs/build-support/setup-hooks directory), or if they just wanted someone else to approve it too.

https://github.com/NixOS/nixpkgs/pull/65211

We need someone with some basic nginx knowledge. This PR is pretty simple, but I’ve never used nginx so I just don’t have the context.

https://github.com/NixOS/nixpkgs/pull/61722

Would appreciate a second pair of eyes, or any domain specific experts:

https://github.com/NixOS/nixpkgs/pull/65853