PRs ready for review _

Congee · December 24, 2022, 3:55am

https://github.com/NixOS/nixpkgs/pull/207511

veehaitch · December 24, 2022, 2:19pm

Dear Santa,

please consider reviewing if not merging the following PRs which some of your elves already took a look at before:

https://github.com/NixOS/nixpkgs/pull/204145
https://github.com/NixOS/nixpkgs/pull/203449

YourFin · December 24, 2022, 7:48pm

I have two 9 day old updates for two gnu packages that I would really appreciate a review on! I tried to clean their builds up a little while I was at it

https://github.com/NixOS/nixpkgs/pull/206300

https://github.com/NixOS/nixpkgs/pull/206317

romildo · December 24, 2022, 9:01pm

https://github.com/NixOS/nixpkgs/pull/206700

zarel · December 25, 2022, 7:54pm

There is a new nixos test that would cover both existing and new features.

https://github.com/NixOS/nixpkgs/pull/205653

emilylange · December 26, 2022, 4:58am

https://github.com/NixOS/nixpkgs/pull/206161

mlyxshi · December 26, 2022, 7:58am

https://github.com/NixOS/nixpkgs/pull/207814

urandom · December 26, 2022, 8:28am

https://github.com/NixOS/nixpkgs/pull/207781
https://github.com/NixOS/nixpkgs/pull/207794
https://github.com/NixOS/nixpkgs/pull/207796
https://github.com/NixOS/nixpkgs/pull/207802
https://github.com/NixOS/nixpkgs/pull/207812

aaronjheng · December 26, 2022, 9:16am

https://github.com/NixOS/nixpkgs/pull/205486

autrimpo · December 26, 2022, 9:41am

https://github.com/NixOS/nixpkgs/pull/207106
https://github.com/NixOS/nixpkgs/pull/207819

andersk · December 26, 2022, 8:58pm

https://github.com/NixOS/nixpkgs/pull/206653

https://github.com/NixOS/nixpkgs/pull/207505

https://github.com/NixOS/nixpkgs/pull/207620

urandom · December 26, 2022, 11:40pm

github.com/NixOS/nixpkgs

mgmt, nex: init at unstable

NixOS:master ← urandom2:mgmt

opened 02:25PM - 01 Nov 22 UTC

urandom2

+98 -0

###### Description of changes This change adds two packages: mgmt and nex. Th…e latter is a build dependency for the former. Unfortunately both do not have stable releases, thus each tracks the tip of their respective upstream branches. Go module pseudo versions are used. mgmt: Next generation distributed, event-driven, parallel config management! nex: Lexer for Go Fixes #98458 purpleidea/mgmt#610 ###### Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html)) - [x] Tested, as applicable: - [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests) - or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) - made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages - [x] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage) - [x] Tested basic functionality of all binary files (usually in `./result/bin/`) - [22.11 Release Notes (or backporting 22.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2211-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [ ] (Release notes changes) Ran `nixos/doc/manual/md-to-db.sh` to update generated release notes - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

https://github.com/NixOS/nixpkgs/pull/202978
https://github.com/NixOS/nixpkgs/pull/203017
https://github.com/NixOS/nixpkgs/pull/203020
https://github.com/NixOS/nixpkgs/pull/203582
https://github.com/NixOS/nixpkgs/pull/203904
https://github.com/NixOS/nixpkgs/pull/203905
https://github.com/NixOS/nixpkgs/pull/203932
https://github.com/NixOS/nixpkgs/pull/207884

milahu · December 27, 2022, 8:21am

https://github.com/NixOS/nixpkgs/pull/200788

amesgen · December 27, 2022, 1:20pm

github.com/NixOS/nixpkgs

rustPlatform.buildRustPackage: support `finalAttrs` style

NixOS:master ← amesgen:buildRustPackage-finalAttrs

opened 07:43PM - 04 Oct 22 UTC

amesgen

+86 -82

###### Description of changes This PR explores supporting the new `finalAttrs…` derivation style for `buildRustPackage`, similar to what is suggested in https://github.com/NixOS/nixpkgs/pull/119942#issuecomment-1014718769. It is basically an extended version of #179392, and in particular also would close #107070. A few notes: - This change should be entirely opt-in and cause no rebuilds. - This PR adds an ad-hoc way to prevent some attrs (called "intermediate args" here) to be passed to the underlying derivation call by specifying `removeFromBuilderEnv`. Another option would be to allow an arbitrary function (similar to `apply` in the module system), but that might be too powerful/confusing. Also see https://github.com/NixOS/nixpkgs/pull/194475#discussion_r1163670441. - Rust packages can be incrementally converted and then enjoy the benefits outlined in #119942 As an example, I converted `difftastic` to the new style, such that changing its version is now much DRYer: ```nix pkgs.difftastic.overrideAttrs (oldAttrs: { version = "0.37.0"; src = oldAttrs.src.overrideAttrs (_: { outputHash = "sha256-LwDoIvhZj/1fHg2eWgadwTcegeOKPpY8aCAugLfKtDE="; }); cargoHash = "sha256-j7PVzGCButQhxVXVrtWhT6a6F1SLNe0jAy8oGqr9NvQ="; cargoLock = null; postPatch = ""; }) ``` Also note that `passthru.tests.version` then automatically points to the new package. - The "overlay" in `buildRustPackage` has a few curiosities, i.e. we have to be careful to avoid `infinite recursion` errors: - It is not possible to use the `{ a ? "", ...}@finalAttrs` syntax. Even `{...}@finalAttrs` causes `infinite recursion`. - Asserts involving attributes from `finalAttrs` have to be "hidden" inside of values. Right now, I moved them to the respective attributes/variables; another option would be to put them into a dedicated `asserts` attribute, i.e. `asserts = assert (all asserts here); "";`. Maybe there are better solutions for these problems around, but they don't seem too terrible. ###### Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html)) - [ ] Tested, as applicable: - [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests) - or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) - made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage) - [ ] Tested basic functionality of all binary files (usually in `./result/bin/`) - [22.11 Release Notes (or backporting 22.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2211-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [ ] (Release notes changes) Ran `nixos/doc/manual/md-to-db.sh` to update generated release notes - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

github.com/NixOS/nixpkgs

tandem-aligner: init at unstable-2022-09-17

NixOS:master ← amesgen:add-TandemAligner

opened 07:22PM - 15 Dec 22 UTC

amesgen

+58 -0

###### Description of changes https://github.com/seryrzu/tandem_aligner ##…#### Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html)) - [x] Tested, as applicable: - [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests) - or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) - made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage) - [x] Tested basic functionality of all binary files (usually in `./result/bin/`) - [23.05 Release Notes (or backporting 22.11 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2305-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [ ] (Release notes changes) Ran `nixos/doc/manual/md-to-db.sh` to update generated release notes - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).