PRs ready for review _

c00w · April 26, 2020, 12:17am

I’ve got an update that needs review / merging, lots (4) people have looked at it and multiple have signed off, but I think so far no one has signed off who can merge it.
https://github.com/NixOS/nixpkgs/pull/83253

bhougland · April 29, 2020, 1:48am

For anyone that likes minimal window managers, here are two packages that will add to Nixpkgs bevy of cool window managers:

https://github.com/NixOS/nixpkgs/pull/85495

https://github.com/NixOS/nixpkgs/pull/85174

Can someone review please

bbigras · April 29, 2020, 1:40pm

Repost but still waiting for a review:
https://github.com/NixOS/nixpkgs/pull/85507

lilyball · April 30, 2020, 7:24pm

I’ve got a couple of items waiting for review. These are reposts but it’s been a while.

This needs someone who cares about macOS. And I’d really like to get it in sooner than later because macvim is currently broken with Xcode 11.4.

https://github.com/NixOS/nixpkgs/pull/85321

This one got reviewed by @Profpatsch a month ago but nothing since then. It needs a re-review.

https://github.com/NixOS/nixpkgs/pull/83630

Profpatsch · May 1, 2020, 2:42pm

Lily Ballard via NixOS Discourse nixos1@discoursemail.com writes:

This one got reviewed by @Profpatsch a month ago but nothing since then. It needs a re-review.

installShellFiles: Enhance installShellCompletion by lilyball · Pull Request #83630 · NixOS/nixpkgs · GitHub

Yep, sorry, I still have it open and look at it once in a while, but
haven’t had time to think about the testing issue. I suggest we merge
and think about tests as a followup.

lopsided98 · May 1, 2020, 4:46pm

Some Robot Operating System (ROS) dependencies I’m working on upstreaming:
https://github.com/NixOS/nixpkgs/pull/85983

das-g · May 2, 2020, 12:19am

An Esperanto dictionary for the command line:

https://github.com/NixOS/nixpkgs/pull/85040

PR got comments from someone who successfully tested it, but so far no code review, yet.

I wonder whether me implementing this as three packages is the right approach:

package prevo-tools provides
- the executable prevodb to pre-process the dictionary data
- the executable prevo to query the dictionary (requiring the pre-processed data)
They’re build from the same source code repo and have a relation similar to the one between updatedb and locate.
package prevo-data provides the pre-processed dictionary data (using prevodb from prevo-tools at build-time)
package prevo links the other two packages together, so that the prevo command will use the data from prevo-data by default. (Can be overridden by a command line option.)