Hi,
I am trying to get a change into cabal2nix in order to get a couple Haskell packages working. I haven’t gotten any feedback on my PR in a week or so, and I was wondering if there was anyone that would be able to do a review and possibly merge my PR.
(Normally I wouldn’t mind at all if a PR I sent in wasn’t receiving any action, but I’m hoping to get everything here working in time for 18.09! As far as I’m aware, there is only a few more days left for this.)
Here’s the PR:
NixOS:master ← cdepillabout:add-vte-to-resolveInNixpkgs
opened 02:14PM - 09 Aug 18 UTC
Add an override to the vte system library so that `gnome3.vte` is used instead o… f `gnome2.vte`.
This is similar to how gtk and gtksourceview work.
This is necessary so that Haskell packages that depend on VTE get setup to use VTE from Gnome3 instead of Gnome2.
This was suggested in https://github.com/NixOS/nixpkgs/pull/44529#discussion_r208072760.
An overview of why this is needed for the `gi-vte` package can be found [here](https://github.com/NixOS/nixpkgs/pull/44529#issuecomment-411624086).
Ideally I'd like to get this PR in to cabal2nix in order to get `gi-vte` working in time for the 18.09 release.
This PR is to get the gi-vte Haskell package compiling on NixOS. It is part of a larger set of PRs, one of which has already been merged in:
NixOS:haskell-updates ← cdepillabout:fix-gi-vte-haskell-pkg
opened 01:55AM - 06 Aug 18 UTC
###### Motivation for this change
The [gi-vte](https://hackage.haskell.org/pa… ckage/gi-vte) Haskell package does not compile in master:
https://hydra.nixos.org/job/nixpkgs/haskell-updates/haskellPackages.gi-vte.x86_64-linux
gi-vte depends on the gi-gtk Haskell package, as well as the VTE system library. The gi-gtk Haskell packge depends on the GTK system library. Currently, gi-gtk is being compiled against the GTK system library from Gnome 3. However, gi-vte is being compiled against the VTE system library from Gnome 2.
This PR does the following three things:
1. Change the gi-vte package to depend the VTE system library from Gnome 3 in `hackage-packages.nix`.
2. Add a dependency on the GTK system library for gi-vte. I'm not sure exactly why this is necessary, but gi-vte wouldn't build without it.
3. Remove the gi-vte package from `dont-distribute-packages` in `configuration-hackage2nix.yaml`.
Eventually, I'd like to add a new Haskell [package](https://hackage.haskell.org/package/termonad) to nixpkgs that depends on gi-vte, so I would like gi-vte to be compiling in master. I'd like to get this in before the 18.09 release.
However, I think the `hackage-packages.nix` file (and maybe even the `configuration-hackge2nix.yaml`) is being auto-generated, so please let me know if there is some other file I should actually be editing. Also, for my future reference, is there an explanation somewhere of how the Haskell-related nixpkg files work? Like, which files I should edit and send PRs to?
Pinging the nixpkgs Haskell maintainers: @peti @ryantm @basvandijk (please let me know if it is not appropriate to do this)
###### Things done
- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
- Built on platform(s)
- [X] NixOS
- [ ] macOS
- [ ] other Linux distributions
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"` (**there are currently no packages that depend on gi-vte**)
- [ ] Tested execution of all binary files (usually in `./result/bin/`) (**there are no binary files produced by gi-vte**)
- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).
---
I need gi-vte as a dependency for a new Haskell package I’m releasing called Termonad . Ideally I’d like to have this available in 18.09, but it first depends on getting gi-vte compiling.
Thanks.
zimbatm
September 9, 2018, 4:53pm
2
Sorry for the delay. Looks like they both got merged luckily.
1 Like