Rules around adding to someone's PR

Development
1

I couldn’t find a good description around rules for adding to someone’s PR in the nixpkgs repo. I was wondering if there’s an existing policy I missed?

For example there’s a PR which is in limbo for a while mc: help with discoverability by 06kellyjac · Pull Request #189474 · NixOS/nixpkgs · GitHub with just a trivial change needed. I’m sometimes tempted to add the fix myself since the author did allow maintainers to modify the PR, but I know this would really annoy some people.

Is there any policy for this? I’m happy to merge that and do the remaining fixes in a separate PR if not.

4 Likes
2

I’ve been doing that for a while for situations like these, but I haven’t encountered anybody being annoyed over it, so don’t worry about it and just go for it. If people don’t want that they can disallow it explicitly by unchecking the button when creating the PR.

2 Likes
3

Would be great if we documented that in the contributor guide. It’s good to set expectations, even if there is no firm rule. @viraptor would you mind opening a pull request to the manual?

1 Like
4

Done at https://github.com/NixOS/nixpkgs/pull/197319

1 Like