I try to get KiCad updated to newer version via PR. I run into problem when tests fails due to missing fontconfig config:
E AssertionError: assert 'Fontconfig e...ile: (null)\n' == ''
E
E + Fontconfig error: Cannot load default config file: No such file: (null)
I cannot find any help regarding how to fix it in test sandbox.
Can you share the PR?
Here you go - kicad-unstable: b7b64d959f -> c22eac2fbf by uzytkownik · Pull Request #335314 · NixOS/nixpkgs · GitHub
Note that this PR just disables tests so undo the changes to repro the problem.
Likely same as fonts broken for some applications · Issue #338933 · NixOS/nixpkgs · GitHub. Should be fixed in [staging] fontconfig: fix properly by K900 · Pull Request #338328 · NixOS/nixpkgs · GitHub
Do you know when it will be in master. Alternatively how to pull it in nixpkgs-review without rebuilding half of packages in nixpkgs (figuratively speaking)?
Couple weeks, and yeah it’s going to staging specifically because it will cause a mass rebuild.
FWIW it is still failing in the same way with picked up change.
Picked up how?
This has already been fixed in [staging-next] nixos/fontconfig: hack to put everyone's fonts back by K900 · Pull Request #338326 · NixOS/nixpkgs · GitHub and nixos/fonts: Fix nested quotes in fontconfig.nix by ejls · Pull Request #338815 · NixOS/nixpkgs · GitHub. It will be in the unstable channel in a matter of days, not weeks. See Nixpkgs PR #338815 ("nixos/fonts: Fix nested quotes in fontconfig.nix") progress for the tracker.
You can use nixos-unstable-small to get the fix immediately at the cost of more builds.
git cherry-pick (apparently I need 20 characters or more)
The upcoming staging-next PR was only opened 3 days ago, so I’d estimate about 5 days until a merge into master and then a couple more days minimum until it reaches nixos-unstable, so 7 days minimum. That’s… a week, lol.
Not to mention all the hydra delays and funny PRs that can extend that.
“days not weeks” is splitting hairs but given that there’s no hard schedule here, and we get numerous eval and build failures on master recently, guessing about 2 weeks isn’t too far off.
Okay but did you cherry-pick the fixes from 338326 and 338328? (There might be more, I didn’t check the file history.)
@jtojnar pointed to a staging PR that will fix this problem properly but won’t make it until the next cycle, which would imply users will have to wait 3 to 4 weeks at minimum to see a fix here. The staging-next PR I linked that fixed it in a hackier way had already hit the unstable channels at the time I linked it, and the follow‐up nixos/fonts: Fix nested quotes in fontconfig.nix by ejls · Pull Request #338815 · NixOS/nixpkgs · GitHub that addressed the issue the OP is seeing went straight to master. You can click the PR tracker I linked and see that it has already hit the small channel; the main unstable channel is just blocked right now. The difference between 2 to 3 days for a follow‐up PR to hit the unstable channels and a PR that will land in the next staging cycle weeks from now is huge.
Ok then @uzytkownik fetch the usptream remote and rebase your PR on upstream/master (or replace upstream with whatever you called the upstream remote in your local clone)