Attendees: @roberth @thufschmitt @edolstra @ericson2314 @fricklerhandwerk
Agenda
- Discuss upstreaming the DetSys installer (45 min)
- Reconsider `Raw` pattern · Issue #7479 · NixOS/nix · GitHub (5 min)
-
Prioritize testing in the maintainers process docs by Ericson2314 · Pull Request #8039 · NixOS/nix · GitHub (5 min)
- Small process PR that keeps on getting far down the triage board (due to alphabetized labels)
- Issue Discussion
Installer
-
@thufschmitt reports from installer workgroup
- proposal: try a modified DetSys installer as an experiment
- needs a few changes
- not clear yet who would do the job
- options:
- give green light and support for upstream PRs
- make it our own priority (would imply dropping others)
- call for contributors (continuation or successor to the installer workgroup)
- proposal: try a modified DetSys installer as an experiment
-
@fricklerhandwerk: actionable next steps?
-
@fricklerhandwerk: look at the source together
- @ericson2314: should be a PR before we review anything
- @edolstra: gather more experience with new users
- @thufschmitt: make it an official experiment
-
@fricklerhandwerk: look at the source together
- decisions:
- we agree to make it an official experiment, and put it out as an alternative installer, without guarantees
- the official experiment requires:
- Experimental features disabled by default
- Telemetry disabled by default or taken out altogether
- The source living in a NixOS GitHub org repo with designated maintainers
- Fixes from the DetSys installer are upstreamed into the NixOS org version during the experiment
- if only one intaller is properly maintained during the experiment we won’t have a good basis to evaluate afterwards
- the official experiment requires:
- we will come back to reviewing the actual code and making decisions on upstreaming based on the experiment’s results after two months after it begins
- we will consider bug reports and download counts to make the assessment
- we agree to make it an official experiment, and put it out as an alternative installer, without guarantees
Raw pattern
- @ericson2314 has learned of a new improved “raw pattern” that addresses the issues raised (verbosity, leaking names). Hopefully we can agree on it, and then he’ll convert all the existing ones to match it.
- @edolstra: LGTM
- idea approved
- @ericson2314 will do refactorings based on the idea
Prioritise testing
-
@edolstra: increasing test coverage is great, but not sure if it should be a priority over improvements
- only improvements bring new users
-
@fricklerhandwerk: we may want to ask ourselves if more new users is our primary goal. more contributors, and most importantly maintainers, are what needed to keep making improvements in the long run
- well-factored code and robust tests ease the way in for contributors
- @thufschmitt: the rules are supposed to be somewhat flexible anyway
- agreement: merge
Discussion
-
Stuctured command stability by Ericson2314 · Pull Request #7611 · NixOS/nix · GitHub
- decision: only change the infrastructure for now, edit the prose separately
- @ericson2314 will fix up
- decision: only change the infrastructure for now, edit the prose separately
-
Punt on improper global flags for now by Ericson2314 · Pull Request #7610 · NixOS/nix · GitHub
-
@fricklerhandwerk: experimental features should appear in the man page, instead of being skipped
- @thufschmitt: can merge it and do a follow-up
- @ericson2314: agreed
- merged
-
@fricklerhandwerk: experimental features should appear in the man page, instead of being skipped
-
Remove Package Management chapter · Issue #7769 · NixOS/nix · GitHub
- idea approved
-
docs: fix nix-shell commands by milahu · Pull Request #7849 · NixOS/nix · GitHub
- merged
-
Add Store::isTrustedClient() by MatthewCroughan · Pull Request #7515 · NixOS/nix · GitHub
- @Ericson2314 rewrote the PR based on the team’s requested changes, needs a different reviewer
- assigned to @thufschmitt
-
Handle use-xdg-base-directories for profile link by balsoft · Pull Request #7929 · NixOS/nix · GitHub
- should not invoke Nix to check the config option
- no decision, still to discuss
-Track parsing and evaluation activities by jfroche · Pull Request #7247 · NixOS/nix · GitHub
- macOS segfaults in CI
- Concerning, frustrating
-
Finish converting existing comments for internal API docs by Ericson2314 · Pull Request #8146 · NixOS/nix · GitHub
- Assigned to @edolstra