bbigras
September 28, 2023, 1:32am
73
Anyone knows what to do when the git repo doesn’t have any tags, and we want to build from source?
https://github.com/NixOS/nixpkgs/pull/249553#discussion_r1322253005
Haven’t looked at the PR, but in general, the fact there are no Git tags should have no effect on the decision whether to build from source or not. In general, building from source is preferred, with or without Git tags.
In case Git tags are missing, but there are version strings staggered in the source, it’d be nice to ping upstream about it, and use an explicit git revision in the meantime. Put a good comment near where the commit hash revision is used (instead of a rev = version
or alike). Use the revision that marked the bump of the version string in the source.
3 Likes
Catouc
October 27, 2023, 11:17am
76
Hi I’ve had this package approved and ready to merge for a while now is there anything left to do? terraform-plugin-docs: init at v0.16.0 by catouc · Pull Request #249387 · NixOS/nixpkgs · GitHub
Thanks in advance!
2 Likes
https://github.com/NixOS/nixpkgs/pull/203020
This PR seemed almost complete and then was shutdown can anyone take the mantle of fixing it, I can maintain it afterward!
Atemu
October 27, 2023, 6:43pm
78
@nyanbinary this PR is not “in distress”. The author simply lost interest in pursuing it.
https://github.com/NixOS/nixpkgs/pull/264454
Stuck in how to move forward on this PR so far, just got it to compile.
Yarny
November 17, 2023, 5:06pm
80
It would be nice for NixOS 23.11 to have working user lingering.
https://github.com/NixOS/nixpkgs/pull/261319
Thra11
November 22, 2023, 9:49pm
81
This PR was approved in July, but is still waiting for somebody to merge it:
https://github.com/NixOS/nixpkgs/pull/240179
I don’t know whether the problem is that ofborg has gone awol without finishing the checks:
“Started 3m 28d 4h 50m 7s ago”
I believe that particular check would have passed if ofborg had run it at the time. If rerun now, it will probably fail, since something recently broke libpostal on macOS. Hopefully, that’s fixed by libpostal: fix on darwin by Thra11 · Pull Request #269292 · NixOS/nixpkgs · GitHub , but since I don’t believe that that failure is in any way related to the original PR, I’d rather keep things simple and merge the original PR first and then apply the darwin fix on top of it.
1 Like
Yarny
December 2, 2023, 10:56am
82
I’m new to contributing to NixOS, may I know what are the next steps to get reviewers to this PR →
NixOS:master
← siddarthkay:init/xcbeautify
opened 01:08PM - 04 Feb 24 UTC
## Description of changes
[xcbeautify](https://github.com/cpisciotta/xcbeauti… fy) is a tool to format `xcodebuild` output.
derivation of `xcbeautify` in status-mobile repo -> https://github.com/status-im/status-mobile/blob/develop/nix/pkgs/xcbeautify/default.nix
## Things done
- Built on platform(s)
- [ ] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- For non-Linux: Is sandboxing enabled in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html))
- [ ] `sandbox = relaxed`
- [ ] `sandbox = true`
- [ ] Tested, as applicable:
- [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests)
- or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test)
- made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages
- [x] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage)
- [x] Tested basic functionality of all binary files (usually in `./result/bin/`)
- [24.05 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2405.section.md) (or backporting [23.05](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2305.section.md) and [23.11](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md) Release notes)
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [ ] (Module updates) Added a release notes entry if the change is significant
- [ ] (Module addition) Added a release notes entry if adding a new NixOS module
- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).
---
Add a :+1: [reaction] to [pull requests you find important].
[reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/
[pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc
I don’t see an option to attach reviewers etc.
What would be a normal ETA for such things?
Thank you
@siddarthkay , there is PRs ready for review _ that seems more adequate to start with.
1 Like
I need Darwin gurus to fix the issues in this package:
NixOS:master
← atorres1985-contrib:lightning
opened 01:13PM - 10 Feb 24 UTC
## Description of changes
<!--
For package updates please link to a changelo… g or describe changes, this helps your fellow maintainers discover breaking updates.
For new packages please briefly describe the package or provide a link to its homepage.
-->
Closes https://github.com/NixOS/nixpkgs/pull/287661
## Things done
- Built on platform(s)
- [ ] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- For non-Linux: Is sandboxing enabled in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html))
- [ ] `sandbox = relaxed`
- [ ] `sandbox = true`
- [ ] Tested, as applicable:
- [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests)
- or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test)
- made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages
- [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage)
- [ ] Tested basic functionality of all binary files (usually in `./result/bin/`)
- [24.05 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2405.section.md) (or backporting [23.05](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2305.section.md) and [23.11](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md) Release notes)
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [ ] (Module updates) Added a release notes entry if the change is significant
- [ ] (Module addition) Added a release notes entry if adding a new NixOS module
- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).
<!--
To help with the large amounts of pull requests, we would appreciate your
reviews of other pull requests, especially simple package updates. Just leave a
comment describing what you have tested in the relevant package/service.
Reviewing helps to reduce the average time-to-merge for everyone.
Thanks a lot if you do!
List of open PRs: https://github.com/NixOS/nixpkgs/pulls
Reviewing guidelines: https://nixos.org/manual/nixpkgs/unstable/#chap-reviewing-contributions
-->
---
Add a :+1: [reaction] to [pull requests you find important].
[reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/
[pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc
Also, I would like some Darwin user to share maintainership, but not urgent.
I need Darwin gurus to take a look at this PR pls, its a macOS only package and it has 2 approvals.
Looking for next steps to merge.
Thank you.!
h3ndrik
February 19, 2024, 3:13pm
87
Hey, can we get the “shiny” python library merged? (and shinywidgets and htmltools)
There is an (now outdated) PR here: python310Packages.{shiny, rsconnect_*} by nviets · Pull Request #231189 · NixOS/nixpkgs · GitHub
majiy00
February 20, 2024, 9:31pm
88
Any help to get these merged would be greatly appreciated:
pbsds
February 20, 2024, 10:05pm
89
Reminder that this thread is for PRs that have you stumped and need input to get unstuck.
If what you’re requesting is a review/merge, then please at least first post a couple of times in PRs ready for review _
errnoh
February 23, 2024, 1:24pm
90
Likely should’ve posted here in the first place, but created a separate help request at: Help with packaging complex Rust library
Basically looking for someone with more familiarity with packaging Rust libraries to help me out.
NixOS:master
← endgame:python-email-validator-bump
opened 09:52PM - 27 Feb 24 UTC
## Description of changes
https://github.com/JoshData/python-email-validator/… releases/tag/v2.1.1
Upstream reissued their 2.1.0 tarball, breaking non-cache fetches. May as well move to the new release.
## Things done
- Built on platform(s)
- [X] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- For non-Linux: Is sandboxing enabled in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html))
- [ ] `sandbox = relaxed`
- [ ] `sandbox = true`
- [ ] Tested, as applicable:
- [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests)
- or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test)
- made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages
- [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage)
- [ ] Tested basic functionality of all binary files (usually in `./result/bin/`)
- [24.05 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2405.section.md) (or backporting [23.05](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2305.section.md) and [23.11](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md) Release notes)
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [ ] (Module updates) Added a release notes entry if the change is significant
- [ ] (Module addition) Added a release notes entry if adding a new NixOS module
- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).
---
Add a :+1: [reaction] to [pull requests you find important].
[reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/
[pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc
What’s the best way to deal with an upstream which reissues tarballs that have different hashes?
Maybe using raw rev hash?