PRs ready for review _

PR 63371 has been languishing for a while now. A reviewer raised a question, and I answered it, but then… no response.

Edit: Merged now. Thank you @Infinisil :pray:

PR 64204, which is adding one Node package and updating all Node packages. Had an issue where by version of node2nix was old, which I fixed the same day. Has been sitting for just over two weeks now.

https://github.com/NixOS/nixpkgs/pull/63668

Seeking secondary review of anyone has a moment to spare please.

This thread is tagged as May. At what point do we create a new thread? And maybe we should pin the current “PRs ready for review” to the top so people can find it more easily.

Any keepassx users?

https://github.com/NixOS/nixpkgs/pull/57786

I’ve got a PR open for a setup script that allows you to declare manpages and shell completions in a declarative fashion, so you don’t have to remember where the darn things are supposed to be installed. This came out of this prior discussion.

https://github.com/NixOS/nixpkgs/pull/65211

Still have one open as part of an update. Noticed it was broken when reviewing an automated update.

https://github.com/NixOS/nixpkgs/pull/64848

While playing the triage game I found this PR which hasn’t been reviewed:

https://github.com/NixOS/nixpkgs/pull/58088

Any volunteers?

This PR for updating vcv-rack has been informally reviewed and might need a last look before merge. :slight_smile:

https://github.com/NixOS/nixpkgs/pull/63984

This PR has been informally reviewed and tested, might need a quick look and merge:

https://github.com/NixOS/nixpkgs/pull/64584

This PR could use some additional attention, it’s already been through some technical revisions:
https://github.com/NixOS/nixpkgs/pull/65283

It’s not really clear to me how long I should let my PRs sit before listing them here, but my trivial macvim update has been sitting for a week.

~~https://github.com/NixOS/nixpkgs/pull/65713~~

I’ve also already got an approval from @rycee on this next one but I don’t know if that’s waiting for @Ericson2314 (who’s listed as a code owner of the pkgs/build-support/setup-hooks directory), or if they just wanted someone else to approve it too.

https://github.com/NixOS/nixpkgs/pull/65211

We need someone with some basic nginx knowledge. This PR is pretty simple, but I’ve never used nginx so I just don’t have the context.

https://github.com/NixOS/nixpkgs/pull/61722

Would appreciate a second pair of eyes, or any domain specific experts:

https://github.com/NixOS/nixpkgs/pull/65853

This has been sitting for a while, and I still use this patch in other projects: autoPatchelfHook: Use alternative interpreters in multilib envs by tadfisher · Pull Request #51588 · NixOS/nixpkgs · GitHub

I hope I’m not too late for the party, but I have a nice package init waiting:

https://github.com/NixOS/nixpkgs/pull/65492

https://github.com/NixOS/nixpkgs/pull/60485

Mostly needs someone to go over the changes to the install-grub.pl script, the systemd-boot-builder.py changes I am more confident in. Perl is not really in my bailiwick. This one had already bitrotted a bit, and as there are other changes to boot stuff coming, I’d rather not end up maintaining it locally longer-term…

I’m looking for review regarding some changes to the phpfpm module.

https://github.com/NixOS/nixpkgs/pull/65706

I’ve mentioned these before but the following are still waiting either to be reviewed or just merged

https://github.com/NixOS/nixpkgs/pull/65211

~~https://github.com/NixOS/nixpkgs/pull/65713~~

And this trivial change is also starting to show its age

~~https://github.com/NixOS/nixpkgs/pull/66251~~

I’m looking for review regarding a small change to nixos/display-managers/default.nix : nixos/x11: provide selected session to custom session by pstch · Pull Request #67260 · NixOS/nixpkgs · GitHub