PRs ready for review

Hi all,

I have some time this weekend to review and merge PRs. I was hoping some suggestions for what to review could come in this thread. It often happens where a perfectly good PR gets ignored & I hope to give some of these attention.

Please reply with a link to a PR (can be yours or someone else’s) and I can take a look at it. I am especially looking for concise, finished PRs that are 7+ days old without any significant attention.

5 Likes

This one was lying around as WIP for a while: openmpi: 3.1.0->3.1.2 by markuskowa · Pull Request #46007 · NixOS/nixpkgs · GitHub

matthewbauer,

What a fantastic offer :slight_smile: The following seem like they fit your conditions:

https://github.com/NixOS/nixpkgs/pull/46045
https://github.com/NixOS/nixpkgs/pull/46027

And possibly this one:

https://github.com/NixOS/nixpkgs/pull/45469

Thanks!

I’ve got these two (should be fairly simple and fast to build):

and

Thank you for your offer!

k3b is not working without mount /nix/store as writeable, which is bad.

Fixes #19154 missing permissions for k3b by ngiger · Pull Request #163883 · NixOS/nixpkgs · GitHub creates a wrapper for it.

It works for me, and yesterday I even got a “Thank you” but it was not picked up nor negatively reviewed in the last 12 day.

Thanks in advance!

python310Packages.asn1crypto: 1.4.0 -> 1.5.1 by WolfangAukang · Pull Request #168024 · NixOS/nixpkgs · GitHub

Please and thankyou!

sov: init at 0.63 by twitchyliquid64 · Pull Request #170459 · NixOS/nixpkgs · GitHub again please!

Sorry, wrong thread!

https://github.com/NixOS/nixpkgs/pull/182760

Sorry, wrong thread!
https://github.com/NixOS/nixpkgs/pull/182765

Hi, i’d be really happy to have some feedback on find-tarballs.nix: Include patches by rapenne-s · Pull Request #188626 · NixOS/nixpkgs · GitHub

Hosted by Flying Circus.