PRs ready for review

[matthewbauer]

Hi all,

I have some time this weekend to review and merge PRs. I was hoping some suggestions for what to review could come in this thread. It often happens where a perfectly good PR gets ignored & I hope to give some of these attention.

Please reply with a link to a PR (can be yours or someone else’s) and I can take a look at it. I am especially looking for concise, finished PRs that are 7+ days old without any significant attention.

[markuskowa]

This one was lying around as WIP for a while: openmpi: 3.1.0->3.1.2 by markuskowa · Pull Request #46007 · NixOS/nixpkgs · GitHub

[aanderse]

matthewbauer,

What a fantastic offer The following seem like they fit your conditions:

https://github.com/NixOS/nixpkgs/pull/46607
https://github.com/NixOS/nixpkgs/pull/46309
https://github.com/NixOS/nixpkgs/pull/46153
https://github.com/NixOS/nixpkgs/pull/46045
https://github.com/NixOS/nixpkgs/pull/46027

And possibly this one:

https://github.com/NixOS/nixpkgs/pull/45469

Thanks!

[manveru]

I’ve got these two (should be fairly simple and fast to build):

https://github.com/NixOS/nixpkgs/pull/47246

and

https://github.com/NixOS/nixpkgs/pull/47389

[Moredread]

Thank you for your offer!

https://github.com/NixOS/nixpkgs/pull/44077

[sikmir]

https://github.com/NixOS/nixpkgs/pull/164460

[ngiger]

k3b is not working without mount /nix/store as writeable, which is bad.

Fixes #19154 missing permissions for k3b by ngiger · Pull Request #163883 · NixOS/nixpkgs · GitHub creates a wrapper for it.

It works for me, and yesterday I even got a “Thank you” but it was not picked up nor negatively reviewed in the last 12 day.

Thanks in advance!

[WolfangAukang]

~~https://github.com/NixOS/nixpkgs/pull/168024~~

[trofi]

• linuxHeaders: 5.16 -> 5.17 by trofi · Pull Request #165224 · NixOS/nixpkgs · GitHub
• gitUpdater: add explicit url parameter to specify a git tree for tags by trofi · Pull Request #166841 · NixOS/nixpkgs · GitHub
• glm: fix build on clang (no -fno-ipa-modref support) by trofi · Pull Request #166888 · NixOS/nixpkgs · GitHub
• ethtool: 5.16 -> 5.17 by trofi · Pull Request #167432 · NixOS/nixpkgs · GitHub

[twitchyliquid64]

Please and thankyou!

https://github.com/NixOS/nixpkgs/pull/170459

[twitchyliquid64]

sov: init at 0.63 by twitchyliquid64 · Pull Request #170459 · NixOS/nixpkgs · GitHub again please!

[Flakebi]

• profile-sync-daemon: fix sync before sleep by Flakebi · Pull Request #149959 · NixOS/nixpkgs · GitHub profile-sync-daemon: fix sync before sleep
• spirv-cross: MoltenVK-1.1.5 -> unstable-2022-01-18 by Flakebi · Pull Request #157499 · NixOS/nixpkgs · GitHub spirv-cross: MoltenVK-1.1.5 → unstable-2022-01-18
• yamlpath: init at 3.6.3 by Flakebi · Pull Request #147378 · NixOS/nixpkgs · GitHub yamlpath: init at 3.6.3

[Craftzman7]

Sorry, wrong thread!

~~https://github.com/NixOS/nixpkgs/pull/182760~~

[Craftzman7]

Sorry, wrong thread!
~~https://github.com/NixOS/nixpkgs/pull/182765~~

[sikmir]

https://github.com/NixOS/nixpkgs/pull/187569

[sikmir]

https://github.com/NixOS/nixpkgs/pull/189229

[azahi]

https://github.com/NixOS/nixpkgs/pull/187026
https://github.com/NixOS/nixpkgs/pull/189712
https://github.com/NixOS/nixpkgs/pull/189893

[Solene]

Hi, i’d be really happy to have some feedback on find-tarballs.nix: Include patches by rapenne-s · Pull Request #188626 · NixOS/nixpkgs · GitHub

[vccs]

~~https://github.com/NixOS/nixpkgs/pull/191145~~ Merged

https://github.com/NixOS/nixpkgs/pull/191055

~~https://github.com/NixOS/nixpkgs/pull/191034~~ Merged

~~https://github.com/NixOS/nixpkgs/pull/190884~~ Merged

https://github.com/NixOS/nixpkgs/pull/190127

~~https://github.com/NixOS/nixpkgs/pull/189720~~ Merged

[sikmir]

https://github.com/NixOS/nixpkgs/pull/188954
https://github.com/NixOS/nixpkgs/pull/187627