NixOS:master ← ju1m:transmission
opened 04:47AM - 30 Aug 20 UTC
###### Motivation for this change
Leveraging [freeformType](https://github.com/…NixOS/nixpkgs/pull/82743) on `services.transmission.settings`.
###### Things done
- [X] Move settings assertions to options.
- [X] Alias option `port` to `settings.rpc-port`.
- [X] Alias option `openFirewall` to `openPeerPorts`.
- [X] Add option `openRPCPort`.
- [X] Add option `settings.trash-original-torrent-files`.
- [X] Add `mkDefault`s when setting `boot.kernel.sysctl`.
- [X] Use `<xref linkend="opt-services.transmission.${optionName}"/>` in `description`s.
- [X] Fix https://github.com/NixOS/nixpkgs/issues/135695 by removing the `InaccessiblePaths=` on the `RootDirectory=`'s path.
- [X] Remove `SystemCallErrorNumber=EPERM` which may silent failures to call a disallowed syscalls instead of failing hard with an `ESYS`, that will enable us to know more easily if we need to relax the `SystemCallFilter=` (using `coredumpctl debug` to know which syscall failed).
- [X] Fix `watch-dir` creation.
- [ ] Tested using sandboxing ([nix.useSandbox](https://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](https://nixos.org/nix/manual/#sec-conf-file) on non-NixOS linux)
- Built on platform(s)
- [X] NixOS
- [ ] macOS
- [ ] other Linux distributions
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"`
- [ ] Tested execution of all binary files (usually in `./result/bin/`)
- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
- [X] Ensured that relevant documentation is up to date
- [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).