PRs ready for review _

SuperSamus · August 17, 2023, 8:51am

bottles: fix GStreamer on 32 bit apps

NixOS:master ← SuperSamus:bottles-gstreamer

opened 10:35AM - 13 Aug 23 UTC

## Description of changes Because of the gst_all_1 input, 64 bit GStreamer wa…s sneaking into the 32 bit libs. Basically: ```nix { buildFHSEnv , gst_all_1 # Because of this input... }: buildFHSEnv { multiPkgs = pkgs: with pkgs; { # This is both 32 bit and 64 bit hello # ...this is target arch only (because the `with pkgs;` doesn't apply in this case) gst_all_1.gst-plugins-base }; } ``` This commit removes the `gst_all_1` input to correct that. Also removes setting `GST_PLUGIN_PATH`, as it doesn't seem necessary anymore. (That env is the reason why I added the `gst_all_1` input and accidentally causing the issue in the first place. Ugh...) Closes #207641. ## Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html)) - [ ] Tested, as applicable: - [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests) - or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) - made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage) - [x] Tested basic functionality of all binary files (usually in `./result/bin/`) - [23.11 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md) (or backporting [23.05 Release notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2305.section.md)) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

github.com/NixOS/nixpkgs

heroic: Add more GStreamer plugins

NixOS:master ← SuperSamus:heroic-gstreamer

opened 03:05PM - 13 Aug 23 UTC

SuperSamus

+9 -1

## Description of changes They are often needed for GStreamer to work. While… this may look similar to #215248, that PR assumes that "Prefer System Libraries" is disabled (the default). This PR is for the case in which "Prefer System Libraries" is enabled. ## Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html)) - [ ] Tested, as applicable: - [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests) - or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) - made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage) - [x] Tested basic functionality of all binary files (usually in `./result/bin/`) - [23.11 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md) (or backporting [23.05 Release notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2305.section.md)) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

figsoda · August 17, 2023, 6:42pm

https://github.com/NixOS/nixpkgs/pull/247182

dawidd6 · August 17, 2023, 6:47pm

https://github.com/NixOS/nixpkgs/pull/241313

ikovnatsky · August 18, 2023, 8:15am

https://github.com/NixOS/nixpkgs/pull/249906

mdlayher · August 18, 2023, 2:29pm

A three line change here with links to the docs to confirm it’s valid. Thanks!

https://github.com/NixOS/nixpkgs/pull/244722

LudovicoSforza · August 18, 2023, 7:52pm

https://github.com/NixOS/nixpkgs/pull/249904

Alper-Celik · August 18, 2023, 9:58pm

i will open pr for packaging SDK / Selenium Webdriver using AT-SPI · GitLab after this i didn’t done it in this pr because i might need to force push and i am not sure to force push to older commit

https://github.com/NixOS/nixpkgs/pull/250039

beef · August 19, 2023, 3:55am

https://github.com/NixOS/nixpkgs/pull/245211

alejandrosame · August 19, 2023, 8:20am

https://github.com/NixOS/nixpkgs/pull/248567

sikmir · August 19, 2023, 12:27pm

https://github.com/NixOS/nixpkgs/pull/247214

chvp · August 19, 2023, 1:46pm

https://github.com/NixOS/nixpkgs/pull/246513

sifmelcara · August 20, 2023, 8:45pm

https://github.com/NixOS/nixpkgs/pull/247777

https://github.com/NixOS/nixpkgs/pull/248470

mmlb · August 20, 2023, 11:47pm

https://github.com/NixOS/nixpkgs/pull/249865

aaronjheng · August 21, 2023, 12:57am

https://github.com/NixOS/nixpkgs/pull/249238

h7x4 · August 21, 2023, 8:09am

https://github.com/NixOS/nixpkgs/pull/244941
https://github.com/NixOS/nixpkgs/pull/242365
https://github.com/NixOS/nixpkgs/pull/245781

SuperSamus · August 21, 2023, 9:09am

https://github.com/NixOS/nixpkgs/pull/250235

mdarocha · August 21, 2023, 5:35pm

https://github.com/NixOS/nixpkgs/pull/249610

github.com/NixOS/nixpkgs

openraPackages.engines.playtest: init at 20230808

NixOS:master ← mdarocha:openra-playtest

opened 06:44AM - 16 Aug 23 UTC

mdarocha

+122 -0

## Description of changes https://github.com/OpenRA/OpenRA/releases/tag/playt…est-20230808 https://github.com/OpenRA/OpenRA/releases/tag/playtest-20230927 Adding a new package since `playtest` is a different release channel.  ## Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html)) - [x] Tested, as applicable: - [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests) - or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) - made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages - [x] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage) - [ ] Tested basic functionality of all binary files (usually in `./result/bin/`) - [23.11 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md) (or backporting [23.05 Release notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2305.section.md)) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

anthonyrsl · August 21, 2023, 8:53pm

https://github.com/NixOS/nixpkgs/pull/249774
https://github.com/NixOS/nixpkgs/pull/249764
https://github.com/NixOS/nixpkgs/pull/249600

Lord-Valen · August 21, 2023, 10:25pm

https://github.com/NixOS/nixpkgs/pull/235655

chvp · August 22, 2023, 2:56pm

Simple package bump: bluej: 5.1.0 -> 5.2.0 by chvp · Pull Request #249926 · NixOS/nixpkgs · GitHub
Fix confirmed by issue reporter: xrdp: use patched xrdp sources when building xorgxrdp by chvp · Pull Request #250189 · NixOS/nixpkgs · GitHub