PRs ready for review _

frostbyte · November 30, 2023, 10:47am

a simple little program, useful for working around problems with audio programs
https://github.com/NixOS/nixpkgs/pull/250991

999eagle · November 30, 2023, 6:19pm

https://github.com/NixOS/nixpkgs/pull/265961

anthonyrsl · November 30, 2023, 9:04pm

https://github.com/NixOS/nixpkgs/pull/270847
https://github.com/NixOS/nixpkgs/pull/270402

hacker1024 · November 30, 2023, 11:24pm

https://github.com/NixOS/nixpkgs/pull/263667

vaci · December 1, 2023, 9:04am

https://github.com/NixOS/nixpkgs/pull/268707

https://github.com/NixOS/nixpkgs/pull/222508

sikmir · December 1, 2023, 5:36pm

https://github.com/NixOS/nixpkgs/pull/268181

Greizgh · December 1, 2023, 10:29pm

I’m afraid seafile is broken on 23.11 without this:
https://github.com/NixOS/nixpkgs/pull/249523

arthsmn · December 1, 2023, 10:57pm

https://github.com/NixOS/nixpkgs/pull/271543

devusb · December 2, 2023, 2:30am

https://github.com/NixOS/nixpkgs/pull/271352
fixes broken package – also broken in 23.11

arthsmn · December 2, 2023, 1:44pm

Simple hash fix
https://github.com/NixOS/nixpkgs/pull/271667

tejing · December 2, 2023, 5:09pm

Second update has gone by without a merge:
https://github.com/NixOS/nixpkgs/pull/266725

AndersonTorres · December 2, 2023, 8:19pm

https://github.com/NixOS/nixpkgs/pull/271469

AndersonTorres · December 2, 2023, 8:34pm

https://github.com/NixOS/nixpkgs/pull/271356

doronbehar · December 3, 2023, 8:18am

A rather simple init PR, I’d like to get into my system config without an overlay

https://github.com/NixOS/nixpkgs/pull/259741

ianmjones · December 3, 2023, 10:44am

Would love a review of the following PR:

https://github.com/NixOS/nixpkgs/pull/269750

I’m the developer of Snippet Expander, and have been using it via overlays that these packages have been derived from for a good while now.

OPNA2608 · December 3, 2023, 12:33pm

https://github.com/NixOS/nixpkgs/pull/243238
https://github.com/NixOS/nixpkgs/pull/245379
https://github.com/NixOS/nixpkgs/pull/245803
https://github.com/NixOS/nixpkgs/pull/246544
https://github.com/NixOS/nixpkgs/pull/246771

onemoresuza · December 3, 2023, 1:49pm

Update Hare to right before the OpenBSD support, bringing the Nixpkgs’ version up to par with Alpine’s.

github.com/NixOS/nixpkgs

hare: unstable-2023-10-23 -> unstable-2023-11-27; harec: unstable-2023-10-22 -> unstable-2023-11-29

NixOS:master ← onemoresuza:hare

opened 04:23PM - 01 Dec 23 UTC

onemoresuza

+122 -107

## Description of changes - hare: migrate to pkgs/by-name - harec: migrate t…o pkgs/by-name - harec: unstable-2023-10-22 -> unstable-2023-11-29 - hare: move platform and arch check to outer let-in - hare: refactor configurePhase and reorder attributes - hare: patch tzdata paths - hare: unstable-2023-10-23 -> unstable-2023-11-27 - hare: set outputs "out" and "man" This update puts `hare` right before the move to support `OpenBSD` on it, which is still having some bugs ironed out.  ## Things done - Built on platform(s) - [X] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - For non-Linux: Is sandboxing enabled in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html)) - [ ] `sandbox = relaxed` - [ ] `sandbox = true` - [X] Tested, as applicable: - [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests) - or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) - made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages - [X] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage) - [X] Tested basic functionality of all binary files (usually in `./result/bin/`) - [24.05 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2405.section.md) (or backporting [23.05](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2305.section.md) and [23.11](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md) Release notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).  ### Priorities Add a :+1: [reaction] to [pull requests you find important]. [reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/ [pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc

2xsaiko · December 3, 2023, 5:58pm

Once again asking for reviews of this:

https://github.com/NixOS/nixpkgs/pull/243169

In addition to the refactors fixes a pretty nasty bug where merging krb5 options silently discards configuration instead of actually merging values.

arthsmn · December 3, 2023, 9:02pm

https://github.com/NixOS/nixpkgs/pull/271905

mdarocha · December 4, 2023, 7:30pm

https://github.com/NixOS/nixpkgs/pull/272113

https://github.com/NixOS/nixpkgs/pull/257489