PRs ready for review _

matthias.sh · January 27, 2026, 9:40am

kaldi: fix build

master ← matthiasdotsh:fix/kaldi-gcc15

opened 12:33PM - 02 Jan 26 UTC

Fix kaldi no longer building with gcc15. Build failed when compiling dependen…cy openfst. ```bash nix-build -A kaldi [...] > from /nix/store/78h4f39zcv9js54af27wys7yba4vzj57-source/src/lib/fst.cc:12: > /nix/store/78h4f39zcv9js54af27wys7yba4vzj57-source/src/include/fst/bi-table.h: In copy constructor 'fst::VectorHashBiTable<I, T, S, FP, H, HS>::VectorHashBiTable(const fst::VectorHashBiTable<I, T, S, FP, H, HS>&)': > /nix/store/78h4f39zcv9js54af27wys7yba4vzj57-source/src/include/fst/bi-table.h:320:31: error: 'const class fst::VectorHashBiTable<I, T, S, FP, H, HS>' has no member named 's_'; did you mean 'h_'? [-Wtemplate-body] > 320 | : selector_(new S(table.s_)), fp_(new FP(*table.fp_)), > | ^~ > | h_ > /nix/store/78h4f39zcv9js54af27wys7yba4vzj57-source/src/include/fst/replace.h: In member function 'bool fst::internal::ReplaceFstImpl<Arc, StateTable, CacheStore>::ComputeArc(const StateTuple&, const Arc&, Arc*, uint32)': > /nix/store/78h4f39zcv9js54af27wys7yba4vzj57-source/src/include/fst/replace.h:804:32: warning: expected 'template' keyword before dependent template name [-Wmissing-template-keyword] > 804 | if (arc.olabel == 0 || arc.olabel < *nonterminal_set_.begin() || > | ^~~~~~ > | template > make[2]: *** [_deps/openfst-build/src/lib/CMakeFiles/fst.dir/build.make:121: _deps/openfst-build/src/lib/CMakeFiles/fst.dir/fst.cc.o] Error 1 ``` ## Things done - Built on platform: - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - Tested, as applicable: - [ ] [NixOS tests] in [nixos/tests]. - [ ] [Package tests] at `passthru.tests`. - [ ] Tests in [lib/tests] or [pkgs/test] for functions and "core" functionality. - [ ] Ran `nixpkgs-review` on this PR. See [nixpkgs-review usage]. - [x] Tested basic functionality of all binary files, usually in `./result/bin/`. - Nixpkgs Release Notes - [ ] Package update: when the change is major or breaking. - NixOS Release Notes - [ ] Module addition: when adding a new NixOS module. - [ ] Module update: when the change is significant. - [ ] Fits [CONTRIBUTING.md], [pkgs/README.md], [maintainers/README.md] and other READMEs. [NixOS tests]: https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests [Package tests]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests [nixpkgs-review usage]: https://github.com/Mic92/nixpkgs-review#usage [CONTRIBUTING.md]: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md [lib/tests]: https://github.com/NixOS/nixpkgs/blob/master/lib/tests [maintainers/README.md]: https://github.com/NixOS/nixpkgs/blob/master/maintainers/README.md [nixos/tests]: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests [pkgs/README.md]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md [pkgs/test]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/test --- Add a :+1: [reaction] to [pull requests you find important]. [reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/ [pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc