Ready for another review!
master ← niklasthorild:qidi-studio-bin
opened 03:28PM - 18 Jan 26 UTC
AppImage version of QIDIStudio packaged for Nix. QIDIStudio is a 3D printer slic… ing software based on Bambu Studio.
## Things done
- Built on platform:
- [x] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- Tested, as applicable:
- [ ] [NixOS tests] in [nixos/tests].
- [ ] [Package tests] at `passthru.tests`.
- [ ] Tests in [lib/tests] or [pkgs/test] for functions and "core" functionality.
- [x] Ran `nixpkgs-review` on this PR. See [nixpkgs-review usage].
- [x] Tested basic functionality of all binary files, usually in `./result/bin/`.
- Nixpkgs Release Notes
- [ ] Package update: when the change is major or breaking.
- NixOS Release Notes
- [ ] Module addition: when adding a new NixOS module.
- [ ] Module update: when the change is significant.
- [x] Fits [CONTRIBUTING.md], [pkgs/README.md], [maintainers/README.md] and other READMEs.
[NixOS tests]: https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests
[Package tests]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests
[nixpkgs-review usage]: https://github.com/Mic92/nixpkgs-review#usage
[CONTRIBUTING.md]: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md
[lib/tests]: https://github.com/NixOS/nixpkgs/blob/master/lib/tests
[maintainers/README.md]: https://github.com/NixOS/nixpkgs/blob/master/maintainers/README.md
[nixos/tests]: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests
[pkgs/README.md]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md
[pkgs/test]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/test
---
Add a :+1: [reaction] to [pull requests you find important].
[reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/
[pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc
These two are ready for review:
master ← nicegamer7:update-ente-web
opened 06:31PM - 22 Jan 26 UTC
Rust code was added in the v1.2.28 release, so this package has not been updatin… g automatically since then. I updated the package definition so that it builds, but I'm not sure how exactly to test it. I use the Ente module on a VPS. If anyone has an idea on how to test this using the Ente module, let me know and I'll do that.
## Things done
- Built on platform:
- [x] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- Tested, as applicable:
- [x] [NixOS tests] in [nixos/tests].
- [ ] [Package tests] at `passthru.tests`.
- [ ] Tests in [lib/tests] or [pkgs/test] for functions and "core" functionality.
- [x] Ran `nixpkgs-review` on this PR. See [nixpkgs-review usage].
- [ ] Tested basic functionality of all binary files, usually in `./result/bin/`.
- Nixpkgs Release Notes
- [ ] Package update: when the change is major or breaking.
- NixOS Release Notes
- [ ] Module addition: when adding a new NixOS module.
- [ ] Module update: when the change is significant.
- [x] Fits [CONTRIBUTING.md], [pkgs/README.md], [maintainers/README.md] and other READMEs.
[NixOS tests]: https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests
[Package tests]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests
[nixpkgs-review usage]: https://github.com/Mic92/nixpkgs-review#usage
[CONTRIBUTING.md]: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md
[lib/tests]: https://github.com/NixOS/nixpkgs/blob/master/lib/tests
[maintainers/README.md]: https://github.com/NixOS/nixpkgs/blob/master/maintainers/README.md
[nixos/tests]: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests
[pkgs/README.md]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md
[pkgs/test]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/test
master ← nicegamer7:update-museum
opened 02:23PM - 06 Feb 26 UTC
Updates the `museum` package to its latest version, and adds myself as a maintai… ner.
The other maintainers don't seem active, and I use this package personally, so I will keep it up to date. Supersedes #473349.
## Things done
- Built on platform:
- [x] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- Tested, as applicable:
- [x] [NixOS tests] in [nixos/tests].
- [ ] [Package tests] at `passthru.tests`.
- [ ] Tests in [lib/tests] or [pkgs/test] for functions and "core" functionality.
- [x] Ran `nixpkgs-review` on this PR. See [nixpkgs-review usage].
- [ ] Tested basic functionality of all binary files, usually in `./result/bin/`.
- Nixpkgs Release Notes
- [ ] Package update: when the change is major or breaking.
- NixOS Release Notes
- [ ] Module addition: when adding a new NixOS module.
- [ ] Module update: when the change is significant.
- [x] Fits [CONTRIBUTING.md], [pkgs/README.md], [maintainers/README.md] and other READMEs.
[NixOS tests]: https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests
[Package tests]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests
[nixpkgs-review usage]: https://github.com/Mic92/nixpkgs-review#usage
[CONTRIBUTING.md]: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md
[lib/tests]: https://github.com/NixOS/nixpkgs/blob/master/lib/tests
[maintainers/README.md]: https://github.com/NixOS/nixpkgs/blob/master/maintainers/README.md
[nixos/tests]: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests
[pkgs/README.md]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md
[pkgs/test]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/test
This one is also ready for review, but I just opened it, so maybe give the maintainer a week, and I’ll post it again if there’s no progress:
master ← nicegamer7:remove-post-patch-list
opened 06:56PM - 06 Feb 26 UTC
This PR corrects the `postPatch` declaration. See Sandro's review on #482769.
…
## Things done
- Built on platform:
- [x] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- Tested, as applicable:
- [ ] [NixOS tests] in [nixos/tests].
- [ ] [Package tests] at `passthru.tests`.
- [ ] Tests in [lib/tests] or [pkgs/test] for functions and "core" functionality.
- [x] Ran `nixpkgs-review` on this PR. See [nixpkgs-review usage].
- [ ] Tested basic functionality of all binary files, usually in `./result/bin/`.
- Nixpkgs Release Notes
- [ ] Package update: when the change is major or breaking.
- NixOS Release Notes
- [ ] Module addition: when adding a new NixOS module.
- [ ] Module update: when the change is significant.
- [x] Fits [CONTRIBUTING.md], [pkgs/README.md], [maintainers/README.md] and other READMEs.
[NixOS tests]: https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests
[Package tests]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests
[nixpkgs-review usage]: https://github.com/Mic92/nixpkgs-review#usage
[CONTRIBUTING.md]: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md
[lib/tests]: https://github.com/NixOS/nixpkgs/blob/master/lib/tests
[maintainers/README.md]: https://github.com/NixOS/nixpkgs/blob/master/maintainers/README.md
[nixos/tests]: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests
[pkgs/README.md]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md
[pkgs/test]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/test
G’day,
This is a breaking PR, so probably needs some discussion. I thought I’d submit it for review, but will be very happy to make this another service module with a name like “-multi” if that would help.
Thanks in advance,
Dave
master ← randomizedcoder:llama-cpp-gfx906
opened 11:25PM - 07 Feb 26 UTC
# nixos/llama-cpp: add multi-instance support
## Summary
Refactor the llam… a-cpp NixOS module to support multiple named instances, each with independent configuration. This allows running multiple llama-cpp servers simultaneously with different models, ports, and GPU configurations. e.g. GPUs with different amount of VRAM, running different models.
Also bumped llama-cpp package from b7898 to b7951 and add NixOS VM tests (cpu based only obviously).
### Key changes
- Replace single-service model with `services.llama-cpp.instances.<name>`
- Add per-instance `rocmGpuTargets` option for AMD GPU architecture targeting
- Add automatic `gpuLayers` detection based on package GPU support (99 for GPU packages, 0 for CPU-only)
- Add `hfRepo` and `hfFile` options for Hugging Face model downloads
- Add GPU-backend-aware DeviceAllow rules (ROCm, CUDA, Vulkan)
- Add typed options: `flashAttention`, `contextSize`, `parallel`, `slots`, etc.
- Add `environment` option for per-instance environment variables
- Add NixOS VM tests for module evaluation and service configuration
### Motivation
This pull request has taken me a few days to put together and test. The original intention was to get my MI50 working, but then I found it was hard to run with both graphics cards (other card is a baby).
Therefore, I've added support for multi instances. e.g. Run one bigger model on a bigger 32GB card, and a little model on the baby 8GB card.
This will be a "breaking change", so I would understand if people aren't so keen. The change to config should be small, but if you guys would prefer to make a different service with "-multi" or similar, I'd be happy to do that. Happy to discuss the best way forward.
Testing this took a long time, because the compiling takes so long, and I tighten the systemd security, which also took time to get correct. This is about as well tested as I can do with the hardware I have. Would be nice to test on machines with fancy/expensive GPUs (that I don't have ). I have tested on AMD and Nvidia, but all these cards are pretty old.
Another thing I notice is that our nixpkgs nix is pretty out of sync with the llama.cpp repo itself. I will try to create a pull request for llama.cpp to see if we can more closely align them. ( But it's cool to see the Meta team using nix! woot woot ;) )
Anyway - I'm very excited to be able to run models locally, and so hopefully this pull request helps!
### Security hardening
All settings verified working with GPU workloads:
- DynamicUser, PrivateUsers, PrivateTmp, ProtectSystem=strict
- DevicePolicy=closed with GPU-specific DeviceAllow rules
- MemoryDenyWriteExecute, SystemCallFilter, RestrictNamespaces
- UMask=0077, ProtectHome, ProtectKernelTunables
- Security score: **1.4 OK** (systemd-analyze security)
This was tested for the cards listed below, and took quite some time to get correct.
### Example configuration
```nix
services.llama-cpp.instances = {
# Large model on MI50 (32GB VRAM)
mi50 = {
enable = true;
rocmGpuTargets = [ "gfx906" ];
port = 8090;
contextSize = 32768;
flashAttention = "on";
enableMetrics = true;
hfRepo = "unsloth/Qwen3-Coder-30B-A3B-Instruct-GGUF";
environment.ROCR_VISIBLE_DEVICES = "1";
};
# Small model on W7500 (8GB VRAM)
w7500 = {
enable = true;
rocmGpuTargets = [ "gfx1102" ];
port = 8091;
contextSize = 8192;
flashAttention = "on";
enableMetrics = true;
hfRepo = "Qwen/Qwen2.5-3B-Instruct-GGUF";
hfFile = "qwen2.5-3b-instruct-q4_k_m.gguf";
environment.ROCR_VISIBLE_DEVICES = "0";
};
};
```
---
## Testing performed (x86_64-linux)
### Hardware tested
| Machine | GPU | Architecture | VRAM | Backend |
|---------|-----|--------------|------|---------|
| l | AMD MI50 | gfx906 | 32GB | ROCm |
| l | AMD Radeon Pro W7500 | gfx1102 | 8GB | ROCm |
| l2 | NVIDIA RTX 3070 | sm_86 | 8GB | CUDA |
### Test results
| Test | Configuration | Result | Notes |
|------|---------------|--------|-------|
| **Single-instance (ROCm)** | MI50 + W7500, both cards | ✅ PASS | Single instance using both AMD GPUs |
| **Single-instance (CUDA)** | RTX 3070 | ✅ PASS | Single instance, full GPU offload |
| Single GPU (ROCm) | MI50 only, Qwen3-30B | ✅ PASS | Full GPU offload, ~88 tok/s |
| Single GPU (ROCm) | W7500 only, Qwen2.5-3B | ✅ PASS | Full GPU offload, ~62 tok/s |
| Single GPU (CUDA) | RTX 3070, Qwen2.5-3B | ✅ PASS | Full GPU offload, ~150 tok/s |
| Multi-instance (ROCm) | MI50 + W7500 separate instances | ✅ PASS | Separate ports, GPU isolation |
| Mixed architectures | gfx906 + gfx1102 | ✅ PASS | Via ROCR_VISIBLE_DEVICES |
| Security hardening | All settings | ✅ PASS | Score: 1.4 OK |
| Auto gpuLayers | GPU/CPU detection | ✅ PASS | 99 for GPU, 0 for CPU |
| Model caching | CacheDirectory | ✅ PASS | Persists across restarts |
### Systemd security verification
All hardening settings tested and verified compatible with both ROCm and CUDA:
| Setting | Value | GPU Impact | Result |
|---------|-------|------------|--------|
| DynamicUser | true | None | ✅ PASS |
| PrivateDevices | false (GPU) / true (CPU) | Required false for GPU | ✅ PASS |
| DevicePolicy | closed | None | ✅ PASS |
| DeviceAllow | char-drm, char-kfd (ROCm) / char-nvidia* (CUDA) | Required for GPU | ✅ PASS |
| SupplementaryGroups | video, render | Required for GPU access | ✅ PASS |
| MemoryDenyWriteExecute | true | None | ✅ PASS |
| PrivateUsers | true | None | ✅ PASS |
| ProtectSystem | strict | None | ✅ PASS |
| SystemCallFilter | @system-service @resources ~@privileged | @resources needed for GPU | ✅ PASS |
| ProcSubset | all (GPU) / pid (CPU) | Required all for GPU | ✅ PASS |
### Performance results
**AMD W7500 (gfx1102) - Qwen2.5-3B-Instruct:**
```
Prompt processing: 308.8 tokens/sec
Generation: 62.5 tokens/sec
```
**AMD MI50 (gfx906) - Qwen3-Coder-30B:**
```
Prompt processing: ~50 tokens/sec
Generation: ~88 tokens/sec
```
**NVIDIA RTX 3070 - Qwen2.5-3B-Instruct:**
```
Prompt processing: 743 tokens/sec
Generation: 150 tokens/sec
```
---
## Things done
- Built on platform:
- [x] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- Tested, as applicable:
- [x] [NixOS tests] in [nixos/tests].
- [x] [Package tests] at `passthru.tests`.
- [ ] Tests in [lib/tests] or [pkgs/test] for functions and "core" functionality.
- [ ] Ran `nixpkgs-review` on this PR. See [nixpkgs-review usage].
- [x] Tested basic functionality of all binary files, usually in `./result/bin/`.
- Nixpkgs Release Notes
- [x] Package update: when the change is major or breaking.
- NixOS Release Notes
- [ ] Module addition: when adding a new NixOS module.
- [x] Module update: when the change is significant.
- [x] Fits [CONTRIBUTING.md], [pkgs/README.md], [maintainers/README.md] and other READMEs.
[NixOS tests]: https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests
[Package tests]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests
[nixpkgs-review usage]: https://github.com/Mic92/nixpkgs-review#usage
[CONTRIBUTING.md]: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md
[lib/tests]: https://github.com/NixOS/nixpkgs/blob/master/lib/tests
[maintainers/README.md]: https://github.com/NixOS/nixpkgs/blob/master/maintainers/README.md
[nixos/tests]: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests
[pkgs/README.md]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md
[pkgs/test]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/test
---
## Breaking changes
This is a **breaking change** for existing users. The single-instance configuration:
```nix
# Old (no longer works)
services.llama-cpp = {
enable = true;
model = "/path/to/model.gguf";
};
```
Must be migrated to:
```nix
# New
services.llama-cpp.instances.default = {
enable = true;
model = "/path/to/model.gguf";
};
```
Or use the new Hugging Face download feature:
```nix
services.llama-cpp.instances.default = {
enable = true;
hfRepo = "Qwen/Qwen2.5-3B-Instruct-GGUF";
hfFile = "qwen2.5-3b-instruct-q4_k_m.gguf";
};
```
qweered
February 10, 2026, 2:37am
6385
master ← qweered:darwin-aliases-keep-sorted
opened 11:42AM - 26 Oct 25 UTC
## Things done
- Built on platform:
- [ ] x86_64-linux
- [ ] aarch6… 4-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- Tested, as applicable:
- [ ] [NixOS tests] in [nixos/tests].
- [ ] [Package tests] at `passthru.tests`.
- [ ] Tests in [lib/tests] or [pkgs/test] for functions and "core" functionality.
- [ ] Ran `nixpkgs-review` on this PR. See [nixpkgs-review usage].
- [ ] Tested basic functionality of all binary files, usually in `./result/bin/`.
- Nixpkgs Release Notes
- [ ] Package update: when the change is major or breaking.
- NixOS Release Notes
- [ ] Module addition: when adding a new NixOS module.
- [ ] Module update: when the change is significant.
- [x] Fits [CONTRIBUTING.md], [pkgs/README.md], [maintainers/README.md] and other READMEs.
[NixOS tests]: https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests
[Package tests]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests
[nixpkgs-review usage]: https://github.com/Mic92/nixpkgs-review#usage
[CONTRIBUTING.md]: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md
[lib/tests]: https://github.com/NixOS/nixpkgs/blob/master/lib/tests
[maintainers/README.md]: https://github.com/NixOS/nixpkgs/blob/master/maintainers/README.md
[nixos/tests]: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests
[pkgs/README.md]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md
[pkgs/test]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/test
---
Add a :+1: [reaction] to [pull requests you find important].
[reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/
[pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc
need an approove from darwin team
Update for libheif
bundled together with pillow-heif due to breakage.
staging ← kuflierl:libheif-0-21
opened 01:29PM - 23 Jan 26 UTC
supersedes: https://github.com/NixOS/nixpkgs/pull/475138
related to: https://gi… thub.com/bigcat88/pillow_heif/issues/396
## Things done
- Built on platform:
- [x] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- Tested, as applicable:
- [ ] [NixOS tests] in [nixos/tests].
- [x] [Package tests] at `passthru.tests`.
- [ ] Tests in [lib/tests] or [pkgs/test] for functions and "core" functionality.
- [ ] Ran `nixpkgs-review` on this PR. See [nixpkgs-review usage].
- [x] Tested basic functionality of all binary files, usually in `./result/bin/`.
- Nixpkgs Release Notes
- [ ] Package update: when the change is major or breaking.
- NixOS Release Notes
- [ ] Module addition: when adding a new NixOS module.
- [ ] Module update: when the change is significant.
- [x] Fits [CONTRIBUTING.md], [pkgs/README.md], [maintainers/README.md] and other READMEs.
[NixOS tests]: https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests
[Package tests]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests
[nixpkgs-review usage]: https://github.com/Mic92/nixpkgs-review#usage
[CONTRIBUTING.md]: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md
[lib/tests]: https://github.com/NixOS/nixpkgs/blob/master/lib/tests
[maintainers/README.md]: https://github.com/NixOS/nixpkgs/blob/master/maintainers/README.md
[nixos/tests]: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests
[pkgs/README.md]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md
[pkgs/test]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/test