PRs ready for review _

I think the code in https://github.com/NixOS/nixpkgs/pull/144553 has had enough reviews now and could be merged. https://github.com/NixOS/nixpkgs/pull/146183 is just small change.

I made this PR a while ago to make hydra for 21.05 more green. While I don’t personally use that package, I thought it might be nice to get it in regardless. I’m not sure if we’re still accepting PRs for 21.05, otherwise I’ll just close it and forget about it: [21.05 staging] astroid: 2.5.1 -> 2.5.3 by Mindavi · Pull Request #139643 · NixOS/nixpkgs · GitHub

I also have an update for hydra ready, which I’d like to see in nixpkgs: hydra-unstable: 2021-08-11 -> 2021-10-27 by Mindavi · Pull Request #143216 · NixOS/nixpkgs · GitHub

Oh also, openh264 has no maintainer :(, openh264: support cross-compilation by Mindavi · Pull Request #146877 · NixOS/nixpkgs · GitHub

1 Like

Is this an appropriate place to cheerlead for a PR (not mine) that I think is important, if it hasn’t seen any feedback since it was last updated? Or is this mostly about relatively simple stuff that’s easy to review?

If it needs reviews, why not?

I’ve been watching this PR which adds binary executable wrappers to Nixpkgs as an alternative to shell-based executable wrappers. It might seem niche, but it solves a portability problem for wrapped interpreters in Nixpkgs which has existed for several years now and is painful for macOS users. (Maybe @toonn has some interest in tracking or mentioning the progress of this effort as a more minor issue in Nix 🖤 macOS Monthly ?)

Reviewers will need to know something about C, and activity today indicates that the author (@bergkvist) is still actively investigating new ways to ensure the implementation is robust and safe. But I just wanted to kinda boost its visibility and try to ensure that the PR author knows that his diligence is appreciated and that the feature that he’s working on is valued, because it seems like a tough PR to review and like he’s put quite some effort into it over the course of a few months now. I want him to feel visible and appreciated as he keeps at it.

4 Likes

Been working on this since May & I think I’ve finally tested everything there is to test and ran out of things to add while waiting for a review.

shows rather nice system diagnostic information… now in glorious colour, believe it or not.

1 Like

Caprine is a third-party Facebook Messenger client, and this is the binary package for appimage-x86_64 and dmg-x86_64.

I have personally been using it (the Appimage one) for moths, and I think it’s ready to get merged. There’s also a package request about Caprine.

backport from unstable to 21.11 i think this could even back ported to 21.05 too

A performance improvement for python-protobuf by fixing the C++ backend: python.pkgs.protobuf: Fix cpp backend by knedlsepp · Pull Request #147016 · NixOS/nixpkgs · GitHub

Hosted by Flying Circus.