I’m not a frequent contributor to nixpkgs and I don’t spend a lot of time on discourse. Thus, when I submit a PR for nixpkgs, I’m always puzzled what should I do. Over time, I noticed there is more automation, so sometimes maintainers are automatically pinged to review the PR. However, I couldn’t find any document that explains the process nixpkgs uses for contributions. There is nixpkgs/CONTRIBUTING.md at 25faee19ff201bdb92c2e23d3b7e0ad1c4c3e883 · NixOS/nixpkgs · GitHub, but it only talks about formatting of the PR and commits, not how we go from submitting something to having that PR becoming part of nixpkgs.
The reason I started writing this post is because I have this PR: refurb: init at 1.5.0 by knl · Pull Request #193309 · NixOS/nixpkgs · GitHub – it got reviewed/approved by two reviewers*, but I don’t know what should happen next, who’s responsible for merging it? I can’t, since I don’t have write access. Should I ping the reviewers again? Do they have the write access?
- Another thing that was not clear from the labels is how many reviewers are needed for the PR? Nothing is written neither in the PR template text nor CONTRIBUTING.md file.