PRs in distress

Development
73

Anyone knows what to do when the git repo doesn’t have any tags, and we want to build from source?

https://github.com/NixOS/nixpkgs/pull/249553#discussion_r1322253005

74

Haven’t looked at the PR, but in general, the fact there are no Git tags should have no effect on the decision whether to build from source or not. In general, building from source is preferred, with or without Git tags.

In case Git tags are missing, but there are version strings staggered in the source, it’d be nice to ping upstream about it, and use an explicit git revision in the meantime. Put a good comment near where the commit hash revision is used (instead of a rev = version or alike). Use the revision that marked the bump of the version string in the source.

3 Likes
75

https://github.com/NixOS/nixpkgs/pull/249553

1 Like
76

Hi I’ve had this package approved and ready to merge for a while now is there anything left to do? terraform-plugin-docs: init at v0.16.0 by catouc · Pull Request #249387 · NixOS/nixpkgs · GitHub

Thanks in advance!

2 Likes
77

https://github.com/NixOS/nixpkgs/pull/203020
This PR seemed almost complete and then was shutdown can anyone take the mantle of fixing it, I can maintain it afterward!

78

@nyanbinary this PR is not “in distress”. The author simply lost interest in pursuing it.

79

https://github.com/NixOS/nixpkgs/pull/264454
Stuck in how to move forward on this PR so far, just got it to compile.

80

It would be nice for NixOS 23.11 to have working user lingering.
https://github.com/NixOS/nixpkgs/pull/261319

81

This PR was approved in July, but is still waiting for somebody to merge it:

https://github.com/NixOS/nixpkgs/pull/240179

I don’t know whether the problem is that ofborg has gone awol without finishing the checks:

“Started 3m 28d 4h 50m 7s ago”

I believe that particular check would have passed if ofborg had run it at the time. If rerun now, it will probably fail, since something recently broke libpostal on macOS. Hopefully, that’s fixed by libpostal: fix on darwin by Thra11 · Pull Request #269292 · NixOS/nixpkgs · GitHub, but since I don’t believe that that failure is in any way related to the original PR, I’d rather keep things simple and merge the original PR first and then apply the darwin fix on top of it.

1 Like
82

An RFC42 PR waiting to be merged
https://github.com/NixOS/nixpkgs/pull/253428

83

I’m new to contributing to NixOS, may I know what are the next steps to get reviewers to this PR →

I don’t see an option to attach reviewers etc.

What would be a normal ETA for such things?

Thank you

84

@siddarthkay , there is PRs ready for review _ that seems more adequate to start with.

1 Like
85

I need Darwin gurus to fix the issues in this package:

Also, I would like some Darwin user to share maintainership, but not urgent.

86

I need Darwin gurus to take a look at this PR pls, its a macOS only package and it has 2 approvals.
Looking for next steps to merge.

Thank you.!

87

Hey, can we get the “shiny” python library merged? (and shinywidgets and htmltools)

There is an (now outdated) PR here: python310Packages.{shiny, rsconnect_*} by nviets · Pull Request #231189 · NixOS/nixpkgs · GitHub

88

Any help to get these merged would be greatly appreciated:

89

Reminder that this thread is for PRs that have you stumped and need input to get unstuck.
If what you’re requesting is a review/merge, then please at least first post a couple of times in PRs ready for review _

90

Likely should’ve posted here in the first place, but created a separate help request at: Help with packaging complex Rust library

Basically looking for someone with more familiarity with packaging Rust libraries to help me out.

91

What’s the best way to deal with an upstream which reissues tarballs that have different hashes?

92

Maybe using raw rev hash?