I recently did a PR for Softmaker’s FreeOffice. There was a review with useful feedback that I addressed. But then nothing happened:
https://github.com/NixOS/nixpkgs/pull/67105
I have closed the PR, because it turned out to be easy to make a single generic derivation for both FreeOffice and SoftMaker Office, which I submitted in the following PR:
https://github.com/NixOS/nixpkgs/pull/67775
It would be nice to get a review of this PR. It would be extra nice if we had FreeOffice in 19.09
I’ve packaged the system-syzygy game, and it made 20 day it hasn’t receved a suggestion or got merged.https://github.com/NixOS/nixpkgs/pull/67353
NioBium
September 15, 2019, 6:44am
56
This is great, thank you for doing this. Hope it gets reviewed soon.
This PR sets a couple of kernel options to allow applications to see more power information on some machines. Concretely, it lets s-tui show power information, which is nice.
I’m not 100% sure what I’m doing with kernel options, but this mirrors what Arch does and seems to work!
1 Like
ckampka
September 25, 2019, 11:17am
58
https://github.com/NixOS/nixpkgs/pull/69088
I have reviewed this pr and think it is pretty much ready for merge. Would be good to get a second pair of eyes on it
Xcode 11 is out so I’d really like to get the macvim Xcode 11 compatibility fix merged. I’ve been running it locally with no problems.
~~https://github.com/NixOS/nixpkgs/pull/68534~~
Thra11
September 27, 2019, 3:32pm
61
I’d appreciate if somebody could review this PR which packages the KDE configuration module for configuring wacom graphics tablets, (although I realise that exhaustively testing it requires a wacom tablet). @tilpner has already pointed out a few issues, which I’ve fixed, so I’m hoping that it might be ready now.https://github.com/NixOS/nixpkgs/pull/68836
b42
September 28, 2019, 6:13pm
62
Two new NixOS modules.https://github.com/NixOS/nixpkgs/pull/65397
MoinMoin, a wiki engine:https://github.com/NixOS/nixpkgs/pull/68327
Especially interested in feedback from people who run these services if there are any!
Updates of two spaCy dependencies:
NixOS:master ← danieldk:blis-thinc-update
opened 06:32PM - 29 Aug 19 UTC
###### Motivation for this change
Update the blis and thinc dependencies of s… paCy. Tested using the `en_core_web_sm` model
###### Things done
- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
- Built on platform(s)
- [x] NixOS
- [ ] macOS
- [ ] other Linux distributions
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
- [x] Tested execution of all binary files (usually in `./result/bin/`)
- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
- [ ] Ensured that relevant documentation is up to date
- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).
###### Notify maintainers
cc @
Basically version + hash bumps, plus the necessary version constraint relaxations necessary in spaCy itself.
I would like an additional review on this one, just to be safe:
NixOS:master ← Lassulus:loopback
opened 03:26PM - 21 Sep 19 UTC
###### Motivation for this change
this feature was requested here: https://gi… thub.com/NixOS/nixpkgs/issues/67627
###### Things done
- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
- Built on platform(s)
- [ ] NixOS
- [ ] macOS
- [ ] other Linux distributions
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
- [ ] Tested execution of all binary files (usually in `./result/bin/`)
- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
- [ ] Ensured that relevant documentation is up to date
- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).
###### Notify maintainers
cc @
smaret
October 6, 2019, 7:29pm
65
Can someone have a look at this PR please? It’s a simple update of one of the packages I maintain.
NixOS:master ← smaret:gildas-20191001_a
opened 08:58AM - 01 Oct 19 UTC
###### Motivation for this change
Update gildas to the latest usptream.
##… #### Things done
- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
- Built on platform(s)
- [ ] NixOS
- [x] macOS
- [x] other Linux distributions
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
- [x] Tested execution of all binary files (usually in `./result/bin/`)
- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
- [ ] Ensured that relevant documentation is up to date
- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).
moaxcp
October 7, 2019, 10:47am
66
Hello, I add two new packages
https://github.com/NixOS/nixpkgs/pull/70282
NixOS:master ← moaxcp:asciidoctorj
opened 10:09AM - 07 Oct 19 UTC
###### Motivation for this change
Add asciidoctorj package
###### Things d… one
- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
- Built on platform(s)
- [x] NixOS
- [ ] macOS
- [ ] other Linux distributions
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
- [x] Tested execution of all binary files (usually in `./result/bin/`)
- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
- [ ] Ensured that relevant documentation is up to date
- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).
###### Notify maintainers
cc @
If you put the links on their own line then discourse will make them look nicer
I’m looking for any httpd users on NixOS to compare their httpd.conf file generated by this PR to what is currently generated by NixOS. I would also appreciate any review of the nix code in this PR as the httpd module code is overly complicated - a second and third pair of eyes looking at the changes in depth would be appreciated, even by people who aren’t familiar with httpd but have strong nix lang skills.
NixOS:master ← aanderse:httpd
opened 01:49AM - 13 Oct 19 UTC
###### Motivation for this change
Cleaning up the `httpd` module.
I would ap… preciate the efforts of any `httpd` users who would run their configuration through this branch, compare the generated `httpd.conf` to their own, and then share the results.
###### Things done
I have compared several `httpd` configuration files generated by this new build compared to what `19.09` builds and they are pretty much identical.
- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
- Built on platform(s)
- [x] NixOS
- [ ] macOS
- [ ] other Linux distributions
- [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
- [ ] Tested execution of all binary files (usually in `./result/bin/`)
- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
- [x] Ensured that relevant documentation is up to date
- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).
###### Notify maintainers
cc @
I’ve had a PR open for 2.5 months that rewrites stripHash
https://github.com/NixOS/nixpkgs/pull/66161
This fixes a bug wherein stripHash --foo doesn’t treat --foo as a filename, and also massively improves performance in the process. The only problem is I’m not willing to rebuild the world on my machine, so I haven’t built any packages with this change, only tested in isolation on all inputs I can think of. It is targeting staging though.
2 Likes
asbachb
October 20, 2019, 10:54pm
70
bbigras
October 30, 2019, 4:47pm
72
Not my PR. I reviewed it but the 2 maintainers don’t seem to have the time right now and we could use some extra pairs of eyes and someone to merge it.
~~https://github.com/NixOS/nixpkgs/pull/69962~~
I’ve got a MacVim update
~~https://github.com/NixOS/nixpkgs/pull/71380~~
This has been sitting around for almost 2 weeks, long enough that I’ve actually just updated it for yet another MacVim version.
1 Like
.