bbigras
March 23, 2020, 11:31pm
134
Zenith - sort of like top or htop but with zoom-able charts, network, and disk usage
~~https://github.com/NixOS/nixpkgs/pull/83183~~
NixOS:master
← lilyball:psc-package
opened 09:42PM - 19 Mar 20 UTC
###### Motivation for this change
The current `psc-package` doesn't compile any… more, both becasue it's not compatible with GHC 8.8 and because the version of `base-compat` in `haskellPackages` is newer than what it supports.
The new approach just downloads a prebuilt binary and patches the linker paths. This means we're using the official supported compiler so we match other installations of `psc-package`, at the downside of fewer supported platforms. This was the recommended approach from https://github.com/purescript/psc-package/issues/165.
###### Things done
- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS linux)
- Built on platform(s)
- [x] NixOS (with sandbox)
- [X] macOS (without sandbox)
- [ ] other Linux distributions
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"`
- [X] Tested execution of all binary files (usually in `./result/bin/`)
- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
- [X] Ensured that relevant documentation is up to date
- [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).
I tested one package that depends on this (`nodePackages.insect`). I don't anticipate any issues with dependent packages as this is the same version of `psc-package` as before, so it should behave the same.
CC @Profpatsch
psc-package
won’t build anymore using haskellPackages
, which breaks insect
at least.
Sound card didn’t work correctly on the desktop after switching to nixos, enable the necessary config option:
NixOS:staging
← Emantor:topic/kernel-snd-ca0132
opened 08:17AM - 29 Mar 20 UTC
###### Motivation for this change
Since we select everything as a module, snd_h… da_codec_ca0132 is built as
well. DSP loading is not enabled by default, but without it the
soundcard produces timeouts within ALSA and does not emit sound.
Explicitly enable the firmware loading to ensure Soundblaster
Z/Zx/ZxR/Recon devices can be used with NixOS.
###### Things done
- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS linux)
- Built on platform(s)
- [x] NixOS
- [ ] macOS
- [ ] other Linux distributions
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"`
- [ ] Tested execution of all binary files (usually in `./result/bin/`)
- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
- [ ] Ensured that relevant documentation is up to date
- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).
May I have some eyes on my PR? It’s about 3 weeks old at this point.
NixOS:master
← OmnipotentEntity:katago-init
opened 12:15AM - 09 Mar 20 UTC
###### Motivation for this change
Katago is the current strongest open source… go AI engine. This derivation provides both the OpenCL (default) and CUDA versions of the engine.
###### Things done
- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS linux)
- Built on platform(s)
- [x] NixOS
- [ ] macOS
- [ ] other Linux distributions
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"`
- [x] Tested execution of all binary files (usually in `./result/bin/`)
- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
- [ ] Ensured that relevant documentation is up to date
- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).
Here is my PR to update a 3ds emulator (9 days since posted):
NixOS:master
← marius851000:citra
opened 09:02AM - 30 Mar 20 UTC
###### Motivation for this change
A recent update to citra added some interesin… g functionallity for rom-hacking (dynamic patch to the game file system)
###### Things done
- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS linux)
- Built on platform(s)
- [x] NixOS
- [ ] macOS
- [ ] other Linux distributions
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"`
- [x] Tested execution of all binary files (usually in `./result/bin/`)
- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
- [ ] Ensured that relevant documentation is up to date
- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).
Checked it work with some game and homebrew, including testing the specific part I need.
It’s been a couple of weeks since anyone looked at this PR, it could really use a review
https://github.com/NixOS/nixpkgs/pull/83630
This PR has been reviewed and it has been out there for a while!
https://github.com/NixOS/nixpkgs/pull/84535
Thanks guys!
das-g
April 18, 2020, 10:02am
141
If it has been reviewed, it probably belongs in
Introduction
In the spirit of PRs ready for review I’d like to start another experiment. I know (or hope) that many people would like to get more involved and help resolve nixpkgs’s “PR crisis”, with 1,327 currently open pull requests (1,041 without any review). We recently started encouraging people to review PRs in the pull request template . Reviewing can be a bit frustrating for people without commit access however, since they do not have the means to actually act on their review or attrac…
das-g
April 18, 2020, 1:35pm
142
Opened two weeks ago:
~~https://github.com/NixOS/nixpkgs/pull/84330~~ [Edit 2020-04-22: Has been approved now. ]
First step to make that shell usable as a login shell on NixOS.
Related forum thread:
On a NixOS 19.09 system, I’d like to try xonsh (NixOS 19.09 package ) as my login shell. Towards that end, I tried the following:
In /etc/nixos/configuration.nix, I addedprograms.xonsh.enable = true;
to whitelist xonsh as a login shell.
Also in /etc/nixos/configuration.nix, I changed the entry for my user fromusers.extraUsers.das-g = {
isNormalUser = true;
description = "Raphael Das Gupta";
extraGroups = ["wheel" "networkmanager" "lp" "docker" "dialout" "vboxusers"];
uid = 1000;
};
tou…
I have got this one! Which is a browser. It got reviewed and the changes were approuved!
https://github.com/NixOS/nixpkgs/pull/85469#pullrequestreview-395879442
Thank you guys!
NOTE: I will be adding the backports to this post later today
bbigras
April 22, 2020, 12:01am
145
I’ve got an update to macvim
that needs review. This update is a little special in that the current macvim
derivation is broken as of Xcode 11.4 so it needs to restore compatibility in addition to the normal version update.
https://github.com/NixOS/nixpkgs/pull/85321
c00w
April 26, 2020, 12:17am
147
I’ve got an update that needs review / merging, lots (4) people have looked at it and multiple have signed off, but I think so far no one has signed off who can merge it.
https://github.com/NixOS/nixpkgs/pull/83253
For anyone that likes minimal window managers, here are two packages that will add to Nixpkgs bevy of cool window managers:
https://github.com/NixOS/nixpkgs/pull/85495
https://github.com/NixOS/nixpkgs/pull/85174
Can someone review please
This is done and waiting for review, should be an easy one.
https://github.com/NixOS/nixpkgs/pull/85028