PRs ready for review _

boppyt · July 17, 2021, 11:56am

https://github.com/NixOS/nixpkgs/pull/130308

bobby285271 · July 22, 2021, 2:55am

Please help test the Pantheon 6 upgrade (detailed instructions provided) if you are interested in that.

https://github.com/NixOS/nixpkgs/pull/130380

blaggacao · July 28, 2021, 1:58am

https://github.com/NixOS/nixpkgs/pull/131760

blaggacao · July 28, 2021, 1:59am

https://github.com/NixOS/nixpkgs/pull/131754

blaggacao · July 28, 2021, 1:59am

https://github.com/NixOS/nixpkgs/pull/131267

SrTobi · July 28, 2021, 6:43am

Hi, my first pr… I’m not sure what there is to do or what it stops from being merged… it just makes a normal grub feature available for nixos
(now with correct pr link)
https://github.com/NixOS/nixpkgs/pull/109302

misuzu · August 2, 2021, 9:43am

https://github.com/NixOS/nixpkgs/pull/121693
https://github.com/NixOS/nixpkgs/pull/131078

pasqui23 · August 7, 2021, 6:38pm

Still languishing in limbo
https://github.com/NixOS/nixpkgs/pull/73106

pasqui23 · August 14, 2021, 10:30am

Other ready
https://github.com/NixOS/nixpkgs/pull/74085#issuecomment-898758834
https://github.com/NixOS/nixpkgs/pull/84115#issuecomment-898758840

cab · August 15, 2021, 1:26pm

github.com/NixOS/nixpkgs

nixos.system.boot.kernel: stronger constraints for kernelParam type

NixOS:master ← cab404:kernel-params-checking

opened 02:40PM - 12 Aug 21 UTC

cab404

+4 -1

Checks whether all spaces are inside double quotes, thus ensuring that one stri…ng parses as no more than one kernel param.  ###### Motivation for this change Users often add spaces in expressions like "a = 12", and having them parsed as 3 separate params is not user friendly. ###### Things done kernelParams type changed to a string match. - [X] Tested using sandboxing ([nix.useSandbox](https://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](https://nixos.org/nix/manual/#sec-conf-file) on non-NixOS linux) - Built on platform(s) - [X] NixOS - [ ] macOS - [ ] other Linux distributions - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [x] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [x] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

pennae · August 19, 2021, 9:00am

https://github.com/NixOS/nixpkgs/pull/133486

netforceexplorer · August 19, 2021, 3:08pm

Hi,

this is my first pull request and I would need some help. Especially how to use $out in configureFlags list. These are not evaluated and I set the flag needing $out in preConfigure. Can you confirm, that this is the problem stopping the merging process?

https://github.com/NixOS/nixpkgs/pull/134067

spacegreg · August 20, 2021, 9:29am

github.com/NixOS/nixpkgs

python3Packages.gudhi: init + several dependencies

NixOS:master ← yl3dy:gudhi

opened 07:25PM - 11 Aug 21 UTC

yl3dy

+344 -0

###### Motivation for this change Packages init'ed here are useful for Topolo…gical Data Analysis. POT and pymanopt are optional runtime dependencies, but are required for Wasserstein distance calculation. ###### Things done - [x] Tested using sandboxing ([nix.useSandbox](https://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](https://nixos.org/nix/manual/#sec-conf-file) on non-NixOS linux) - Built on platform(s) - [x] NixOS - [ ] macOS - [ ] other Linux distributions - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [x] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [ ] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

xwvvvvwx · August 26, 2021, 11:55am

Includes a critical security patch, would be great to merge asap:

github.com/NixOS/nixpkgs

Erigon 2021-08-04

NixOS:master ← d-xo:erigon-2021-08-04

opened 08:29AM - 24 Aug 21 UTC

d-xo

+15 -4

###### Motivation for this change new version (including a critical security fix): https://github.com/ledgerwatch/erigon/releases/tag/v2021.08.04 Supersedes https://github.com/NixOS/nixpkgs/pull/135135. ###### Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [x] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [x] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

nomeata · August 27, 2021, 11:54am

Just a simple backport of a new package that I’d like to install locally without patching or so:

boppyt · August 30, 2021, 5:34am

Was messy at start, now we’re good to go!

github.com/NixOS/nixpkgs

lite-xl: init at 2.0.1

NixOS:master ← sefidel:lite-xl

opened 11:45AM - 29 Aug 21 UTC

sefidel

+97 -4

###### Motivation for this change Fixes #136015. ###### Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [x] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

samuela · August 30, 2021, 3:15pm

github.com/NixOS/nixpkgs

jax: init at 0.2.19, jaxlib: init at 0.1.71

NixOS:master ← samuela:samuela/jax

opened 10:24PM - 19 Aug 21 UTC

samuela

+139 -0

###### Motivation for this change Packaging of the JAX (https://github.com/google/jax) library. JAX is a modern framework for differentiable programming. The `jax` package uses `jaxlib` as it's "backend". Currently only the CPU backend running on x86_64-linux is packaged. TODO, unfinished items left to future PRs: - [x] Fix `jnp.array([1, 2, 3])`. - [x] Run the jax test suite. - [x] GPU backend support - [ ] TPU backend support - [ ] Fix the build on macOS. Currently segfaults when running the test suite. Useful resources: * https://jax.readthedocs.io/en/latest/developer.html#running-the-tests * https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md ###### Things done Created derivations for the jax and jaxlib python packages. - [ ] Tested using sandboxing ([nix.useSandbox](https://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](https://nixos.org/nix/manual/#sec-conf-file) on non-NixOS linux) - Built on platform(s) - [x] NixOS - [x] macOS - [ ] other Linux distributions - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [x] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

Ma27 · August 31, 2021, 11:23am

I could use someone to proof-read nixos/nextcloud: add some notes for `Error: Command "upgrade" is not defined.` by Ma27 · Pull Request #135958 · NixOS/nixpkgs · GitHub

samuela · September 9, 2021, 7:16am

I’ve got a few that should be ready to go!

https://github.com/NixOS/nixpkgs/pull/137069
cudatoolkit_11_{3,4}: init at 11.{3,4}.1 by samuela · Pull Request #136655 · NixOS/nixpkgs · GitHub
jax: init at 0.2.19, jaxlib: init at 0.1.71 by samuela · Pull Request #134894 · NixOS/nixpkgs · GitHub

julm · September 10, 2021, 3:08pm

riseup-vpn / calyx-vpn : bitmask-vpn: init at 0.21.6 by ju1m · Pull Request #137247 · NixOS/nixpkgs · GitHub
sourcehut : nixos/sourcehut: updates, fixes, hardening by ju1m · Pull Request #133984 · NixOS/nixpkgs · GitHub
public-inbox : Update public-inbox to 1.8.0 and add systemd services by ju1m · Pull Request #104457 · NixOS/nixpkgs · GitHub
transmission : transmission: use freeformType on settings and various fixes by ju1m · Pull Request #96655 · NixOS/nixpkgs · GitHub
pipe-viewer : pipe-viewer: init at 0.1.4 by ju1m · Pull Request #136119 · NixOS/nixpkgs · GitHub
openvpn / netns : nixos/openvpn: add network namespace support by ju1m · Pull Request #109643 · NixOS/nixpkgs · GitHub