boppyt
August 30, 2021, 5:34am
581
Was messy at start, now we’re good to go!
NixOS:master ← sefidel:lite-xl
opened 11:45AM - 29 Aug 21 UTC
<!--
To help with the large amounts of pull requests, we would appreciate your
…
reviews of other pull requests, especially simple package updates. Just leave a
comment describing what you have tested in the relevant package/service.
Reviewing helps to reduce the average time-to-merge for everyone.
Thanks a lot if you do!
List of open PRs: https://github.com/NixOS/nixpkgs/pulls
Reviewing guidelines: https://nixos.org/manual/nixpkgs/unstable/#chap-reviewing-contributions
-->
###### Motivation for this change
Fixes #136015.
###### Things done
- Built on platform(s)
- [x] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file))
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"`
- [x] Tested execution of all binary files (usually in `./result/bin/`)
- [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes)
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [ ] (Module updates) Added a release notes entry if the change is significant
- [ ] (Module addition) Added a release notes entry if adding a new NixOS module
- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).
Ma27
August 31, 2021, 11:23am
583
samuela
September 9, 2021, 7:16am
584
I’ve got a few that should be ready to go!
@julm I’m out for the weekend with zero technology, but I’ll take a look at these when I have a chance thereafter. (especially the sourcehut, thanks!)
1 Like
bbigras
September 10, 2021, 3:45pm
587
Package looking for review (module has already been reviewed and approved):
NixOS:master ← jdreaver:prowlarr
opened 03:23PM - 28 Aug 21 UTC
<!--
To help with the large amounts of pull requests, we would appreciate your
…
reviews of other pull requests, especially simple package updates. Just leave a
comment describing what you have tested in the relevant package/service.
Reviewing helps to reduce the average time-to-merge for everyone.
Thanks a lot if you do!
List of open PRs: https://github.com/NixOS/nixpkgs/pulls
Reviewing guidelines: https://nixos.org/manual/nixpkgs/unstable/#chap-reviewing-contributions
-->
###### Motivation for this change
https://github.com/NixOS/nixpkgs/issues/135887
This PR adds a new package and NixOS service for [Prowlarr](https://wiki.servarr.com/prowlarr). This is an indexer similar to `jackett` (which is already in nixpkgs), but is newer and more well-integrated with the *arr ecosystem (e.g. `radarr` and `sonarr`, which are also already in `nixpkgs`).
I mostly copied the config from `radarr` and fixed the `prowlarr`-specific bits. In particular, the `update.sh` script had to be modified because the releases are not official releases yet, so we have to specify the version we want to use.
**This is my first significant `nixpkgs` PR.** I've updated the versions of packages before, but I've never added a new service from scratch. I would think anyone who is a maintainer for `radarr` could/should review this. I'm also happy to add myself as a maintainer for this package, but I'm not sure what the protocol on that is.
I used this `nixpkgs` fork and enabled `prowlarr` in my home server's NixOS config, and it worked flawlessly, so this has basically been tested end-to-end.
###### Things done
- Built on platform(s)
- [x] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file))
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [x] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"`
- [x] Tested execution of all binary files (usually in `./result/bin/`)
- [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes)
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [ ] (Module updates) Added a release notes entry if the change is significant
- [x] (Module addition) Added a release notes entry if adding a new NixOS module
- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).
zakame
September 14, 2021, 2:48pm
592
Hi, I’m looking for reviews for
NixOS:master ← zakame:contrib/ruby-taoup
opened 05:45AM - 05 Sep 21 UTC
###### Motivation for this change
https://github.com/globalcitizen/taoup is a… `fortune`-like tool that tells some words of wisdom from _The Art of Unix Programming_ and other sources.
Some patches are included to simplify the `taoup-fortune` example script (which tries to produce a cache directory at first run - we instead create and populate this at build time,) and `taoup` itself (which tries to test for `tput` - avoid that and just depend on `ncurses` to provide that instead.)
I suspect some improvements can be made still at the `postPatch` and `installPhase` steps - I'd love to hear anyone's guidance on this :pray: Thanks!
###### Things done
- Built on platform(s)
- [X] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [x] aarch64-darwin
- [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file))
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [X] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"`
- [X] Tested execution of all binary files (usually in `./result/bin/`)
- [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes)
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [ ] (Module updates) Added a release notes entry if the change is significant
- [ ] (Module addition) Added a release notes entry if adding a new NixOS module
- [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).
thanks!
roberth
September 16, 2021, 5:34pm
593
Test automation for fetchers!
They used to be tricky to hack on because they don’t re-run after completing once. With this technique, we can have tests as usual.
NixOS:master ← hercules-ci:fetcher-testing
opened 08:34AM - 28 Aug 21 UTC
###### Motivation for this change
Make maintenance easier on the fetchers and… avoid problems.
The `packageTests` attribute will serve two purposes:
- for ofborg: allow it to build tests in a __functor attrset like `fetchgit`
- for hydra, potentially, build the package tests. Enabling these is not part of this PR.
Closes #133739
Refs #128749 #135881 or really all of [topic: fetch](https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+is%3Aopen++label%3A%226.topic%3A+fetch%22+)
###### Things done
- Built on platform(s)
- [x] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file))
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"`
- [ ] Tested execution of all binary files (usually in `./result/bin/`)
- [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes)
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [ ] (Module updates) Added a release notes entry if the change is significant
- [ ] (Module addition) Added a release notes entry if adding a new NixOS module
- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).
nappa
September 16, 2021, 9:09pm
594
Can someone take a look at this, that has been ignored for a couple of weeks (maintainer is not responding, and the same happened with #134390 , but that one was merged).
It should be merged, because the complicated license doesn’t allow free distribution of that code.
I can take over maintenance, since I’ve put a lot of work to fix the package (including merged #134390 and #134393 , and my upcoming PRs).
NixOS:master ← smancill:shogun-remove-svmlight
opened 12:11AM - 03 Sep 21 UTC
###### Motivation for this change
Shogun is using non-distributable SVMLight … code that should be removed from the package.
SVMLight uses a [non-standard license](https://github.com/shogun-toolbox/shogun/blob/shogun_6.1.4/doc/license/LICENSE_SVMlight.md) that doesn't allow distribution without the author's permission:
> The software must not be modified and distributed without prior permission of the author.
----
I am working on a PR to fix Shogun on Darwin and add it as a Python module, and that's why I found that currently it is built with SVMLight, which should not be packaged on a distribution. Upstream's own Debian package, Fedora, Conda, they all remove it.
I think this had to be its own PR, and maybe backported to 21.05.
###### Things done
Remove all SVMLight code when building the binary package.
Use upstream's own script to do it (which they use to create and distribute their own Debian package), with a few fixes (see added patch file).
- Built on platform(s)
- [X] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin (currently broken on Darwin, I will send the fix in a new PR)
- [ ] aarch64-darwin
- [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file))
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"`
- [ ] Tested execution of all binary files (usually in `./result/bin/`)
- [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes)
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [ ] (Module updates) Added a release notes entry if the change is significant
- [ ] (Module addition) Added a release notes entry if adding a new NixOS module
- [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).
Can someone review these PRs open for a couple of weeks?
NixOS:master ← j0hax:octolapse
opened 09:56PM - 02 Sep 21 UTC
<!--
To help with the large amounts of pull requests, we would appreciate your
…
reviews of other pull requests, especially simple package updates. Just leave a
comment describing what you have tested in the relevant package/service.
Reviewing helps to reduce the average time-to-merge for everyone.
Thanks a lot if you do!
List of open PRs: https://github.com/NixOS/nixpkgs/pulls
Reviewing guidelines: https://nixos.org/manual/nixpkgs/unstable/#chap-reviewing-contributions
-->
###### Motivation for this change
Package the popular Octolapse plugin along with an additional python dependency
###### Things done
- Built on platform(s)
- [x] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file))
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"`
- [x] Tested execution of all binary files (usually in `./result/bin/`)
- [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes)
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [ ] (Module updates) Added a release notes entry if the change is significant
- [ ] (Module addition) Added a release notes entry if adding a new NixOS module
- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).
NixOS:master ← illustris:octoprint
opened 04:23AM - 01 Sep 21 UTC
<!--
To help with the large amounts of pull requests, we would appreciate your
…
reviews of other pull requests, especially simple package updates. Just leave a
comment describing what you have tested in the relevant package/service.
Reviewing helps to reduce the average time-to-merge for everyone.
Thanks a lot if you do!
List of open PRs: https://github.com/NixOS/nixpkgs/pulls
Reviewing guidelines: https://nixos.org/manual/nixpkgs/unstable/#chap-reviewing-contributions
-->
###### Motivation for this change
- using octoprint with certain Creality printers requires the temperature reporting fix plugin
- octolapse is a popular plugin for octoprint
###### Things done
- Built on platform(s)
- [x] x86_64-linux
- [x] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file))
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [x] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"`
- [x] Tested execution of all binary files (usually in `./result/bin/`)
- [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes)
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [ ] (Module updates) Added a release notes entry if the change is significant
- [ ] (Module addition) Added a release notes entry if adding a new NixOS module
- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).
jasper
September 25, 2021, 10:59am
596
This change of the resilio-sync module has been sitting for a couple of months. It introduces the option of managing resilio sync secrets using secret files, so those secrets don’t need to end up in the nix store. I’d super appreciate a review!
NixOS:master ← jwoudenberg:master
opened 02:46PM - 05 Jun 21 UTC
###### Motivation for this change
The Resilio nixos module supports declarati… vely configuring Resilio using the `sharedFolders` attribute. Secrets for shared folders can be passed using the `secret` attribute, with the downside that these secrets will end up in the nix store.
The goal of this change is to allow shared folder secrets to be specified without requiring they be put in the nix store, without breaking backwards compatibility with existing Resilio module configurations. It follows the approach outlined in the issue below, for upstream packages that do not provide password file support out of the box:
https://github.com/NixOS/nixpkgs/issues/24288
The change also modifies documentation to encourage the use of the new secret file support, because it seems like the safer default to me, but I don't feel strongly about that and am happy to change that back.
###### Things done
- [x] Tested using sandboxing ([nix.useSandbox](https://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](https://nixos.org/nix/manual/#sec-conf-file) on non-NixOS linux)
- Built on platform(s)
- [x] NixOS
- [ ] macOS
- [ ] other Linux distributions
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"`
- [x] Tested execution of all binary files (usually in `./result/bin/`)
- [21.11 Release Notes](./CONTRIBUTING.md#generating-2111-release-notes)
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [x] (Module updates) Added a release notes entry if the change is significant
- [ ] (Module addition) Added a release notes entry if adding a new NixOS module
- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).
