PRs ready for review _

netforceexplorer · August 19, 2021, 3:08pm

Hi,

this is my first pull request and I would need some help. Especially how to use $out in configureFlags list. These are not evaluated and I set the flag needing $out in preConfigure. Can you confirm, that this is the problem stopping the merging process?

https://github.com/NixOS/nixpkgs/pull/134067

spacegreg · August 20, 2021, 9:29am

github.com/NixOS/nixpkgs

python3Packages.gudhi: init + several dependencies

NixOS:master ← yl3dy:gudhi

opened 07:25PM - 11 Aug 21 UTC

yl3dy

+344 -0

###### Motivation for this change Packages init'ed here are useful for Topolo…gical Data Analysis. POT and pymanopt are optional runtime dependencies, but are required for Wasserstein distance calculation. ###### Things done - [x] Tested using sandboxing ([nix.useSandbox](https://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](https://nixos.org/nix/manual/#sec-conf-file) on non-NixOS linux) - Built on platform(s) - [x] NixOS - [ ] macOS - [ ] other Linux distributions - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [x] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [ ] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

xwvvvvwx · August 26, 2021, 11:55am

Includes a critical security patch, would be great to merge asap:

github.com/NixOS/nixpkgs

Erigon 2021-08-04

NixOS:master ← d-xo:erigon-2021-08-04

opened 08:29AM - 24 Aug 21 UTC

d-xo

+15 -4

###### Motivation for this change new version (including a critical security fix): https://github.com/ledgerwatch/erigon/releases/tag/v2021.08.04 Supersedes https://github.com/NixOS/nixpkgs/pull/135135. ###### Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [x] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [x] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

nomeata · August 27, 2021, 11:54am

Just a simple backport of a new package that I’d like to install locally without patching or so:

boppyt · August 30, 2021, 5:34am

Was messy at start, now we’re good to go!

github.com/NixOS/nixpkgs

lite-xl: init at 2.0.1

NixOS:master ← sefidel:lite-xl

opened 11:45AM - 29 Aug 21 UTC

sefidel

+97 -4

###### Motivation for this change Fixes #136015. ###### Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [x] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

samuela · August 30, 2021, 3:15pm

github.com/NixOS/nixpkgs

jax: init at 0.2.19, jaxlib: init at 0.1.71

NixOS:master ← samuela:samuela/jax

opened 10:24PM - 19 Aug 21 UTC

samuela

+139 -0

###### Motivation for this change Packaging of the JAX (https://github.com/google/jax) library. JAX is a modern framework for differentiable programming. The `jax` package uses `jaxlib` as it's "backend". Currently only the CPU backend running on x86_64-linux is packaged. TODO, unfinished items left to future PRs: - [x] Fix `jnp.array([1, 2, 3])`. - [x] Run the jax test suite. - [x] GPU backend support - [ ] TPU backend support - [ ] Fix the build on macOS. Currently segfaults when running the test suite. Useful resources: * https://jax.readthedocs.io/en/latest/developer.html#running-the-tests * https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md ###### Things done Created derivations for the jax and jaxlib python packages. - [ ] Tested using sandboxing ([nix.useSandbox](https://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](https://nixos.org/nix/manual/#sec-conf-file) on non-NixOS linux) - Built on platform(s) - [x] NixOS - [x] macOS - [ ] other Linux distributions - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [x] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

Ma27 · August 31, 2021, 11:23am

I could use someone to proof-read nixos/nextcloud: add some notes for `Error: Command "upgrade" is not defined.` by Ma27 · Pull Request #135958 · NixOS/nixpkgs · GitHub

samuela · September 9, 2021, 7:16am

I’ve got a few that should be ready to go!

https://github.com/NixOS/nixpkgs/pull/137069
cudatoolkit_11_{3,4}: init at 11.{3,4}.1 by samuela · Pull Request #136655 · NixOS/nixpkgs · GitHub
jax: init at 0.2.19, jaxlib: init at 0.1.71 by samuela · Pull Request #134894 · NixOS/nixpkgs · GitHub

julm · September 10, 2021, 3:08pm

riseup-vpn / calyx-vpn : bitmask-vpn: init at 0.21.6 by ju1m · Pull Request #137247 · NixOS/nixpkgs · GitHub
sourcehut : nixos/sourcehut: updates, fixes, hardening by ju1m · Pull Request #133984 · NixOS/nixpkgs · GitHub
public-inbox : Update public-inbox to 1.8.0 and add systemd services by ju1m · Pull Request #104457 · NixOS/nixpkgs · GitHub
transmission : transmission: use freeformType on settings and various fixes by ju1m · Pull Request #96655 · NixOS/nixpkgs · GitHub
pipe-viewer : pipe-viewer: init at 0.1.4 by ju1m · Pull Request #136119 · NixOS/nixpkgs · GitHub
openvpn / netns : nixos/openvpn: add network namespace support by ju1m · Pull Request #109643 · NixOS/nixpkgs · GitHub

tomberek · September 10, 2021, 3:31pm

@julm I’m out for the weekend with zero technology, but I’ll take a look at these when I have a chance thereafter. (especially the sourcehut, thanks!)

bbigras · September 10, 2021, 3:45pm

~~https://github.com/NixOS/nixpkgs/pull/136848~~

romildo · September 11, 2021, 12:21pm

github.com/NixOS/nixpkgs

numix-solarized-gtk-theme: 20210522 -> 20210831

NixOS:master ← romildo:upd.numix-solarized-gtk-theme

opened 02:25PM - 01 Sep 21 UTC

romildo

+4 -3

###### Motivation for this change Update to version [20210831](https://github.com/Ferdi265/numix-solarized-gtk-theme/releases/tag/20210831) ###### Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [ ] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

spacegreg · September 12, 2021, 9:52am

github.com/NixOS/nixpkgs

xoscope: 2.0 -> 2.3

NixOS:master ← yl3dy:xoscope

opened 01:02PM - 27 Aug 21 UTC

yl3dy

+33 -75

###### Motivation for this change Newer version supports ALSA (2.0 didn't wor…k for me even through `padsp`) and COMEDI properly. Also updated `gtkdatabox` dependency and assigned it to myself since it had been an orphan. ###### Things done - Built on platform(s) - [x] x86_64-linux - [x] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [x] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [x] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

aanderse · September 12, 2021, 1:52pm

Package looking for review (module has already been reviewed and approved):

github.com/NixOS/nixpkgs

prowlarr: init at 0.1.1.978

NixOS:master ← jdreaver:prowlarr

opened 03:23PM - 28 Aug 21 UTC

jdreaver

+190 -0

###### Motivation for this change https://github.com/NixOS/nixpkgs/issues/135887 This PR adds a new package and NixOS service for [Prowlarr](https://wiki.servarr.com/prowlarr). This is an indexer similar to `jackett` (which is already in nixpkgs), but is newer and more well-integrated with the *arr ecosystem (e.g. `radarr` and `sonarr`, which are also already in `nixpkgs`). I mostly copied the config from `radarr` and fixed the `prowlarr`-specific bits. In particular, the `update.sh` script had to be modified because the releases are not official releases yet, so we have to specify the version we want to use. **This is my first significant `nixpkgs` PR.** I've updated the versions of packages before, but I've never added a new service from scratch. I would think anyone who is a maintainer for `radarr` could/should review this. I'm also happy to add myself as a maintainer for this package, but I'm not sure what the protocol on that is. I used this `nixpkgs` fork and enabled `prowlarr` in my home server's NixOS config, and it worked flawlessly, so this has basically been tested end-to-end. ###### Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [x] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [x] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [x] (Module addition) Added a release notes entry if adding a new NixOS module - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

cab · September 14, 2021, 12:41pm

github.com/NixOS/nixpkgs

super-slicer.stable: 2.3.56.8 -> 2.3.56.9

NixOS:master ← cab404:super-slicer-2.3.56.9

opened 06:19AM - 07 Sep 21 UTC

cab404

+16 -5

also, super-slicer.staging: init at 2.3.57.0  ###### Motivation for this change ###### Things done - Built on platform(s) - [X] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [x] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

zakame · September 14, 2021, 2:48pm

Hi, I’m looking for reviews for

github.com/NixOS/nixpkgs

taoup: init at 1.1.14

NixOS:master ← zakame:contrib/ruby-taoup

opened 05:45AM - 05 Sep 21 UTC

zakame

+137 -0

###### Motivation for this change https://github.com/globalcitizen/taoup is a… `fortune`-like tool that tells some words of wisdom from _The Art of Unix Programming_ and other sources. Some patches are included to simplify the `taoup-fortune` example script (which tries to produce a cache directory at first run - we instead create and populate this at build time,) and `taoup` itself (which tries to test for `tput` - avoid that and just depend on `ncurses` to provide that instead.) I suspect some improvements can be made still at the `postPatch` and `installPhase` steps - I'd love to hear anyone's guidance on this :pray: Thanks! ###### Things done - Built on platform(s) - [X] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [x] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [X] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [X] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

thanks!

roberth · September 16, 2021, 5:34pm

Test automation for fetchers!

They used to be tricky to hack on because they don’t re-run after completing once. With this technique, we can have tests as usual.

github.com/NixOS/nixpkgs

Fetcher testing

NixOS:master ← hercules-ci:fetcher-testing

opened 08:34AM - 28 Aug 21 UTC

roberth

+65 -4

###### Motivation for this change Make maintenance easier on the fetchers and… avoid problems. The `packageTests` attribute will serve two purposes: - for ofborg: allow it to build tests in a __functor attrset like `fetchgit` - for hydra, potentially, build the package tests. Enabling these is not part of this PR. Closes #133739 Refs #128749 #135881 or really all of [topic: fetch](https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+is%3Aopen++label%3A%226.topic%3A+fetch%22+) ###### Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [ ] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

nappa · September 16, 2021, 9:09pm

Can someone take a look at this, that has been ignored for a couple of weeks (maintainer is not responding, and the same happened with #134390, but that one was merged).

It should be merged, because the complicated license doesn’t allow free distribution of that code.
And I need it to be merged so I can send my other PRs to fix the build on darwin and fix/enable the Python interface.

I can take over maintenance, since I’ve put a lot of work to fix the package (including merged #134390 and #134393, and my upcoming PRs).

github.com/NixOS/nixpkgs

shogun: remove non-distributable SVMlight code

NixOS:master ← smancill:shogun-remove-svmlight

opened 12:11AM - 03 Sep 21 UTC

smancill

+96 -2

###### Motivation for this change Shogun is using non-distributable SVMLight …code that should be removed from the package. SVMLight uses a [non-standard license](https://github.com/shogun-toolbox/shogun/blob/shogun_6.1.4/doc/license/LICENSE_SVMlight.md) that doesn't allow distribution without the author's permission: > The software must not be modified and distributed without prior permission of the author. ---- I am working on a PR to fix Shogun on Darwin and add it as a Python module, and that's why I found that currently it is built with SVMLight, which should not be packaged on a distribution. Upstream's own Debian package, Fedora, Conda, they all remove it. I think this had to be its own PR, and maybe backported to 21.05. ###### Things done Remove all SVMLight code when building the binary package. Use upstream's own script to do it (which they use to create and distribute their own Debian package), with a few fixes (see added patch file). - Built on platform(s) - [X] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin (currently broken on Darwin, I will send the fix in a new PR) - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [ ] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

illustris · September 18, 2021, 7:26am

Can someone review these PRs open for a couple of weeks?

github.com/NixOS/nixpkgs

octoprint.python.pkgs.octolapse: init at 0.4.1

NixOS:master ← j0hax:octolapse

opened 09:56PM - 02 Sep 21 UTC

j0hax

+48 -0

###### Motivation for this change Package the popular Octolapse plugin along with an additional python dependency ###### Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [x] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

github.com/NixOS/nixpkgs

octoprint.python.pkgs.ender3v2tempfix: init at unstable-2021-04-27

NixOS:master ← illustris:octoprint

opened 04:23AM - 01 Sep 21 UTC

illustris

+19 -0

###### Motivation for this change - using octoprint with certain Creality printers requires the temperature reporting fix plugin - octolapse is a popular plugin for octoprint ###### Things done - Built on platform(s) - [x] x86_64-linux - [x] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [x] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [x] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

jasper · September 25, 2021, 10:59am

This change of the resilio-sync module has been sitting for a couple of months. It introduces the option of managing resilio sync secrets using secret files, so those secrets don’t need to end up in the nix store. I’d super appreciate a review!

github.com/NixOS/nixpkgs

nixos/resilio: support secret files

NixOS:master ← jwoudenberg:master

opened 02:46PM - 05 Jun 21 UTC

jwoudenberg

+41 -7

###### Motivation for this change The Resilio nixos module supports declarati…vely configuring Resilio using the `sharedFolders` attribute. Secrets for shared folders can be passed using the `secret` attribute, with the downside that these secrets will end up in the nix store. The goal of this change is to allow shared folder secrets to be specified without requiring they be put in the nix store, without breaking backwards compatibility with existing Resilio module configurations. It follows the approach outlined in the issue below, for upstream packages that do not provide password file support out of the box: https://github.com/NixOS/nixpkgs/issues/24288 The change also modifies documentation to encourage the use of the new secret file support, because it seems like the safer default to me, but I don't feel strongly about that and am happy to change that back. ###### Things done - [x] Tested using sandboxing ([nix.useSandbox](https://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](https://nixos.org/nix/manual/#sec-conf-file) on non-NixOS linux) - Built on platform(s) - [x] NixOS - [ ] macOS - [ ] other Linux distributions - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [x] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes](./CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [x] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).