PRs ready for review _

Hi,

this is my first pull request and I would need some help. Especially how to use $out in configureFlags list. These are not evaluated and I set the flag needing $out in preConfigure. Can you confirm, that this is the problem stopping the merging process?

https://github.com/NixOS/nixpkgs/pull/134067

https://github.com/NixOS/nixpkgs/pull/133539

Includes a critical security patch, would be great to merge asap:

https://github.com/NixOS/nixpkgs/pull/135524

Just a simple backport of a new package that I’d like to install locally without patching or so:
https://github.com/NixOS/nixpkgs/pull/134534

Was messy at start, now we’re good to go!
https://github.com/NixOS/nixpkgs/pull/136095

https://github.com/NixOS/nixpkgs/pull/134894

I could use someone to proof-read nixos/nextcloud: add some notes for `Error: Command "upgrade" is not defined.` by Ma27 · Pull Request #135958 · NixOS/nixpkgs · GitHub :slight_smile:

I’ve got a few that should be ready to go!

@julm I’m out for the weekend with zero technology, but I’ll take a look at these when I have a chance thereafter. (especially the sourcehut, thanks!)

1 Like

https://github.com/NixOS/nixpkgs/pull/136848

https://github.com/NixOS/nixpkgs/pull/136389

https://github.com/NixOS/nixpkgs/pull/135906

Package looking for review (module has already been reviewed and approved):

https://github.com/NixOS/nixpkgs/pull/136039

https://github.com/NixOS/nixpkgs/pull/136962

Hi, I’m looking for reviews for

https://github.com/NixOS/nixpkgs/pull/136751

thanks!

Test automation for fetchers!

They used to be tricky to hack on because they don’t re-run after completing once. With this technique, we can have tests as usual.

https://github.com/NixOS/nixpkgs/pull/136022

Can someone take a look at this, that has been ignored for a couple of weeks (maintainer is not responding, and the same happened with #134390, but that one was merged).

It should be merged, because the complicated license doesn’t allow free distribution of that code.
And I need it to be merged so I can send my other PRs to fix the build on darwin and fix/enable the Python interface.

I can take over maintenance, since I’ve put a lot of work to fix the package (including merged #134390 and #134393, and my upcoming PRs).

https://github.com/NixOS/nixpkgs/pull/136526

Can someone review these PRs open for a couple of weeks?

https://github.com/NixOS/nixpkgs/pull/136513
https://github.com/NixOS/nixpkgs/pull/136349

This change of the resilio-sync module has been sitting for a couple of months. It introduces the option of managing resilio sync secrets using secret files, so those secrets don’t need to end up in the nix store. I’d super appreciate a review!

https://github.com/NixOS/nixpkgs/pull/125803

Hosted by Flying Circus.